The NetBSD Project

CVS log for src/common/lib/libprop/prop_string.c

[BACK] Up to [cvs.NetBSD.org] / src / common / lib / libprop

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.17.2.1 / (download) - annotate - [select for diffs], Sun Nov 26 12:29:49 2023 UTC (4 months, 2 weeks ago) by bouyer
Branch: netbsd-10
CVS Tags: netbsd-10-0-RELEASE, netbsd-10-0-RC6, netbsd-10-0-RC5, netbsd-10-0-RC4, netbsd-10-0-RC3, netbsd-10-0-RC2
Changes since 1.17: +11 -25 lines
Diff to previous 1.17 (colored) next main 1.18 (colored)

Pull up following revision(s) (requested by thorpej in ticket #467):
	common/lib/libprop/prop_string.c: revision 1.18
In _prop_string_instantiate(), when we de-dup a non-MUTABLE string, make
sure we free the provided string buffer if NOCOPY is not set.  Fixes
a memory leak reported by M. Boerschig.
While we're at it, also change _prop_string_instantiate() to free the
provided string buffer in the not-NOCOPY case when string object allocation
fails (this was previously handled by _prop_string_instantiate()'s
callers).
PR lib/57699

Revision 1.18 / (download) - annotate - [select for diffs], Fri Nov 17 21:29:33 2023 UTC (4 months, 3 weeks ago) by thorpej
Branch: MAIN
CVS Tags: HEAD
Changes since 1.17: +11 -25 lines
Diff to previous 1.17 (colored)

In _prop_string_instantiate(), when we de-dup a non-MUTABLE string, make
sure we free the provided string buffer if NOCOPY is not set.  Fixes
a memory leak reported by M. Boerschig.

While we're at it, also change _prop_string_instantiate() to free the
provided string buffer in the not-NOCOPY case when string object allocation
fails (this was previously handled by _prop_string_instantiate()'s
callers).

PR lib/57699

Revision 1.17 / (download) - annotate - [select for diffs], Wed Aug 3 21:13:46 2022 UTC (20 months, 1 week ago) by riastradh
Branch: MAIN
CVS Tags: thorpej-ifq-base, thorpej-ifq, thorpej-altq-separation-base, thorpej-altq-separation, netbsd-10-base, netbsd-10-0-RC1
Branch point for: netbsd-10
Changes since 1.16: +14 -14 lines
Diff to previous 1.16 (colored)

proplib: Nix trailing whitespace.

Revision 1.16 / (download) - annotate - [select for diffs], Tue Sep 7 13:24:45 2021 UTC (2 years, 7 months ago) by andvar
Branch: MAIN
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

s/aquire/acquire/ in comments, also one typo fix acqure->acquire.

Revision 1.15 / (download) - annotate - [select for diffs], Sat Jun 20 00:16:50 2020 UTC (3 years, 9 months ago) by christos
Branch: MAIN
CVS Tags: cjep_sun2x-base1, cjep_sun2x-base, cjep_sun2x, cjep_staticlib_x-base1, cjep_staticlib_x-base, cjep_staticlib_x
Changes since 1.14: +6 -4 lines
Diff to previous 1.14 (colored)

Fix lint

Revision 1.14 / (download) - annotate - [select for diffs], Sat Jun 6 21:25:59 2020 UTC (3 years, 10 months ago) by thorpej
Branch: MAIN
Changes since 1.13: +322 -95 lines
Diff to previous 1.13 (colored)

Improvements to the problib(3) API:

==> Provide a much more complete set of setters and getters for different
    value types in the prop_array_util(3) and prop_dictionary_util(3)
    functions.

==> Overhaul the prop_data(3), prop_number(3), and prop_string(3) APIs
    to be easier to use and less awkwardly named,  Deprecate the old
    awkward names, and produce link-time warnings when they are referenced.

==> Deprecate mutable prop_data(3) and prop_string(3) objects.  The old
    APIs that support them still exist, but will now produce link-time
    warnings when used.

==> When the new prop_string(3) API is used, strings are internally
    de-duplicated as a memory footprint optimization.

==> Provide a rich set of bounds-checked gettter functions in and a
    corresponding set of convenience setters in the prop_number(3) API.

==> Add a new prop_bool_value(3) function that is equivalent to
    prop_bool_true(3), but aligned with the new "value" routines in
    prop_data(3), prop_string(3), and prop_number(3).

Revision 1.12.26.3 / (download) - annotate - [select for diffs], Tue Apr 21 19:37:51 2020 UTC (3 years, 11 months ago) by martin
Branch: phil-wifi
Changes since 1.12.26.2: +1 -1 lines
Diff to previous 1.12.26.2 (colored) to branchpoint 1.12 (colored) next main 1.13 (colored)

Ooops, restore accidently removed files from merge mishap

Revision 1.12.26.2, Tue Apr 21 18:41:25 2020 UTC (3 years, 11 months ago) by martin
Branch: phil-wifi
Changes since 1.12.26.1: +1 -1 lines
FILE REMOVED

Sync with HEAD

Revision 1.12.26.1 / (download) - annotate - [select for diffs], Mon Jun 10 21:41:08 2019 UTC (4 years, 10 months ago) by christos
Branch: phil-wifi
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

Sync with HEAD

Revision 1.13 / (download) - annotate - [select for diffs], Wed May 8 02:25:50 2019 UTC (4 years, 11 months ago) by thorpej
Branch: MAIN
CVS Tags: phil-wifi-20200421, phil-wifi-20200411, phil-wifi-20200406, phil-wifi-20191119, phil-wifi-20190609, netbsd-9-base, netbsd-9-3-RELEASE, netbsd-9-2-RELEASE, netbsd-9-1-RELEASE, netbsd-9-0-RELEASE, netbsd-9-0-RC2, netbsd-9-0-RC1, netbsd-9, is-mlppp-base, is-mlppp, bouyer-xenpvh-base2, bouyer-xenpvh-base1, bouyer-xenpvh-base, bouyer-xenpvh, ad-namecache-base3, ad-namecache-base, ad-namecache
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

Fix building libprop as a host tool library on platforms that don't have
the Matt Thomas rbtree:

- Include rb.c in libnbcompat, and provide a nbcompat sys/rbtree.h
  header.
- Make sure libprop's source file include prop_object_impl.h before
  anything else, and pull in nbtool_config.h from there.

Tested by simulating such a host system by renaming the host's
<sys/rbtree.h> out of the way (which reproduced the build failure)
and verifying that the host-tool installboot contained the rb_*
functions in its own .text segment.

Revision 1.11.24.1 / (download) - annotate - [select for diffs], Tue Aug 19 23:45:15 2014 UTC (9 years, 7 months ago) by tls
Branch: tls-maxphys
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored) next main 1.12 (colored)

Rebase to HEAD as of a few days ago.

Revision 1.11.2.1 / (download) - annotate - [select for diffs], Thu May 22 11:26:30 2014 UTC (9 years, 10 months ago) by yamt
Branch: yamt-pagecache
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored) next main 1.12 (colored)

sync with head.

for a reference, the tree before this commit was tagged
as yamt-pagecache-tag8.

this commit was splitted into small chunks to avoid
a limitation of cvs.  ("Protocol error: too many arguments")

Revision 1.12 / (download) - annotate - [select for diffs], Wed Mar 26 18:12:46 2014 UTC (10 years ago) by christos
Branch: MAIN
CVS Tags: yamt-pagecache-base9, tls-maxphys-base, tls-maxphys-20171202, tls-earlyentropy-base, tls-earlyentropy, riastradh-xf86-video-intel-2-7-1-pre-2-21-15, prg-localcount2-base3, prg-localcount2-base2, prg-localcount2-base1, prg-localcount2-base, prg-localcount2, phil-wifi-base, pgoyette-localcount-base, pgoyette-localcount-20170426, pgoyette-localcount-20170320, pgoyette-localcount-20170107, pgoyette-localcount-20161104, pgoyette-localcount-20160806, pgoyette-localcount-20160726, pgoyette-localcount, pgoyette-compat-merge-20190127, pgoyette-compat-base, pgoyette-compat-20190127, pgoyette-compat-20190118, pgoyette-compat-1226, pgoyette-compat-1126, pgoyette-compat-1020, pgoyette-compat-0930, pgoyette-compat-0906, pgoyette-compat-0728, pgoyette-compat-0625, pgoyette-compat-0521, pgoyette-compat-0502, pgoyette-compat-0422, pgoyette-compat-0415, pgoyette-compat-0407, pgoyette-compat-0330, pgoyette-compat-0322, pgoyette-compat-0315, pgoyette-compat, perseant-stdc-iso10646-base, perseant-stdc-iso10646, netbsd-8-base, netbsd-8-2-RELEASE, netbsd-8-1-RELEASE, netbsd-8-1-RC1, netbsd-8-0-RELEASE, netbsd-8-0-RC2, netbsd-8-0-RC1, netbsd-8, netbsd-7-nhusb-base-20170116, netbsd-7-nhusb-base, netbsd-7-nhusb, netbsd-7-base, netbsd-7-2-RELEASE, netbsd-7-1-RELEASE, netbsd-7-1-RC2, netbsd-7-1-RC1, netbsd-7-1-2-RELEASE, netbsd-7-1-1-RELEASE, netbsd-7-1, netbsd-7-0-RELEASE, netbsd-7-0-RC3, netbsd-7-0-RC2, netbsd-7-0-RC1, netbsd-7-0-2-RELEASE, netbsd-7-0-1-RELEASE, netbsd-7-0, netbsd-7, matt-nb8-mediatek-base, matt-nb8-mediatek, localcount-20160914, bouyer-socketcan-base1, bouyer-socketcan-base, bouyer-socketcan
Branch point for: phil-wifi
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

kill sprintf

Revision 1.10.2.1 / (download) - annotate - [select for diffs], Thu Sep 18 04:54:19 2008 UTC (15 years, 6 months ago) by wrstuden
Branch: wrstuden-revivesa
Changes since 1.10: +9 -7 lines
Diff to previous 1.10 (colored) next main 1.11 (colored)

Sync with wrstuden-revivesa-base-2.

Revision 1.11 / (download) - annotate - [select for diffs], Sun Aug 3 04:00:12 2008 UTC (15 years, 8 months ago) by thorpej
Branch: MAIN
CVS Tags: yamt-pagecache-tag8, yamt-pagecache-base8, yamt-pagecache-base7, yamt-pagecache-base6, yamt-pagecache-base5, yamt-pagecache-base4, yamt-pagecache-base3, yamt-pagecache-base2, yamt-pagecache-base, yamt-nfs-mp-base9, yamt-nfs-mp-base8, yamt-nfs-mp-base7, yamt-nfs-mp-base6, yamt-nfs-mp-base5, yamt-nfs-mp-base4, yamt-nfs-mp-base3, yamt-nfs-mp-base11, yamt-nfs-mp-base10, wrstuden-revivesa-base-3, wrstuden-revivesa-base-2, rmind-uvmplock-base, rmind-smpnet-nbase, rmind-smpnet-base, riastradh-drm2-base3, riastradh-drm2-base2, riastradh-drm2-base1, riastradh-drm2-base, riastradh-drm2, netbsd-6-base, netbsd-6-1-RELEASE, netbsd-6-1-RC4, netbsd-6-1-RC3, netbsd-6-1-RC2, netbsd-6-1-RC1, netbsd-6-1-5-RELEASE, netbsd-6-1-4-RELEASE, netbsd-6-1-3-RELEASE, netbsd-6-1-2-RELEASE, netbsd-6-1-1-RELEASE, netbsd-6-1, netbsd-6-0-RELEASE, netbsd-6-0-RC2, netbsd-6-0-RC1, netbsd-6-0-6-RELEASE, netbsd-6-0-5-RELEASE, netbsd-6-0-4-RELEASE, netbsd-6-0-3-RELEASE, netbsd-6-0-2-RELEASE, netbsd-6-0-1-RELEASE, netbsd-6-0, netbsd-6, netbsd-5-base, netbsd-5-2-RELEASE, netbsd-5-2-RC1, netbsd-5-2-3-RELEASE, netbsd-5-2-2-RELEASE, netbsd-5-2-1-RELEASE, netbsd-5-2, netbsd-5-1-RELEASE, netbsd-5-1-RC4, netbsd-5-1-RC3, netbsd-5-1-RC2, netbsd-5-1-RC1, netbsd-5-1-5-RELEASE, netbsd-5-1-4-RELEASE, netbsd-5-1-3-RELEASE, netbsd-5-1-2-RELEASE, netbsd-5-1-1-RELEASE, netbsd-5-1, netbsd-5-0-RELEASE, netbsd-5-0-RC4, netbsd-5-0-RC3, netbsd-5-0-RC2, netbsd-5-0-RC1, netbsd-5-0-2-RELEASE, netbsd-5-0-1-RELEASE, netbsd-5-0, netbsd-5, matt-premerge-20091211, matt-nb6-plus-nbase, matt-nb6-plus-base, matt-nb6-plus, matt-nb5-pq3-base, matt-nb5-pq3, matt-nb5-mips64-u2-k2-k4-k7-k8-k9, matt-nb5-mips64-u1-k1-k5, matt-nb5-mips64-premerge-20101231, matt-nb5-mips64-premerge-20091211, matt-nb5-mips64-k15, matt-nb5-mips64, matt-nb4-mips64-k7-u2a-k9b, matt-mips64-premerge-20101231, matt-mips64-base2, khorben-n900, jymxensuspend-base, jym-xensuspend-nbase, jym-xensuspend-base, jym-xensuspend, cherry-xenmp-base, cherry-xenmp, bouyer-quota2-nbase, bouyer-quota2-base, bouyer-quota2, agc-symver-base, agc-symver
Branch point for: yamt-pagecache, tls-maxphys
Changes since 1.10: +9 -7 lines
Diff to previous 1.10 (colored)

Fix an issue introduced with the prop_stack change: It's not a good idea to
return a 3-value enum from a function declared to return bool.  This broke
the recurse case for prop_object_equals().  Instead, declare the object type
equals routine to return a _prop_object_equals_rv_t.

Give the same treatment to the object type free routines: declare them to
return a _prop_object_free_rv_t, and consistently check those return values
againt the enum type.

Tidy up some whitespace while we're here.

Revision 1.9.6.1 / (download) - annotate - [select for diffs], Sun May 18 12:28:47 2008 UTC (15 years, 10 months ago) by yamt
Branch: yamt-pf42
Changes since 1.9: +1 -8 lines
Diff to previous 1.9 (colored) next main 1.10 (colored)

sync with head.

Revision 1.10 / (download) - annotate - [select for diffs], Mon Apr 28 20:22:53 2008 UTC (15 years, 11 months ago) by martin
Branch: MAIN
CVS Tags: yamt-pf42-base4, yamt-pf42-base3, yamt-pf42-base2, yamt-nfs-mp-base2, wrstuden-revivesa-base-1, wrstuden-revivesa-base, hpcarm-cleanup-nbase
Branch point for: wrstuden-revivesa
Changes since 1.9: +1 -8 lines
Diff to previous 1.9 (colored)

Remove clause 3 and 4 from TNF licenses

Revision 1.8.2.1 / (download) - annotate - [select for diffs], Tue Nov 6 23:07:29 2007 UTC (16 years, 5 months ago) by matt
Branch: matt-armv6
CVS Tags: matt-armv6-prevmlocking
Changes since 1.8: +17 -12 lines
Diff to previous 1.8 (colored) next main 1.9 (colored)

sync with HEAD

Revision 1.6.12.1 / (download) - annotate - [select for diffs], Sun Sep 30 03:38:50 2007 UTC (16 years, 6 months ago) by wrstuden
Branch: wrstuden-fixsa
Changes since 1.6: +75 -62 lines
Diff to previous 1.6 (colored) next main 1.7 (colored)

Catch up on netbsd-4 as of a few days ago.

Revision 1.6.4.1 / (download) - annotate - [select for diffs], Thu Sep 27 16:16:25 2007 UTC (16 years, 6 months ago) by xtraeme
Branch: netbsd-4
CVS Tags: wrstuden-fixsa-newbase, wrstuden-fixsa-base-1, wrstuden-fixsa-base, netbsd-4-0-RELEASE, netbsd-4-0-RC5, netbsd-4-0-RC4, netbsd-4-0-RC3, netbsd-4-0-RC2, netbsd-4-0-1-RELEASE, netbsd-4-0
Changes since 1.6: +75 -62 lines
Diff to previous 1.6 (colored) next main 1.7 (colored)

Pull up following revision(s) (requested by joerg in ticket #904):
	sbin/veriexecctl/veriexecctl.c: revision 1.29 (via patch)
	common/lib/libprop/prop_string.c: revision 1.9 (via patch)
	distrib/sets/lists/comp/mi: revision 1.1063 (via patch)
	common/lib/libprop/prop_kern.c: revision 1.8 (via patch)
	common/include/prop/prop_string.h: revision 1.2 (via patch)
	common/include/prop/prop_ingest.h: revision 1.2 (via patch)
	usr.sbin/btdevctl/btdevctl.c: revision 1.5 (via patch)
	common/lib/libprop/prop_object_impl.h: revision 1.14 (via patch)
	common/lib/libprop/prop_rb.c: revision 1.7 (via patch)
	common/include/prop/prop_array.h: revision 1.5 (via patch)
	common/lib/libprop/prop_stack.h: revision 1.1 (via patch)
	common/lib/libprop/prop_object_impl.h: revision 1.16 (via patch)
	common/lib/libprop/prop_number.3: revision 1.7 (via patch)
	common/lib/libprop/prop_stack.h: revision 1.2 (via patch)
	common/lib/libprop/prop_stack.c: revision 1.1 (via patch)
	common/lib/libprop/prop_object_impl.h: revision 1.17 (via patch)
	common/lib/libprop/prop_dictionary_util.c: revision 1.2 (via patch)
	common/lib/libprop/prop_dictionary_util.3: revision 1.2 (via patch)
	common/lib/libprop/prop_dictionary.c: revision 1.18 (via patch)
	common/lib/libprop/prop_stack.c: revision 1.2 (via patch)
	common/lib/libprop/prop_object_impl.h: revision 1.18 (via patch)
	common/lib/libprop/prop_dictionary.c: revision 1.19 (via patch)
	common/include/prop/prop_bool.h: revision 1.3 (via patch)
	common/include/prop/prop_dictionary.h: revision 1.7 (via patch)
	common/include/prop/prop_data.h: revision 1.2 (via patch)
	sys/sys/dkio.h: revision 1.14 (via patch)
	usr.sbin/btdevctl/sdp.c: revision 1.4 (via patch)
	common/include/prop/Makefile: revision 1.3 (via patch)
	common/include/prop/prop_number.h: revision 1.5 (via patch)
	common/lib/libprop/prop_object.c: revision 1.14 (via patch)
	common/lib/libprop/prop_object.c: revision 1.15 (via patch)
	common/lib/libprop/prop_object.c: revision 1.16 (via patch)
	common/lib/libprop/prop_bool.3: revision 1.3 (via patch)
	common/lib/libprop/prop_data.3: revision 1.4 (via patch)
	common/lib/libprop/prop_object.3: revision 1.6 (via patch)
	common/lib/libprop/prop_data.c: revision 1.7 (via patch)
	common/lib/libprop/prop_data.c: revision 1.8 (via patch)
	common/lib/libprop/prop_data.c: revision 1.9 (via patch)
	common/lib/libprop/prop_dictionary.c: revision 1.20 (via patch)
	usr.sbin/btdevctl/print.c: revision 1.9 (via patch)
	sbin/veriexecctl/veriexecctl_parse.y: revision 1.22 (via patch)
	common/lib/libprop/prop_number.c: revision 1.12 (via patch)
	common/include/prop/proplib.h: revision 1.5 (via patch)
	common/lib/libprop/prop_number.c: revision 1.13 (via patch)
	common/lib/libprop/prop_number.c: revision 1.14 (via patch)
	common/include/prop/prop_object.h: revision 1.5 (via patch)
	common/lib/libprop/prop_array.3: revision 1.5 (via patch)
	common/include/prop/prop_object.h: revision 1.6 (via patch)
	common/lib/libprop/prop_string.3: revision 1.4 (via patch)
	common/lib/libprop/prop_bool.c: revision 1.10 (via patch)
	common/lib/libprop/Makefile.inc: revision 1.6 (via patch)
	common/lib/libprop/prop_ingest.c: revision 1.2 (via patch)
	common/lib/libprop/prop_bool.c: revision 1.11 (via patch)
	common/lib/libprop/prop_array.c: revision 1.10 (via patch)
	common/lib/libprop/prop_ingest.3: revision 1.3 (via patch)
	common/lib/libprop/prop_bool.c: revision 1.12 (via patch)
	common/lib/libprop/prop_array.c: revision 1.11 (via patch)
	common/lib/libprop/prop_string.c: revision 1.7 (via patch)
	common/lib/libprop/prop_dictionary.3: revision 1.8 (via patch)
	common/lib/libprop/prop_array.c: revision 1.9 (via patch)
	usr.sbin/btdevctl/db.c: revision 1.4 (via patch)
	common/lib/libprop/prop_string.c: revision 1.8 (via patch)
	common/include/prop/plistref.h: revision 1.1 (via patch)
Consider '\r' to be white space. Discussed with and also kept as local
change by freza. With this change, DOS style line endings work.

boolean_t -> bool
TRUE -> true
FALSE -> false

libprop is currently using a recursive parser. While this is fine for
userland, deeply nested arrays and dictionaries can easily overflow
the kernel stack and thereby force a panic.

Fix the internalizer and prop_object_release to use a separate call
stack and alter the dictionary and array handling to not recurse on
the C stack. The default stack has an inline depth of 16 elements,
which should keep the overhead reasonable.

This issue was found by Pavel Cahyna and Jachym Holecek.

Additionally add a limit for prop_object_copyin_ioctl to prevent user
programs from temporary allocating unbound amount of kernel memory.

Allow malloc to fail so that tight loops of userland processes can't
force panics by exhausting the kernel map.

Tested with the sample exploit of Jachym, his test suite and reviewed
by himself (initial patch), Christos Zoulas and Jason Thorpe.
struct plistref does not reference other proplib data types, so split it
in its own header file to be included by dkio.h. Fixes breakage due to
pollution from proplib.h in programs which include ioctl.h. Tested and OK
by dogcow@.

Attempt at fixing build failures after proplib was converted to bool:
FALSE -> false, TRUE -> true, boolean_t -> bool, int -> bool when
appropriate, include stdbool.h . proplib.h no longer provides boolean_t,
so it is necessary to change to bool.
From Tom Spindler (dogcow@).

Avoid using unbound amount of stack frames in prop_object_equal
by using a dynamic stack as well. Reorder arguments for the internalizer
as the iteration is always present and should go before possibly
NULL arguments.
Reviewed by mjf@ and adrianp@

Revision 1.9 / (download) - annotate - [select for diffs], Thu Aug 30 12:23:54 2007 UTC (16 years, 7 months ago) by joerg
Branch: MAIN
CVS Tags: yamt-x86pmap-base4, yamt-x86pmap-base3, yamt-x86pmap-base2, yamt-x86pmap-base, yamt-pf42-baseX, yamt-pf42-base, yamt-nfs-mp-base, yamt-lazymbuf-base15, yamt-lazymbuf-base14, yamt-kmem-base3, yamt-kmem-base2, yamt-kmem-base, reinoud-bufcleanup-nbase, reinoud-bufcleanup-base, matt-armv6-nbase, matt-armv6-base, keiichi-mipv6-base, keiichi-mipv6, hpcarm-cleanup-base, cube-autoconf-base, cube-autoconf
Branch point for: yamt-pf42
Changes since 1.8: +17 -12 lines
Diff to previous 1.8 (colored)

Avoid using unbound amount of stack frames in prop_object_equal
by using a dynamic stack as well. Reorder arguments for the internalizer
as the iteration is always present and should go before possibly
NULL arguments.

Reviewed by mjf@ and adrianp@

Revision 1.8 / (download) - annotate - [select for diffs], Thu Aug 16 21:44:08 2007 UTC (16 years, 8 months ago) by joerg
Branch: MAIN
Branch point for: matt-armv6
Changes since 1.7: +28 -20 lines
Diff to previous 1.7 (colored)

libprop is currently using a recursive parser. While this is fine for
userland, deeply nested arrays and dictionaries can easily overflow
the kernel stack and thereby force a panic.

Fix the internalizer and prop_object_release to use a separate call
stack and alter the dictionary and array handling to not recurse on
the C stack. The default stack has an inline depth of 16 elements,
which should keep the overhead reasonable.

This issue was found by Pavel Cahyna and Jachym Holecek.

Additionally add a limit for prop_object_copyin_ioctl to prevent user
programs from temporary allocating unbound amount of kernel memory.
Allow malloc to fail so that tight loops of userland processes can't
force panics by exhausting the kernel map.

Tested with the sample exploit of Jachym, his test suite and reviewed
by himself (initial patch), Christos Zoulas and Jason Thorpe.

Revision 1.7 / (download) - annotate - [select for diffs], Thu Aug 16 16:28:18 2007 UTC (16 years, 8 months ago) by thorpej
Branch: MAIN
Changes since 1.6: +36 -36 lines
Diff to previous 1.6 (colored)

boolean_t -> bool
TRUE -> true
FALSE -> false

Revision 1.6.2.2 / (download) - annotate - [select for diffs], Wed Oct 18 19:15:47 2006 UTC (17 years, 5 months ago) by martin
Branch: newlock2
Changes since 1.6.2.1: +463 -0 lines
Diff to previous 1.6.2.1 (colored) to branchpoint 1.6 (colored) next main 1.7 (colored)

Backout size_t casts - lint has been fixed.

Revision 1.6.2.1, Wed Oct 18 19:15:46 2006 UTC (17 years, 5 months ago) by martin
Branch: newlock2
Changes since 1.6: +0 -463 lines
FILE REMOVED

file prop_string.c was added on branch newlock2 on 2006-10-18 19:15:47 +0000

Revision 1.6 / (download) - annotate - [select for diffs], Wed Oct 18 19:15:46 2006 UTC (17 years, 5 months ago) by martin
Branch: MAIN
CVS Tags: yamt-splraiseipl-base5, yamt-splraiseipl-base4, yamt-splraiseipl-base3, yamt-splraiseipl-base2, yamt-idlelwp-base8, vmlocking-base, vmlocking, thorpej-atomic-base, thorpej-atomic, reinoud-bufcleanup, newlock2-base, netbsd-4-base, netbsd-4-0-RC1, matt-mips64-base, matt-mips64, hpcarm-cleanup
Branch point for: wrstuden-fixsa, newlock2, netbsd-4
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

Backout size_t casts - lint has been fixed.

Revision 1.5 / (download) - annotate - [select for diffs], Wed Oct 18 14:49:21 2006 UTC (17 years, 5 months ago) by martin
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

Sprinkle a few size_t casts to avoid conversion warnings.

Revision 1.2.2.2 / (download) - annotate - [select for diffs], Sun Aug 27 01:20:56 2006 UTC (17 years, 7 months ago) by riz
Branch: abandoned-netbsd-4
Changes since 1.2.2.1: +1 -1 lines
Diff to previous 1.2.2.1 (colored) to branchpoint 1.2 (colored) next main 1.3 (colored)

Pull up following revision(s) (requested by thorpej in ticket #51):
	common/lib/libprop/prop_dictionary.c: revision 1.11
	common/lib/libprop/prop_number.c: revision 1.5
	common/lib/libprop/prop_bool.c: revision 1.5
	common/lib/libprop/prop_data.c: revision 1.4
	common/lib/libprop/prop_string.c: revision 1.4
	common/lib/libprop/prop_array.c: revision 1.6
Also guard object accessors against NULL (like we do foreign object
types)
so that apps can use this construct safely:
	obj = prop_dictionary_get(dict, "value");
	if (! prop_number_equals_integer(obj, 5)) {
		...
	}
Suggested by Iain Hibbert.

Revision 1.2.2.1 / (download) - annotate - [select for diffs], Wed Aug 23 21:21:14 2006 UTC (17 years, 7 months ago) by tron
Branch: abandoned-netbsd-4
Changes since 1.2: +31 -14 lines
Diff to previous 1.2 (colored)

Pull up following revision(s) (requested by thorpej in ticket #43):
	common/include/prop/prop_ingest.h: revision 1.1
	common/lib/libprop/prop_number.c: revision 1.4
	common/include/prop/prop_array.h: revision 1.3
	common/lib/libprop/prop_object_impl.h: revision 1.4
	common/include/prop/prop_dictionary.h: revision 1.4
	distrib/sets/lists/comp/mi: revision 1.911
	common/include/prop/Makefile: revision 1.2
	common/lib/libprop/prop_bool.c: revision 1.4
	distrib/sets/lists/base/shl.mi: revision 1.365
	common/lib/libprop/prop_data.c: revision 1.3
	lib/libprop/shlib_version: revision 1.4
	lib/libprop/Makefile: revision 1.6
	common/lib/libprop/prop_object.c: revision 1.4
	common/lib/libprop/prop_object.3: revision 1.4
	common/include/prop/proplib.h: revision 1.3
	common/lib/libprop/Makefile.inc: revision 1.3
	common/include/prop/prop_object.h: revision 1.4
	common/lib/libprop/prop_array.c: revision 1.4
	common/lib/libprop/prop_array.3: revision 1.4
	common/lib/libprop/prop_string.c: revision 1.3
	common/lib/libprop/prop_dictionary.3: revision 1.4
	common/lib/libprop/prop_ingest.c: revision 1.1
	common/lib/libprop/prop_ingest.3: revision 1.1
	common/lib/libprop/prop_dictionary.c: revision 1.9
Several changes to proplib:
- Arrays can now be externalized and internalized in the same way
  dictionaries can.
- Add new "externalize to file" and "internalize from file" functions
  to make reading a property list from a file and writing a property
  list to a file more convenient.
- Many assertions in the object implementations are gone.  Instead,
  calling an accessor for one object type with a different object type
  as an argument will return a suitable "invalid" value.
- prop_object_type() now returns a new PROP_TYPE_UNKNOWN value if called
  with a NULL object.
- Externalized property lists now contain a reference to the Apple XML
  plist DTD.
- Add a new prop_ingest(3) facility, which provides a convenient way to
  translate a dictionary into an arbitrary binary representation.

Revision 1.4 / (download) - annotate - [select for diffs], Tue Aug 22 21:21:23 2006 UTC (17 years, 7 months ago) by thorpej
Branch: MAIN
CVS Tags: yamt-splraiseipl-base, yamt-pdpolicy-base9, yamt-pdpolicy-base8
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

Also guard object accessors against NULL (like we do foreign object types)
so that apps can use this construct safely:

	obj = prop_dictionary_get(dict, "value");
	if (! prop_number_equals_integer(obj, 5)) {
		...
	}

Suggested by Iain Hibbert.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Aug 21 04:13:28 2006 UTC (17 years, 7 months ago) by thorpej
Branch: MAIN
Changes since 1.2: +31 -14 lines
Diff to previous 1.2 (colored)

Several changes to proplib:
- Arrays can now be externalized and internalized in the same way
  dictionaries can.
- Add new "externalize to file" and "internalize from file" functions
  to make reading a property list from a file and writing a property
  list to a file more convenient.
- Many assertions in the object implementations are gone.  Instead,
  calling an accessor for one object type with a different object type
  as an argument will return a suitable "invalid" value.
- prop_object_type() now returns a new PROP_TYPE_UNKNOWN value if called
  with a NULL object.
- Externalized property lists now contain a reference to the Apple XML
  plist DTD.
- Add a new prop_ingest(3) facility, which provides a convenient way to
  translate a dictionary into an arbitrary binary representation.

Revision 1.2 / (download) - annotate - [select for diffs], Thu May 18 03:05:19 2006 UTC (17 years, 11 months ago) by thorpej
Branch: MAIN
CVS Tags: yamt-pdpolicy-base7, yamt-pdpolicy-base6, yamt-pdpolicy-base5, abandoned-netbsd-4-base
Branch point for: abandoned-netbsd-4
Changes since 1.1: +34 -14 lines
Diff to previous 1.1 (colored)

- Add prop_array_equals(), prop_dictionary_equals(), and
  prop_dictionary_keysym_equals(), and prop_object_equals() functions.
- Use realloc() where it makes sense.  There will be more changes in this
  area.
- Add a _prop_object_type structure that is used internally to keep
  information about the object types.  Decreases the footprint of the
  objects slightly by replacing several pointers with just one.

Revision 1.1 / (download) - annotate - [select for diffs], Thu Apr 27 20:11:27 2006 UTC (17 years, 11 months ago) by thorpej
Branch: MAIN

Initial commit of proplib, a library for manipulating property lists and
converting to/from an XML external representation (based on Apple XML
property lists).  Works in the kernel and user space.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.




CVSweb <webmaster@jp.NetBSD.org>