Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

===================================================================
RCS file: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/shell.go,v
rcsdiff: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/shell.go,v: warning: Unknown phrases like `commitid ...;' are present.
retrieving revision 1.30
retrieving revision 1.31
diff -u -p -r1.30 -r1.31
--- pkgsrc/pkgtools/pkglint/files/Attic/shell.go	2018/12/17 00:15:39	1.30
+++ pkgsrc/pkgtools/pkglint/files/Attic/shell.go	2018/12/21 08:05:24	1.31
@@ -10,6 +10,11 @@ import (
 
 // TODO: Can ShellLine and ShellProgramChecker be merged into one type?
 
+// ShellLine is either a line from a Makefile starting with a tab,
+// thereby containing shell commands to be executed.
+//
+// Or it is a variable assignment line from a Makefile with a left-hand
+// side variable that is of some shell-like type; see Vartype.IsShell.
 type ShellLine struct {
 	mkline MkLine
 }
@@ -293,7 +298,9 @@ func (shline *ShellLine) CheckShellComma
 	}
 	setE := lexer.SkipString("${RUN}")
 	if !setE {
-		lexer.NextString("${_PKG_SILENT}${_PKG_DEBUG}")
+		if lexer.NextString("${_PKG_SILENT}${_PKG_DEBUG}") != "" {
+			line.Warnf("Use of _PKG_SILENT and _PKG_DEBUG is deprecated. Use ${RUN} instead.")
+		}
 	}
 
 	shline.CheckShellCommand(lexer.Rest(), &setE, RunTime)