Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. =================================================================== RCS file: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/shell.go,v rcsdiff: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/shell.go,v: warning: Unknown phrases like `commitid ...;' are present. retrieving revision 1.20 retrieving revision 1.21 diff -u -p -r1.20 -r1.21 --- pkgsrc/pkgtools/pkglint/files/Attic/shell.go 2018/01/10 00:39:52 1.20 +++ pkgsrc/pkgtools/pkglint/files/Attic/shell.go 2018/02/19 12:40:38 1.21 @@ -24,7 +24,7 @@ func NewShellLine(mkline MkLine) *ShellL return &ShellLine{mkline} } -var shellcommandsContextType = &Vartype{lkNone, BtShellCommands, []AclEntry{{"*", aclpAllRuntime}}, false} +var shellcommandsContextType = &Vartype{lkNone, BtShellCommands, []ACLEntry{{"*", aclpAllRuntime}}, false} var shellwordVuc = &VarUseContext{shellcommandsContextType, vucTimeUnknown, vucQuotPlain, false} func (shline *ShellLine) CheckWord(token string, checkQuoting bool) { @@ -772,7 +772,7 @@ func (spc *ShellProgramChecker) checkWor spc.shline.CheckWord(word.MkText, checkQuoting) } -func (scc *ShellProgramChecker) checkPipeExitcode(line Line, pipeline *MkShPipeline) { +func (spc *ShellProgramChecker) checkPipeExitcode(line Line, pipeline *MkShPipeline) { if trace.Tracing { defer trace.Call()() } @@ -827,7 +827,7 @@ func (scc *ShellProgramChecker) checkPip } } -func (scc *ShellProgramChecker) checkSetE(list *MkShList, eflag *bool) { +func (spc *ShellProgramChecker) checkSetE(list *MkShList, eflag *bool) { if trace.Tracing { defer trace.Call()() } @@ -835,7 +835,7 @@ func (scc *ShellProgramChecker) checkSet // Disabled until the shell parser can recognize "command || exit 1" reliably. if false && G.opts.WarnExtra && !*eflag && "the current token" == ";" { *eflag = true - scc.shline.mkline.Warnf("Please switch to \"set -e\" mode before using a semicolon (the one after %q) to separate commands.", "previous token") + spc.shline.mkline.Warnf("Please switch to \"set -e\" mode before using a semicolon (the one after %q) to separate commands.", "previous token") Explain( "Normally, when a shell command fails (returns non-zero), the", "remaining commands are still executed. For example, the following",