![[BACK]](/icons/back.gif){kind=icon}
Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint / files
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.14, Sat Apr 22 14:32:48 2023 UTC (11 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.13: +0 -0
lines
FILE REMOVED
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revision 1.13 / (download) - annotate - [select for diffs], Mon Jun 1 20:49:54 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2023Q1-base,
pkgsrc-2023Q1,
pkgsrc-2022Q4-base,
pkgsrc-2022Q4,
pkgsrc-2022Q3-base,
pkgsrc-2022Q3,
pkgsrc-2022Q2-base,
pkgsrc-2022Q2,
pkgsrc-2022Q1-base,
pkgsrc-2022Q1,
pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3,
pkgsrc-2021Q2-base,
pkgsrc-2021Q2,
pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3,
pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Changes since 1.12: +4 -4
lines
Diff to previous 1.12 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 20.1.12 Changes since 20.1.11: The file bsd.pkg.mk must only ever be included by package Makefiles directly, not by other Makefile fragments. Seen in www/w3m. The variable BUILDLINK_PREFIX.* should only be used for packages that have actually been included by the package. This catches the use of BUILDLINK_PREFIX.libiconv, which should have been iconv instead. Allow comments before line 3 in buildlink3.mk files. This is necessary for mariadb55-client since its buildlink identifier is mysql-client, which is so non-obvious that it needs to be documented.
Revision 1.12 / (download) - annotate - [select for diffs], Sun May 24 19:12:29 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.11: +2 -0
lines
Diff to previous 1.11 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 20.1.10 Changes since 20.1.8: Recognize SUBST_NOOP_OK and SUBST_SHOW_DIFF. Allow plain -Wl,-R and -Wl,-rpath in BUILDLINK_TRANSFORM, when they are used to remove compiler options. Recognize ggrep and other platform tools as valid tool names. Seen in lang/rust.
Revision 1.11 / (download) - annotate - [select for diffs], Sun Mar 22 17:43:15 2020 UTC (4 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1
Changes since 1.10: +3 -3
lines
Diff to previous 1.10 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.4.13 Changes since 19.4.12: Files that are mentioned redundantly in PLIST files generate an error. Missing DESCR files generate an error. Hard-coded /usr/pkg in patches generates an error.
Revision 1.10 / (download) - annotate - [select for diffs], Sat Feb 15 13:48:40 2020 UTC (4 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.9: +8 -55
lines
Diff to previous 1.9 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.4.8 Changes since 19.4.7: The diagnostic for homepages using FTP is simpler now. When running pkglint recursively on the top-level directory, the inter-package checks (distfile hashes, unused licenses) are enabled implicitly. This way, the only effect of the -Cglobal option is now whether the pkgsrc infrastructure files are checked as well. The check for removed packages that have not been recorded in doc/CHANGES prints the correct lines when pkglint is run with the --source option. Fatal technical errors are no longer treated as diagnostics since they are none. That was an early conceptual mistake, but since these fatal error didn't happen often, it didn't matter. In diagnostics, when referring to other lines, the previously used words before/after have been replaced with above/below to avoid any confusion whether space or time is meant. In CONF_FILES, spaces and quotes are allowed. See https://gnats.netbsd.org/42191. Fixed unintended side-effects when running pkglint --autofix --only. Before, all fixes were applied to the file, whether or not they matched the --only option. Fixed resolution of relative paths of the form ../../category/package when they appeared in an infrastructure file. Lots of refactorings and housekeeping, as usual.
Revision 1.9 / (download) - annotate - [select for diffs], Sat Jan 18 21:56:09 2020 UTC (4 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.8: +59 -0
lines
Diff to previous 1.8 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.4.4 Changes since 19.4.3: Packages that still use http in their HOMEPAGE URL generate warnings that the URL should use https instead.
Revision 1.8 / (download) - annotate - [select for diffs], Sat Jan 4 19:53:14 2020 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.7: +2 -1
lines
Diff to previous 1.7 (colored)
pkgtools/pkglint: update to 19.4.1 Changes since 19.4.0: The notes for inserting an empty line have been changed from "insert after this line" to "insert before this line" to make the line numbers in the diagnostics contiguous. There had been several places where the diagnostics went from line 1 to line 2 and then back to line 1, which was confusing. The lines in ALTERNATIVES files are checked for trailing whitespace. This is only for consistency with the other checks. In the whole pkgsrc tree all ALTERNATIVES files are already fine. The diagnostics for comments in .endif/.endfor lines that don't correspond to their .if/.elif/.for counterparts now includes the exact line number of the corresponding condition, to make the warning easier to fix. The diagnostics for wrong variable value alignment now mention the current column in addition to the desired column, to make it easier to see by how much and in which direction the indentation should be fixed. Variables that are used in conditions before they are actually defined need the :U modifier.
Revision 1.7 / (download) - annotate - [selected], Mon Dec 9 20:38:16 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q4-base,
pkgsrc-2019Q4
Changes since 1.6: +4 -2
lines
Diff to previous 1.6 (colored)
pkgtools/pkglint: update to 19.3.16 Changes since 19.3.15: When a package-settable variable gets a default value using the ?= operator, pkglint no longer suggests to include bsd.prefs.mk, since that doesn't make sense. Including bsd.prefs.mk only defines user-settable and system-provided variables. User and group names may be a single character only. While not widely used, it's syntactically valid and there's no reason to prevent this. In variable assignments, when pkglint removes unnecessary whitespace between the variable name and the operator, it keeps the indentation of the variable value the same as before. Previously, the indentation had been changed, which required another run of pkglint --autofix. PREFIX can only be used as a replacement for LOCALBASE after the whole package Makefile has been loaded. This is because PREFIX is defined very late, by bsd.pkg.mk. Therefore, don't suggest to replace LOCALBASE with PREFIX in .if conditions. When pkglint suggests to replace INSTALL_DATA_DIR commands with setting INSTALLATION_DIRS instead, paths with a trailing slash are correctly looked up in the PLIST. This suggests to use AUTO_MKDIRS more often.
Revision 1.6 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.5: +3 -0
lines
Diff to previous 1.5 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
Revision 1.5 / (download) - annotate - [select for diffs], Sun Dec 8 00:06:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.4: +343 -169
lines
Diff to previous 1.4 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.3.14
Changes since 19.3.13:
When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME}
== fixed, the exact suggested expression is now part of the diagnostic.
The check and the autofix have been improved. They now apply only to the
last modifier in the whole chain, everything else was a bug in pkglint.
Pkglint now knows the scope of variables better than before. It knows
the difference between variables from <sys.mk> like MACHINE_ARCH, which
are always in scope, and those from mk/defaults/mk.conf, which only come
into scope later, after bsd.prefs.mk has been included. It warns when
variables are used too early, for example in .if conditions.
The pathnames in ALTERNATIVES files are now checked for absolute
pathnames. This mistake doesn't happen in practice, but the code for
converting the different path types internally made it necessary to add
these checks. At least this prevents typos.
The special check for obsolete licenses has been removed since their
license files have been removed and that is checked as well.
Variables named *_AWK may be appended to.
The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they
are obsolete now. They are not used in main pkgsrc and pkgsrc-wip
anymore.
When a package sets a default value for a user-settable variable (which
is something that should not happen anyway), it should .include
bsd.prefs.mk before, in order to not accidentally overwrite the
user-specified value.
Variable modifiers of the form :from=to are now parsed like in bmake.
They are greedy and eat up any following colons as well. This means that
${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it.
Pkglint now warns about such cases.
The handling of relative paths in diagnostics is now consistent. All
paths that are part of a diagnostic are relative to the line that issues
the diagnostic.
Fatal errors are no longer suppressed in --autofix mode.
Plus lots of refactoring, to prevent accidental mixing of incompatible
relative paths.
Revision 1.4 / (download) - annotate - [select for diffs], Mon Dec 2 23:32:09 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.3: +754 -55
lines
Diff to previous 1.3 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.3.13 Changes since 19.3.12: The command line option -Wspace has been removed. Warnings and notes about whitespace are now generated by default and cannot be switched off. This is to ensure a consistent visual appearance of the package Makefiles. Shell programs that are indented unnecessarily deep generate a note by default now. Before, the option -Wall was necessary to get these notes. The check for unintended comments in multi-line shell programs is now enabled again. It had been disabled some time ago as byproduct of a bug fix in the shell parser. The check for unique buildlink3 package identifiers now also works if pkglint is run from a package directory instead of the pkgsrc root directory.
Revision 1.3 / (download) - annotate - [select for diffs], Sat Nov 30 20:35:11 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.2: +30 -1
lines
Diff to previous 1.2 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.3.12 Changes since 19.3.11: The command line option -Wstyle has been removed since it didn't have any effect. License names may contain underscores. This fixes 3 parse errors and 2 wrong notes about seemingly unused licenses. The parser for Makefile variables has been improved for some edge cases. The :M and :N modifiers behave surprisingly when they contain unbalanced parentheses or braces. Pkglint now parses them in the same way as bmake, but doesn't warn since these cases are not actually used in pkgsrc.
Revision 1.2 / (download) - annotate - [select for diffs], Wed Nov 27 22:10:07 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.1: +83 -9
lines
Diff to previous 1.1 (colored) to selected 1.7 (colored)
pkgtools/pkglint: update to 19.3.11 Changes since 19.3.10: The check for buildlink3.mk files that are included conditionally in one place and unconditionally in another place have been refined. Now they also work in cases that do not involve any variables, such as when the condition is a mere exists(filename). References to variables that use parentheses instead of the usual braces produce a warning now, even if pkglint cannot fix them automatically. This affects only a few instances where more than one such variable reference appeared in a single line. The --log-verbose command line option has been removed since it does not have any practical use other than improving the performance during pkglint development itself. Because of that it hadn't even been mentioned in the manual page. Warnings for missing license files now report the path to the license file relative to the line where the warning occurs, like everywhere else.
Revision 1.1 / (download) - annotate - [select for diffs], Sat Nov 23 23:36:20 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Diff to selected 1.7 (colored)
pkgtools/pkglint: update to 19.3.10 Changes since 19.3.9: In diagnostics for suggested package updates, the exact line of doc/TODO is mentioned. If a suggested update has an additional comment, the brackets around that comment are not output anymore. The check for defined but not used variables has been improved for the edge case of defining a variable in the package Makefile and using it in the buildlink3.mk file of the same package, which just doesn't work. Makefile fragments in patches/ directories are now completely ignored. It was a hypothetical case anyway. Comparing PKGSRC_COMPILER using the == or != operators is now considered an error instead of a warning. The common cases can be autofixed.