Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint / files
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.44, Sat Apr 22 14:32:48 2023 UTC (11 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.43: +0 -0
lines
FILE REMOVED
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revision 1.43 / (download) - annotate - [select for diffs], Sun Aug 2 13:27:17 2020 UTC (3 years, 8 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2023Q1-base,
pkgsrc-2023Q1,
pkgsrc-2022Q4-base,
pkgsrc-2022Q4,
pkgsrc-2022Q3-base,
pkgsrc-2022Q3,
pkgsrc-2022Q2-base,
pkgsrc-2022Q2,
pkgsrc-2022Q1-base,
pkgsrc-2022Q1,
pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3,
pkgsrc-2021Q2-base,
pkgsrc-2021Q2,
pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3
Changes since 1.42: +25 -3
lines
Diff to previous 1.42 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.2.6 Changes since 20.2.5: Some selected absolute paths, such as /etc/passwd, /etc/shadow and /etc/hosts are allowed in patch files. Other files in /etc should still use PKG_SYSCONFDIR, to keep the package portable between platforms and also in unprivileged mode. (Fixes PR pkg/55524.) Absolute pathnames are also allowed in C-style end-of-line comments (fixes PR pkg/55516) and in continuations of C-style block comments (fixes PR pkg/55524). The explanation for make's :ts modifier has been adjusted to the 2020 bmake update. The modifier :ts\040 is now interpreted as octal, as opposed to decimal.
Revision 1.42 / (download) - annotate - [select for diffs], Thu Jul 23 18:40:41 2020 UTC (3 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.41: +60 -0
lines
Diff to previous 1.41 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.2.3 Changes since 20.2.2: Complain about patches that add a hard-coded interpreter. Even if that interpreter is /bin/sh, which is available on most platforms, it is still inappropriate on old Solaris installations. Other popular paths start with /usr/pkg or /usr/local, and these are not controlled by pkgsrc either.
Revision 1.41 / (download) - annotate - [select for diffs], Sun Jun 7 15:49:23 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Changes since 1.40: +21 -0
lines
Diff to previous 1.40 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.1.15 Changes since 20.1.14: Fix confusing wording of diagnostic "should contain text". It's more precise to say "this line should consist of this text". Otherwise it's too easy to interpret it as "the text should occur somewhere in the line". Allow BUILDLINK_PREFIX.* to be used in helper files. Especially for programming language packages, files like plugin.mk often include buildlink3.mk and therefore may refer to the BUILDLINK_PREFIX of this package. Warn about redundant BUILDLINK_API_VERSION restrictions. Previously, the check had only been enabled if the operators from the default dependency pattern (buildlink3.mk) and the additional dependency pattern (package) used the same operators, which already covered most practical cases. Determine SuSE versions from the pkgsrc tree.
Revision 1.40 / (download) - annotate - [select for diffs], Fri May 29 20:13:17 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.39: +25 -1
lines
Diff to previous 1.39 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.1.11 Changes since 20.1.10: PKG_SYSCONFDIR and VARBASE must not appear in INSTALLATION_DIRS. Patch files in which the line number have been edited manually are marked with notes.
Revision 1.39 / (download) - annotate - [select for diffs], Fri May 8 19:50:04 2020 UTC (3 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.38: +99 -15
lines
Diff to previous 1.38 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.1.4 Changes since 20.1.3: For patches that patch a single file, the filename of the patch should correspond to the patched file. There are a few different naming schemes in action, therefore the check is relatively loose. Patches that are called patch-[a-z][a-z] continue to be allowed for historic reasons. Patches that are called patch-CVE-* are also allowed. The entries in doc/CHANGES-* are checked for consistency. For example, it doesn't make sense to add a package twice or "update" a package from version 1.0 to version 1.0. All version numbers in these entries must be valid pkgsrc versions, i.e. start with a digit and only use characters from -.0-9A-Z_a-z.
Revision 1.38 / (download) - annotate - [select for diffs], Thu Apr 30 21:15:03 2020 UTC (3 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.37: +162 -0
lines
Diff to previous 1.37 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 20.1.3 Changes since 20.1.2: Stricter check for Python version numbers. Before, 25 and 26 had not been marked as wrong. In assignments like PKGNAME=${DISTNAME:S,from,to,}, modifiers that don't have any effect generate a note. Most of these modifiers are redundant or outdated. Patches must not add well-known absolute paths like /usr/pkg, /var and /etc since these must be overridable by the pkgsrc user. Other absolute paths continue to be allowed.
Revision 1.37 / (download) - annotate - [select for diffs], Sun Mar 22 17:43:15 2020 UTC (4 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1
Changes since 1.36: +20 -0
lines
Diff to previous 1.36 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 19.4.13 Changes since 19.4.12: Files that are mentioned redundantly in PLIST files generate an error. Missing DESCR files generate an error. Hard-coded /usr/pkg in patches generates an error.
Revision 1.36 / (download) - annotate - [select for diffs], Sat Feb 15 13:48:40 2020 UTC (4 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.35: +4 -4
lines
Diff to previous 1.35 (colored)
pkgtools/pkglint: update to 19.4.8 Changes since 19.4.7: The diagnostic for homepages using FTP is simpler now. When running pkglint recursively on the top-level directory, the inter-package checks (distfile hashes, unused licenses) are enabled implicitly. This way, the only effect of the -Cglobal option is now whether the pkgsrc infrastructure files are checked as well. The check for removed packages that have not been recorded in doc/CHANGES prints the correct lines when pkglint is run with the --source option. Fatal technical errors are no longer treated as diagnostics since they are none. That was an early conceptual mistake, but since these fatal error didn't happen often, it didn't matter. In diagnostics, when referring to other lines, the previously used words before/after have been replaced with above/below to avoid any confusion whether space or time is meant. In CONF_FILES, spaces and quotes are allowed. See https://gnats.netbsd.org/42191. Fixed unintended side-effects when running pkglint --autofix --only. Before, all fixes were applied to the file, whether or not they matched the --only option. Fixed resolution of relative paths of the form ../../category/package when they appeared in an infrastructure file. Lots of refactorings and housekeeping, as usual.
Revision 1.35 / (download) - annotate - [selected], Sat Jan 4 19:53:14 2020 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.34: +38 -38
lines
Diff to previous 1.34 (colored)
pkgtools/pkglint: update to 19.4.1 Changes since 19.4.0: The notes for inserting an empty line have been changed from "insert after this line" to "insert before this line" to make the line numbers in the diagnostics contiguous. There had been several places where the diagnostics went from line 1 to line 2 and then back to line 1, which was confusing. The lines in ALTERNATIVES files are checked for trailing whitespace. This is only for consistency with the other checks. In the whole pkgsrc tree all ALTERNATIVES files are already fine. The diagnostics for comments in .endif/.endfor lines that don't correspond to their .if/.elif/.for counterparts now includes the exact line number of the corresponding condition, to make the warning easier to fix. The diagnostics for wrong variable value alignment now mention the current column in addition to the desired column, to make it easier to see by how much and in which direction the indentation should be fixed. Variables that are used in conditions before they are actually defined need the :U modifier.
Revision 1.34 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q4-base,
pkgsrc-2019Q4
Changes since 1.33: +1 -1
lines
Diff to previous 1.33 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
Revision 1.33 / (download) - annotate - [select for diffs], Sun Dec 8 00:06:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.32: +104 -0
lines
Diff to previous 1.32 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 19.3.14 Changes since 19.3.13: When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME} == fixed, the exact suggested expression is now part of the diagnostic. The check and the autofix have been improved. They now apply only to the last modifier in the whole chain, everything else was a bug in pkglint. Pkglint now knows the scope of variables better than before. It knows the difference between variables from <sys.mk> like MACHINE_ARCH, which are always in scope, and those from mk/defaults/mk.conf, which only come into scope later, after bsd.prefs.mk has been included. It warns when variables are used too early, for example in .if conditions. The pathnames in ALTERNATIVES files are now checked for absolute pathnames. This mistake doesn't happen in practice, but the code for converting the different path types internally made it necessary to add these checks. At least this prevents typos. The special check for obsolete licenses has been removed since their license files have been removed and that is checked as well. Variables named *_AWK may be appended to. The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they are obsolete now. They are not used in main pkgsrc and pkgsrc-wip anymore. When a package sets a default value for a user-settable variable (which is something that should not happen anyway), it should .include bsd.prefs.mk before, in order to not accidentally overwrite the user-specified value. Variable modifiers of the form :from=to are now parsed like in bmake. They are greedy and eat up any following colons as well. This means that ${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it. Pkglint now warns about such cases. The handling of relative paths in diagnostics is now consistent. All paths that are part of a diagnostic are relative to the line that issues the diagnostic. Fatal errors are no longer suppressed in --autofix mode. Plus lots of refactoring, to prevent accidental mixing of incompatible relative paths.
Revision 1.32 / (download) - annotate - [select for diffs], Sun Nov 17 01:26:25 2019 UTC (4 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.31: +26 -26
lines
Diff to previous 1.31 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 19.3.7 Changes since 19.3.6: Improved variable value alignment. Fixed wrong warning about comment lines that were interpreted as shell commands before. Warn when the first category of a package doesn't correspond to the path in the filesystem. This affects 603 packages. No longer warn about deprecated BUILDLINK_TRANSFORM.${OPSYS}. The deprecation warning was meant for BUILDLINK_TRANSFORM.${pkgbase}, but since pkglint cannot distinguish between these, the warnings were wrong.
Revision 1.31 / (download) - annotate - [select for diffs], Sat Nov 2 16:37:48 2019 UTC (4 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.30: +25 -0
lines
Diff to previous 1.30 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 19.3.5 Changes since 19.3.4: Variable uses in parentheses (such as $(VAR) instead of ${VAR}) are treated the same. The ones in parentheses had less support before. Improved the checks for options.mk files, adding support for options that are defined using .for loops and those referring to other variables. Packages that set DISTFILES to an empty list no longer require a distinfo file. Patches whose filename contains the word CVE may patch more than one target file.
Revision 1.30 / (download) - annotate - [select for diffs], Sun Jun 30 20:56:19 2019 UTC (4 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q3-base,
pkgsrc-2019Q3
Changes since 1.29: +98 -71
lines
Diff to previous 1.29 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.7.14 Changes since 5.7.13: - Removed the -Cextra command line option since it didn't produce useful warnings. - Removed unwarranted warnings about _WRAP_EXTRA_ARGS.CC being used in packages. - Cleaned up the canonical order of variables in package Makefiles. - Added a few commands to those that cannot fail, to reduce the number of "at the left of the | operator" in shell programs. - Fixed warnings about "-ggdb" being an unknown shell command. - Reduced number of warnings about lists being used where a single value is expected. - Replaced unreliable check for invalid CFLAGS and LDFLAGS with a more practical check. - Renamed "RCS tag" to "CVS tag" to make the diagnostics more modern. - Added warning when PKGNAME or PKGVERSION is used in MASTER_SITES. - Reworded warning for missing or superfluous PLIST files. - Lots of other detail changes, refactorings and automatic tests.
Revision 1.29 / (download) - annotate - [select for diffs], Mon Jun 10 19:51:57 2019 UTC (4 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q2-base,
pkgsrc-2019Q2
Changes since 1.28: +23 -0
lines
Diff to previous 1.28 (colored) to selected 1.35 (colored)
pkgtools/pkglint: updated to 5.7.13 Changes since 5.7.12: * Fixed a warning in the variable permissions that previously said "this variable should not be used at load time in this file, it would be ok in .", with an empty list of alternative files. * Lots of refactoring and new tests.
Revision 1.28 / (download) - annotate - [select for diffs], Sat Jan 26 16:31:33 2019 UTC (5 years, 2 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q1-base,
pkgsrc-2019Q1
Changes since 1.27: +0 -87
lines
Diff to previous 1.27 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.12 Changes since 5.6.11: * In buildlink3.mk files, print the paths relative to the line, not to the pkgsrc root. * When explaining that a variable cannot be set/used because of wrong permissions, list the permissions. This provides more transparency than just stating that the desired action is not allowed. * When pkglint checks a pkgsrc-wip package, don't warn about malformed lines in doc/CHANGES-* since pkgsrc-wip users typically cannot do anything about these errors. * In profiling mode, not only the code coverage and the performance statistics are dumped, the whole heap is also dumped to see which parts of pkglint consume the most heap memory. Pkglint now needs less heap memory than before, which mainly affects full scans. * The checks for absolute pathnames have gone. They were of questionable value since pkglint has failed to give proper advice on how to fix them properly, at least for the last 12 years. * The check that pkgsrc-wip packages should only use exact CVS Ids (the unexpanded variant) has been disabled again. It occurred about 16000 times but even fixing it wouldn't improve anything since it was mostly a formatting issue without any practical consequences. * Warn about trailing variable modifiers like in ${VAR:S,from,to,extra}. * Properly parse ${VAR:!command!}. * Suggest to replace SUBST_SED with SUBST_VARS where possible, even with complicated shell quoting. Pkglint can autofix most of these overly verbose cases. * Load builtin.mk whenever the corresponding buildlink3.mk file is included. This fixes several warnings about undefined variables (especially for packages using OpenSSL). * Parse .for lines like bmake does since 2015, splitting words like in brk_string. * Optionally show a warning even if it cannot be autofixed by pkglint. This is useful for the SUBST_VARS replacement since even when pkglint cannot automatically replace the code, there are still cases where it can warn at least. * As always, several refactorings.
Revision 1.27 / (download) - annotate - [select for diffs], Sun Jan 13 19:55:53 2019 UTC (5 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.26: +15 -15
lines
Diff to previous 1.26 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.11 Changes since 5.6.10: * Improved the wording of several warnings * Fixed parsing of complicated dependency patterns such as {ssh{,6}-[0-9]*,openssh-[0-9]*}. Pkglint still doesn't understand them but at least it doesn't mark them as "unknown" anymore. * Lots of refactoring, as usual. This is the last part of the big refactoring, therefore future changes to pkglint are expected to be smaller than in the previous 3 months.
Revision 1.26 / (download) - annotate - [select for diffs], Fri Dec 21 08:05:24 2018 UTC (5 years, 3 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q4-base,
pkgsrc-2018Q4
Changes since 1.25: +55 -55
lines
Diff to previous 1.25 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.10 Changes since 5.6.9: * ALTERNATIVES files are correctly checked now. Before, pkglint had suggested to remove the @PREFIX/ from the alternative, which was wrong and simply didn't work. * Diagnostics about variable assignments are ordered to report the left-hand side first and then everything to the right of the assignment operator. * The pkglint output is escaped properly to avoid sending unwanted escape sequences to the terminal. * The items in .for loops are parsed taking "double" and 'single' quotes into account since bmake does it in the same way since 2015. * In DESCR files, overly long lines are only warned about if they contain a space and therefore can be made shorter. * In DESCR files, text like ${PREFIX} only gets a note if it refers to a commonly known pkgsrc variable. This avoids distraction when a package mentions ${prefix}/bin or ${template.property}. * Lots of refactorings and small changes.
Revision 1.25 / (download) - annotate - [select for diffs], Mon Dec 17 00:15:39 2018 UTC (5 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.24: +18 -12
lines
Diff to previous 1.24 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.9 Changes since 5.6.8: * In addition to the pkglint binary, the whole pkglint code is installed as a library, so that other packages can use the code for doing their own checks on pkgsrc packages, Makefiles, shell programs, or the other file types from pkgsrc. * BUILDLINK_*.* may be used in all files. * Lots of refactorings
Revision 1.24 / (download) - annotate - [select for diffs], Sun Dec 2 01:57:48 2018 UTC (5 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.23: +5 -5
lines
Diff to previous 1.23 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.7 Changes since 5.6.6: User-defined variables that are not yet added to BUILD_DEFS are only reported once per file. Unnecessary space after variable names is only worth a note instead of a warning. Example: MASTER_SITES = https://cdn.example.org/ All variable names that are defined in the pkgsrc infrastructure are assumed to be available to the package Makefiles. This reduces the number of wrong "used but not defined" warnings, at the expense of Variable names that are used in other variable names are checked whether they are defined somewhere. Example: CFLAGS+= ${CFLAGS.${PARAM}} # PARAM is now checked In SUBST_SED, when the pattern is s,@VAR@,${VAR}, or a slight variant thereof, pkglint suggests to define SUBST_VARS instead, which frees the package author from thinking about how to escape special characters and is generally easier to read. Example: SUBST_SED.class= s,@VAR@,${VAR:Q}, SUBST_VARS.class= VAR Directives like .if !defined(...) are now handled the same whether or not there is a space after before the (...). The check for locally modified files now works independently of the timezone. As always, lots of refactorings have happened under the hood. Many small bugs have been discovered and fixed accordingly.
Revision 1.23 / (download) - annotate - [select for diffs], Wed Nov 7 20:58:23 2018 UTC (5 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.22: +9 -24
lines
Diff to previous 1.22 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.6 Changes since 5.6.5: - Removed plist-clash since it had crashed unconditionally whenever it was called. This means that in the last 3 years, nobody can have used it in the originally intended way. - Fixed interactions between the --source, --explain, --show-autofix, --autofix and --only options. - Fixed "defined but not used" and "used but not defined" for variables from the pkgsrc infrastructure. - Lots of small fixes and improvements found by the large pkglint code review (12% done).
Revision 1.22 / (download) - annotate - [select for diffs], Tue Oct 9 19:12:13 2018 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.21: +4 -4
lines
Diff to previous 1.21 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.4 Changes since 5.6.3: * Allow += for COMMENT * Sync variable type definitions with reality * Fix check for "used but not defined" variables. This check had been broken since pkgtools/pkglint/files/pkglint.pl r1.776 from 2008-10-18 (3cd071958e63), which missed its 10-year anniversary by just 9 days. After fixing this check, pkglint produces about 800 new warnings spread all over pkgsrc, most of which are real typos. * Detect used variables also in .if and .elif conditions. This is closely related to the above fix and reduces the number of "defined but not used" variables, while at the same time producing new warnings because these variables are used at load time, where some of these variables are not yet defined. * Detect variables for which pkglint doesn't know the exact data type by scanning all files under mk/ at startup. Currently there are about 470 of these variables. No "used but not defined" warnings are issued for these variables anymore. * To speed up pkglint when checking the whole pkgsrc tree at once, the most often needed files are cached to reduce IO load. The checks for USE_TOOLS are optimized now since they were a major bottleneck. Together with other performance improvements this makes pkglint about 50% faster when checking the whole pkgsrc tree including pkgsrc-wip.
Revision 1.21 / (download) - annotate - [select for diffs], Wed Oct 3 22:27:53 2018 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.20: +1 -1
lines
Diff to previous 1.20 (colored) to selected 1.35 (colored)
pkgtools/pkglint: Update to 5.6.3 Changes since 5.6.2: * Add check for version patterns 1.5*, which should rather be 1.5.* * Re-enable check for "set -e" and commands that may silently fail because of missing error checking * Lots of internal clean-up and tests
Revision 1.20 / (download) - annotate - [select for diffs], Wed Sep 5 17:56:22 2018 UTC (5 years, 7 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q3-base,
pkgsrc-2018Q3
Changes since 1.19: +178 -4
lines
Diff to previous 1.19 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.2 Changes since 5.6.1: * Improved checks that depend on whether bsd.prefs.mk is included or not. * Improved checks for tools, whether they may be used at load time or at run time. * Improved tokenizer for shell commands. $| is not a variable but a dollar followed by a pipe. * Warnings about SUBST context are now shown by default. * A warning is shown when a SUBST block is declared for *-configure but the package has defined USE_CONFIGURE=no. * Don't warn about USE_TOOLS:= ${USE_TOOLS:Ntool}. * Don't warn about using the ?= operator in buildlink3.mk files before including bsd.prefs.mk (for some more variables, but not all). * Report an error for packages from main pkgsrc that have a TODO or README file. Packages should be simple enough that they don't need a README file and ready for production so that they don't need a TODO. * Lots of small bug fixes and new tests.
Revision 1.19 / (download) - annotate - [select for diffs], Thu Aug 16 20:41:42 2018 UTC (5 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.18: +5 -4
lines
Diff to previous 1.18 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.1 Changes since 5.6.0: * Fix output of relative paths in the diagnostics (thanks @wiz) * Fix parsing of ${VAR:ts---}; it is now a syntax error * Load more type definitions from mk/* instead of hard-coding them * Lots of refactoring to improve test coverage, fixing several small bugs as they were found
Revision 1.18 / (download) - annotate - [select for diffs], Sun Aug 12 16:31:56 2018 UTC (5 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.17: +46 -1
lines
Diff to previous 1.17 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.6.0 Changes since 5.5.16: * Check for negated shell commands (if ! test -z "foo"); they are not supported by Solaris. * Don't check variable permissions for infrastructure files. A warning like "may not be set by any package" doesn't make sense for them. * Check that PLIST_VARS matches PLIST.*, which is especially useful in options.mk files. * Improve checks for options.mk files (for PKG_OPTIONS_SET). * Prefer options handling with !empty() over checking empty() first. * Prefer ${MACHINE_ARCH} == i386 over !empty(MACHINE_ARCH:Mi386), for single-valued variables.
Revision 1.17 / (download) - annotate - [select for diffs], Sat Jul 28 18:31:23 2018 UTC (5 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.16: +54 -10
lines
Diff to previous 1.16 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.5.15 Changes since 5.5.14: * Check that the comments in .endif and .endfor lines match the corresponding conditions. * Check for redundant variables (e.g. MASTER_SITES for R packages). * Check for accidentally overwritten variables. * Miscellaneous code cleanup and refactoring.
Revision 1.16 / (download) - annotate - [select for diffs], Mon Feb 19 12:40:38 2018 UTC (6 years, 1 month ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q2-base,
pkgsrc-2018Q2,
pkgsrc-2018Q1-base,
pkgsrc-2018Q1
Changes since 1.15: +22 -22
lines
Diff to previous 1.15 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.5.5 Changes since 5.5.3: - Removed check for PERL5_PACKLIST, since it was not fixable by the package author. - Completely rewrote the check for ordering variables in simple package Makefiles. Now it reports the variables in the correct order instead of just saying "this above that" for a few variables. - Lots of code cleanup and documentation.
Revision 1.15 / (download) - annotate - [select for diffs], Sun Jan 28 23:21:16 2018 UTC (6 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.14: +27 -0
lines
Diff to previous 1.14 (colored) to selected 1.35 (colored)
pkgtools/pkglint: update to 5.5.3 Changes since 5.5.2: * Fixed lots of bugs regarding autofixing variable assignments in continuation lines. * Fixed checking of MESSAGE files, which also get fixed now. * In variable assignments, commented assignments are aligned too. * Fixed a crash when checking an empty patch file. * The :Q modifier is only checked on predefined variables, to prevent the --autofix mode from removing :Q from user-defined variables. * Fixed lots of bugs in PLIST autofixing: relevant lines had been removed, and the sorting was not correct.
Revision 1.14 / (download) - annotate - [select for diffs], Sat Jan 27 18:50:36 2018 UTC (6 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.13: +119 -111
lines
Diff to previous 1.13 (colored) to selected 1.35 (colored)
pkgtools/pkglint: Update to 5.5.2 Changes since 5.5.1: * Fixed command line parsing for the --only option. * Improved alignment of variable values in Makefiles. * Code cleanup: better abstraction in the tests.
Revision 1.13 / (download) - annotate - [select for diffs], Sat Jan 13 23:56:14 2018 UTC (6 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.12: +17 -17
lines
Diff to previous 1.12 (colored) to selected 1.35 (colored)
pkglint: Update to 5.5.1 Changes since 5.5: * Allow filtering log messages by keyword (--only) * In --autofix and --show-autofix mode, show only fixable diagnostics * When called with --source, show the source below the diagnostics * Don't warn about USE_LANGUAGES in ../../mk/compiler.mk * Fix autofix for .gz in PLIST
Revision 1.12 / (download) - annotate - [select for diffs], Sun Jan 7 17:08:15 2018 UTC (6 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.11: +22 -6
lines
Diff to previous 1.11 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.26. Changes since 5.4.25: * When autofixing a patch, fix the corresponding distinfo file as well. * Properly parse ${VARNAME:[\#]}; the # was interpreted as a comment before. * Don't add unnecessary :Q to PKG_OPTIONS and related variables. * Don't warn about missing manual pages. While Debian and other distributions do this work, pkgsrc keeps the packages as original as possible. * Autofix redundant ".gz" for manual pages in PLISTs.
Revision 1.11 / (download) - annotate - [select for diffs], Mon Jan 1 18:04:15 2018 UTC (6 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.10: +1 -1
lines
Diff to previous 1.10 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.22. Changes since 5.4.21: * Refactoring: moved packages line and linechecks back into main * Fixed panic when autofixing package Makefiles * Removed apache22 * Added a bit of inline documentation
Revision 1.10 / (download) - annotate - [select for diffs], Sun Jan 29 14:27:48 2017 UTC (7 years, 2 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2017Q4-base,
pkgsrc-2017Q4,
pkgsrc-2017Q3-base,
pkgsrc-2017Q3,
pkgsrc-2017Q2-base,
pkgsrc-2017Q2,
pkgsrc-2017Q1-base,
pkgsrc-2017Q1
Changes since 1.9: +51 -32
lines
Diff to previous 1.9 (colored) to selected 1.35 (colored)
Refactored the code into separate packages. No functional changes.
Revision 1.9 / (download) - annotate - [select for diffs], Tue Jan 17 22:37:27 2017 UTC (7 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.8: +1 -1
lines
Diff to previous 1.8 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.16. Changes since 5.4.15: * updated vardefs from mk/defaults/mk.conf from v1.118 (2006) to v1.269 Gone: * PKG_SUFX * USETBL * PKGSRC_SHOW_PATCH_ERRORMSG * USE_XPKGWEDGE * PKGVULNDIR Adjusted: * USE_GAMESGROUP * BIN_INSTALL_FLAG -> BIN_INSTALL_FLAGS * fixed license parsing to be more realistic (the previous version didn't handle parentheses correctly) * lots of housekeeping * moved some code to separate packages, allowing re-use * separated Line checks into LineChecker type * separated MkLine checks into MkLineChecker type * made Line an interface, for further refactorings
Revision 1.8 / (download) - annotate - [select for diffs], Sun Jan 1 15:15:47 2017 UTC (7 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.7: +2 -2
lines
Diff to previous 1.7 (colored) to selected 1.35 (colored)
Cleaned up and refactored code. The getopt and pkgver code have been extracted to separate packages to make them reusable. Several other functions have been moved to make the structure easier to understand: * dir.go and main.go have been moved to pkglint.go * utility functions from pkglint.go have been moved to mkline.go Now pkglint.go contains only high-level code.
Revision 1.7 / (download) - annotate - [select for diffs], Tue Dec 13 00:58:07 2016 UTC (7 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q4-base,
pkgsrc-2016Q4
Changes since 1.6: +15 -8
lines
Diff to previous 1.6 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.13. Changes since 5.4.12: * Added check for unintended # comments, especially in HOMEPAGE * Added check for quotes in COMMENT * Fixed hardcoded package versions for PHP, Python, Lua, etc. * Code cleanup in the tests
Revision 1.6 / (download) - annotate - [select for diffs], Sat Jul 9 09:43:48 2016 UTC (7 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q3-base,
pkgsrc-2016Q3
Changes since 1.5: +37 -17
lines
Diff to previous 1.5 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.4. Changes since 5.4.3: * Improved detection for undocumented patches from Git * Added warning about unnecessary space after variable names * Lots of internal housekeeping
Revision 1.5 / (download) - annotate - [select for diffs], Sun Jun 5 11:24:32 2016 UTC (7 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q2-base,
pkgsrc-2016Q2
Changes since 1.4: +7 -3
lines
Diff to previous 1.4 (colored) to selected 1.35 (colored)
Updated pkglint to 5.4.0. Changes since 5.3.7: * Replaced the -D... debug options with a single -d * Omitted duplicate diagnostics * Marked the :Q operator unnecessary for some variables * Improved detection of whether bsd.prefs.mk has been included, which fixed unwarranted warnings about load time evaluation of some variables like ${ECHO} and ${SED} * Improved detection for $(VAR) with round parentheses * Fixed allowed locations for several variables * Improved detection for used variables (still not perfect) * Added warning that MASTER_SITES should not be used in HOMEPAGE * Fixed warning about manual patches not being in distinfo * Added a check for missing MASTER_SITE_* variables * Added a check for unfinished url2pkg work * Fixed several wrong warnings
Revision 1.4 / (download) - annotate - [select for diffs], Wed Jan 27 21:55:51 2016 UTC (8 years, 2 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q1-base,
pkgsrc-2016Q1
Changes since 1.3: +1 -1
lines
Diff to previous 1.3 (colored) to selected 1.35 (colored)
Updated pkglint to 5.3.4 Changes since 5.3.3: * Added some unit tests * Fixed the Makefile parser to recognize seldomly-used variable modifiers like :S///S/// without intermediate colon or :ts\n * Cleaned up some unit tests * Combined diagnostics that span multiple lines into single-line ones
Revision 1.3 / (download) - annotate - [select for diffs], Tue Jan 12 01:02:49 2016 UTC (8 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.2: +233 -16
lines
Diff to previous 1.2 (colored) to selected 1.35 (colored)
Updated pkglint to 5.3 Changes since 5.2.2.2: * Makefile variables The warnings about missing permissions sound more natural than before and give a hint for alternative operators (e.g. set-default instead of append), or an alternative file where setting this variable is allowed instead (e.g. PKGREVISION may not be set in Makefile.common, but in Makefile it is ok). Warnings about "unknown" allowed permissions are not shown anymore, since they didn't provide any benefit. To see them again, pkglint must be run with the -Dunchecked option. User-defined variables may be used by builtin.mk. They may also be used during load time, not only during run time, under the assumption that in most cases the bsd.prefs.mk has already been loaded. Some individual variables may be defined or used in places where this was not allowed before. CHECK_BUILTIN.*, BUILDLINK_TARGETS, TOOLS_DEPENDS.*, BUILDLINK_DEPMETHOD.*, SUBST_CLASSES. A new parser for Makefile expressions detects and reports more mistakes than bmake itself. Currently it is only used to check the basic syntax; more applications are possible. * PLIST In PLIST files, conditionals of the form ${PLIST.*} are recognized and are not part of the pathname. This allows pkglint to better check for missing manual pages and correctly sorted PLIST files. In --autofix mode, pkglint can sort PLIST files, which makes these rather annoying warnings easy to fix. No more warnings for man pages whose filename doesn't match exactly the section, e.g. man/man3/exit.3c. * Patches The code for checking patch files has been completely rewritten, so that it is easier understandable and well-structured. As an additional benefit, it also became faster. Support for context diffs has been dropped to a minimum, since they are not popular anymore. Pkglint no longer warns about missing trailing whitespace in a line, since all patch programs can handle these lines. It also doesn't request empty lines between multiple diffs in a single file, since that is simply not necessary. Pkglint is picky when a patch file continues after the diff with some text that still looks like a diff, since that means the patch doesn't do what it looks like on first sight (example: audio/faad2/patches/patch-au). * Distinfo When a patch file listed in distinfo cannot be found in the filesystem, this is reported clearly instead of complaining about missing SHA512 hashes (example: audio/libopus). The inter-package distinfo check that verifies whether a distfile has different hashes has been enabled. It had been disabled before, but unintentionally so. * Misc - The check for COMMENT has been updated to reflect the changed default value from url2pkg. - BUILDLINK_API_DEPENDS.* may be set in buildlink3.mk, even if the package is not the current one. (The other variables may be only set for the current package.) - In shell commands, the escape sequence \. (and similar ones, which are often seen in sed(1) commands) no longer produces a warning, since the different shells handle these escape sequences consistently. (It is the echo(1) implementations that actually differ, therefore this warning was superfluous.) - Compiler flags in backticks (typically `pkg-config --cflags`) are properly recognized. - Internal pkglint errors when parsing shell commands have been fixed. - No more warnings about PKGCONFIG_FILE.* being defined but unused. - Dependencies of the form pkgbase>=1.0<5.0 are recognized. - Diagnostics use quotes more often to indicate the placeholders. - The type of GENERATE_PLIST has been changed from List of ShellWord to ShellCommands, since that is what the variable is really about. - The type ShellCommand used to mean "a shell command line in a Makefile", which was confusing. Now it means what the name says, which reduces the wrong warnings for variables like CC (example: x11/kdebase3/options.mk). - Improved buildlink3.mk checks to generate more helpful diagnostics. - Fixed the parsing of dependency patterns, so that all but the most exotic ones are properly recognized. - Fixed the parsing of shell variables of the form ${var%.c}. - Updated the check for the default COMMENT from url2pkg. - Many more small improvements. - Performance has improved again, though only a little bit. - Unit test coverage has increased from 64.2 % to 78.9 %. This fixes most of the points mentioned in PR pkg/46570.
Revision 1.2 / (download) - annotate - [select for diffs], Wed Dec 2 21:46:46 2015 UTC (8 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2015Q4-base,
pkgsrc-2015Q4
Changes since 1.1: +14 -8
lines
Diff to previous 1.1 (colored) to selected 1.35 (colored)
Updated pkglint to 5.1. Changes since 5.0: * Fixed --autofix mode (it hadn't been enabled before) * The --autofix mode now advertises itself when it can do something * The --autofix mode now adds missing empty lines to patch files (only in the leading text section, not in the actual patch content) * Made --autofix code simpler ({prepend,append}{Before,After} was not really needed) * Fixed unit tests to report invalid command lines * Added some more unit tests
Revision 1.1 / (download) - annotate - [select for diffs], Wed Nov 25 13:29:07 2015 UTC (8 years, 4 months ago) by rillig
Branch: MAIN
Diff to selected 1.35 (colored)
Updated pkglint to 5.0 Notable changes include: * The whole code has been rewritten in Go * It is much faster, especially in recursive mode * The code has unit tests, providing examples of use * Some new explanations for existing warnings * Some adjustments to previous warnings