Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint / files
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.26, Sat Apr 22 14:32:48 2023 UTC (11 months ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.25: +0 -0
lines
FILE REMOVED
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revision 1.25 / (download) - annotate - [select for diffs], Sat Nov 19 10:51:07 2022 UTC (16 months, 1 week ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2023Q1-base,
pkgsrc-2023Q1,
pkgsrc-2022Q4-base,
pkgsrc-2022Q4
Changes since 1.24: +3 -1
lines
Diff to previous 1.24 (colored)
pkgtools/pkglint: Update to 22.3.1 Changes since 22.3.0: In doc/CHANGES files, check for typos in month and day of the dates. In conditions for YesNo variables, suggest to replace the modifier ':M[yY][eE][sS]' with a simpler comparison. https://mail-index.netbsd.org/tech-pkg/2022/11/16/msg026992.html
Revision 1.24 / (download) - annotate - [select for diffs], Wed Jul 1 13:17:41 2020 UTC (3 years, 8 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q3-base,
pkgsrc-2022Q3,
pkgsrc-2022Q2-base,
pkgsrc-2022Q2,
pkgsrc-2022Q1-base,
pkgsrc-2022Q1,
pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3,
pkgsrc-2021Q2-base,
pkgsrc-2021Q2,
pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3
Changes since 1.23: +112 -19
lines
Diff to previous 1.23 (colored)
pkgtools/pkglint: update to 20.2.1 Changes since 20.2.0: Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if PKGNAME is defined somewhere else in the package Makefile. Warn if NO_CONFIGURE=yes and REPLACE_* are combined. Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,}, as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}. Allow lua in CATEGORIES.
Revision 1.23 / (download) - annotate - [select for diffs], Thu Apr 30 21:15:03 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Changes since 1.22: +17 -17
lines
Diff to previous 1.22 (colored)
pkgtools/pkglint: update to 20.1.3 Changes since 20.1.2: Stricter check for Python version numbers. Before, 25 and 26 had not been marked as wrong. In assignments like PKGNAME=${DISTNAME:S,from,to,}, modifiers that don't have any effect generate a note. Most of these modifiers are redundant or outdated. Patches must not add well-known absolute paths like /usr/pkg, /var and /etc since these must be overridable by the pkgsrc user. Other absolute paths continue to be allowed.
Revision 1.22 / (download) - annotate - [select for diffs], Mon Dec 16 17:06:05 2019 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1,
pkgsrc-2019Q4-base,
pkgsrc-2019Q4
Changes since 1.21: +44 -49
lines
Diff to previous 1.21 (colored)
pkgtools/pkglint: update to 19.3.19 Changes since 19.3.18: Small improvements to edge cases in SUBST blocks. Small improvements to edge cases in variable assignment and alignment of the continuation backslashes. The --source option shows the changes from autofix, even when the --show-autofix option is not given. This is a welcome side-effect of making the autofix logging simpler and more predictable.
Revision 1.21 / (download) - annotate - [select for diffs], Fri Dec 13 01:39:23 2019 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.20: +42 -0
lines
Diff to previous 1.20 (colored)
pkgtools/pkglint: update to 19.3.17 Changes since 19.3.16: Pkglint now handles SUBST blocks correctly, even those in which some of the variables are defined conditionally. It correctly reports those that are missing in at least one of the possible branches. PKG_JVM is no longer marked as deprecated. It was once package-settable. Since 2002 it is system-provided, and the package-settable counterpart is PKG_JVM_DEFAULT. This does not fit into pkglint's simple model of deprecating variables since the variable name is still valid, it should just not be defined by packages anymore. The alignment of variable assignments has been fixed in some edge cases. In continuation lines where the backslash is beyond column 72, the whitespace before the continuation backslash is fixed to a single space.
Revision 1.20 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.19: +3 -1
lines
Diff to previous 1.19 (colored)
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
Revision 1.19 / (download) - annotate - [select for diffs], Sun Dec 8 00:06:38 2019 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.18: +35 -11
lines
Diff to previous 1.18 (colored)
pkgtools/pkglint: update to 19.3.14 Changes since 19.3.13: When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME} == fixed, the exact suggested expression is now part of the diagnostic. The check and the autofix have been improved. They now apply only to the last modifier in the whole chain, everything else was a bug in pkglint. Pkglint now knows the scope of variables better than before. It knows the difference between variables from <sys.mk> like MACHINE_ARCH, which are always in scope, and those from mk/defaults/mk.conf, which only come into scope later, after bsd.prefs.mk has been included. It warns when variables are used too early, for example in .if conditions. The pathnames in ALTERNATIVES files are now checked for absolute pathnames. This mistake doesn't happen in practice, but the code for converting the different path types internally made it necessary to add these checks. At least this prevents typos. The special check for obsolete licenses has been removed since their license files have been removed and that is checked as well. Variables named *_AWK may be appended to. The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they are obsolete now. They are not used in main pkgsrc and pkgsrc-wip anymore. When a package sets a default value for a user-settable variable (which is something that should not happen anyway), it should .include bsd.prefs.mk before, in order to not accidentally overwrite the user-specified value. Variable modifiers of the form :from=to are now parsed like in bmake. They are greedy and eat up any following colons as well. This means that ${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it. Pkglint now warns about such cases. The handling of relative paths in diagnostics is now consistent. All paths that are part of a diagnostic are relative to the line that issues the diagnostic. Fatal errors are no longer suppressed in --autofix mode. Plus lots of refactoring, to prevent accidental mixing of incompatible relative paths.
Revision 1.18 / (download) - annotate - [select for diffs], Wed Nov 27 22:10:07 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.17: +1 -11
lines
Diff to previous 1.17 (colored)
pkgtools/pkglint: update to 19.3.11 Changes since 19.3.10: The check for buildlink3.mk files that are included conditionally in one place and unconditionally in another place have been refined. Now they also work in cases that do not involve any variables, such as when the condition is a mere exists(filename). References to variables that use parentheses instead of the usual braces produce a warning now, even if pkglint cannot fix them automatically. This affects only a few instances where more than one such variable reference appeared in a single line. The --log-verbose command line option has been removed since it does not have any practical use other than improving the performance during pkglint development itself. Because of that it hadn't even been mentioned in the manual page. Warnings for missing license files now report the path to the license file relative to the line where the warning occurs, like everywhere else.
Revision 1.17 / (download) - annotate - [select for diffs], Sun Nov 17 01:26:25 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.16: +79 -79
lines
Diff to previous 1.16 (colored)
pkgtools/pkglint: update to 19.3.7 Changes since 19.3.6: Improved variable value alignment. Fixed wrong warning about comment lines that were interpreted as shell commands before. Warn when the first category of a package doesn't correspond to the path in the filesystem. This affects 603 packages. No longer warn about deprecated BUILDLINK_TRANSFORM.${OPSYS}. The deprecation warning was meant for BUILDLINK_TRANSFORM.${pkgbase}, but since pkglint cannot distinguish between these, the warnings were wrong.
Revision 1.16 / (download) - annotate - [select for diffs], Fri Nov 1 19:56:53 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.15: +33 -8
lines
Diff to previous 1.15 (colored)
pkgtools/pkglint: update to 19.3.4 Changes since 19.3.3: In cases where the conditions for including buildlink3.mk files differ between the package itself and its own buildlink3.mk file, explain how to determine PKG_OPTIONS for dependencies. Don't issue wrong warnings in options.mk files when the options are handled in a .for loop.
Revision 1.15 / (download) - annotate - [select for diffs], Sat Oct 26 09:51:48 2019 UTC (4 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.14: +28 -1
lines
Diff to previous 1.14 (colored)
pkgtools/pkglint: update to 19.3.2 Changes since 19.3.1: * Pkglint no longer warns about a missing :Q modifier if there is also a :D modifier, since the latter hides the original variable value from the expression value. * Variable names like .CURDIR are now allowed in the _VARGROUPS section. * In dependency lines like "${_COOKIE.extract}:", pkglint no longer warns about the unknown target. No matter whether this is a file name or even a list of other targets, there's no chance for a typo here. * If some dependencies are included conditionally, and the package Makefile and buildlink3.mk disagree, and the conditions depend on PKG_OPTIONS, pkglint outputs a helpful explanation. * The check for including builtin.mk directly can be disabled by giving a reason in a comment at the end of the line.
Revision 1.14 / (download) - annotate - [select for diffs], Tue Oct 1 21:37:59 2019 UTC (4 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.13: +1 -1
lines
Diff to previous 1.13 (colored)
pkgtools/pkglint: update to 19.3.0 Changes since 5.7.24: * There is no need to ask the dummy MAINTAINER from url2pkg whether committing changes is ok. * When autofixing a condition like !empty(PKGPATH:Mliteral), don't generate unnecessary parentheses around ${PKGPATH} == literal. * In a _VARGROUPS section, the public variables should be listed before the private variables, to put important things first. * When pkglint suggests to be run again with the -e, -fs or -F options, repeat the whole command line, to allow for copy-and-paste. * The checks for PKGPATH are fixed and enhanced. It is not a relative path like in ../../category/package, but relative to the pkgsrc root. * Unintended file globbing in sed commands such as s,.*,any, gets a warning. * MASTER_SITES should normally end with a slash, in rare cases an equals sign or a colon are correct, too. * Detect redundant directories in INSTALLATION_DIRS.
Revision 1.13 / (download) - annotate - [select for diffs], Sun Jul 14 21:25:47 2019 UTC (4 years, 8 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q3-base,
pkgsrc-2019Q3
Changes since 1.12: +39 -27
lines
Diff to previous 1.12 (colored)
pkgtools/pkglint: update to 5.7.16 Changes since 5.7.15: * Completely rewrote the code for aligning multiple variable assignment lines. It works on the actual lines of the file now instead of the parsed lines. This provides more exact diagnostics and also makes the handling of these lines easier so that future requirements can be implemented more easily. * Added support for exotic conditions in .if clauses. These conditions are not seen in the wild though. * Fixed wrong diagnostics for ALTERNATIVES files that appear conditionally in the PLIST. * As always: lots of refactorings and newly added tests.
Revision 1.12 / (download) - annotate - [select for diffs], Sun Jun 30 20:56:19 2019 UTC (4 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.11: +14 -1
lines
Diff to previous 1.11 (colored)
pkgtools/pkglint: update to 5.7.14 Changes since 5.7.13: - Removed the -Cextra command line option since it didn't produce useful warnings. - Removed unwarranted warnings about _WRAP_EXTRA_ARGS.CC being used in packages. - Cleaned up the canonical order of variables in package Makefiles. - Added a few commands to those that cannot fail, to reduce the number of "at the left of the | operator" in shell programs. - Fixed warnings about "-ggdb" being an unknown shell command. - Reduced number of warnings about lists being used where a single value is expected. - Replaced unreliable check for invalid CFLAGS and LDFLAGS with a more practical check. - Renamed "RCS tag" to "CVS tag" to make the diagnostics more modern. - Added warning when PKGNAME or PKGVERSION is used in MASTER_SITES. - Reworded warning for missing or superfluous PLIST files. - Lots of other detail changes, refactorings and automatic tests.
Revision 1.11 / (download) - annotate - [select for diffs], Mon Jun 10 19:51:57 2019 UTC (4 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q2-base,
pkgsrc-2019Q2
Changes since 1.10: +12 -0
lines
Diff to previous 1.10 (colored)
pkgtools/pkglint: updated to 5.7.13 Changes since 5.7.12: * Fixed a warning in the variable permissions that previously said "this variable should not be used at load time in this file, it would be ok in .", with an empty list of alternative files. * Lots of refactoring and new tests.
Revision 1.10 / (download) - annotate - [select for diffs], Sat Apr 20 17:43:24 2019 UTC (4 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.9: +28 -2
lines
Diff to previous 1.9 (colored)
pkgtools/pkglint: update to 5.7.5 Changes since 5.7.4: * Warn about invalid variable uses in directives like .if and .for * Do not warn when a package-settable variable is assigned using the ?= operator before including bsd.prefs.mk. This warning only makes sense for user-settable and system-provided variables. * The parser for variable uses like ${VAR:@v@${v:Q}} is more robust now, which reduces the number of parse errors and leads to more appropriate diagnostics, in cases like ${URL:Mftp://*}, which should really be ${URL:Mftp\://*}. * The valid values for OPSYS are now determined by the files in mk/platform instead of allowing arbitrary identifiers. This catches a few instances where "Solaris" is used instead of the correct "SunOS". * Setting USE_LANGUAGES only has an effect if mk/compiler.mk has not yet been included. In all other cases, pkglint warns now. * Missing entries in doc/CHANGES produce a note now. This will lead to more accurate statistics for the release notes.
Revision 1.9 / (download) - annotate - [select for diffs], Wed Apr 3 21:49:51 2019 UTC (4 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.8: +40 -0
lines
Diff to previous 1.8 (colored)
pkgtools/pkglint: update to 5.7.4 Changes since 5.7.3: * Warn about dependency patterns that are missing a version number, such as ${PYPKGPREFIX}-sqlite3:../../databases/py-sqlite3. * Suggest to replace the := assignment operator with the :sh modifier, in some cases where the variable is not obviously used at load time.
Revision 1.8 / (download) - annotate - [select for diffs], Sun Mar 24 13:58:38 2019 UTC (5 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q1-base,
pkgsrc-2019Q1
Changes since 1.7: +22 -0
lines
Diff to previous 1.7 (colored)
pkgtools/pkglint: update to 5.7.3 Changes since 5.7.2: PLIST files are checked for non-ASCII characters. Even though pkgsrc sets up the environment with LC_ALL=C, there are still some cases of encoding errors. The case discussed on the tech-pkg mailing list was lang/go112. The checks for variable permissions ("may not be set in this file") have been reworked completely. Many of the variable permissions had different rules for Makefile and Makefile.common. These different rules tried to prevent accidental overwriting of variables. Starting in July 2018, pkglint got a check for redundant variables that is far more accurate than the previous variable permissions. Therefore these fine-grained permissions are no longer necessary. This removes a few hundred wrong warnings about insufficient permissions. The check that adds missing SHA512 hashes to distinfo files has been fixed to work correctly in DIST_SUBDIR cases. Improved the checks regarding tools that are used by a package but not added to USE_TOOLS. For example, the "make" tool is always available, as are all tools that are added to TOOLS_CREATE. Lots of small improvements, as always.
Revision 1.7 / (download) - annotate - [select for diffs], Sat Jan 26 16:31:33 2019 UTC (5 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.6: +0 -3
lines
Diff to previous 1.6 (colored)
pkgtools/pkglint: update to 5.6.12 Changes since 5.6.11: * In buildlink3.mk files, print the paths relative to the line, not to the pkgsrc root. * When explaining that a variable cannot be set/used because of wrong permissions, list the permissions. This provides more transparency than just stating that the desired action is not allowed. * When pkglint checks a pkgsrc-wip package, don't warn about malformed lines in doc/CHANGES-* since pkgsrc-wip users typically cannot do anything about these errors. * In profiling mode, not only the code coverage and the performance statistics are dumped, the whole heap is also dumped to see which parts of pkglint consume the most heap memory. Pkglint now needs less heap memory than before, which mainly affects full scans. * The checks for absolute pathnames have gone. They were of questionable value since pkglint has failed to give proper advice on how to fix them properly, at least for the last 12 years. * The check that pkgsrc-wip packages should only use exact CVS Ids (the unexpanded variant) has been disabled again. It occurred about 16000 times but even fixing it wouldn't improve anything since it was mostly a formatting issue without any practical consequences. * Warn about trailing variable modifiers like in ${VAR:S,from,to,extra}. * Properly parse ${VAR:!command!}. * Suggest to replace SUBST_SED with SUBST_VARS where possible, even with complicated shell quoting. Pkglint can autofix most of these overly verbose cases. * Load builtin.mk whenever the corresponding buildlink3.mk file is included. This fixes several warnings about undefined variables (especially for packages using OpenSSL). * Parse .for lines like bmake does since 2015, splitting words like in brk_string. * Optionally show a warning even if it cannot be autofixed by pkglint. This is useful for the SUBST_VARS replacement since even when pkglint cannot automatically replace the code, there are still cases where it can warn at least. * As always, several refactorings.
Revision 1.6 / (download) - annotate - [select for diffs], Mon Dec 17 00:15:39 2018 UTC (5 years, 3 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q4-base,
pkgsrc-2018Q4
Changes since 1.5: +9 -2
lines
Diff to previous 1.5 (colored)
pkgtools/pkglint: update to 5.6.9 Changes since 5.6.8: * In addition to the pkglint binary, the whole pkglint code is installed as a library, so that other packages can use the code for doing their own checks on pkgsrc packages, Makefiles, shell programs, or the other file types from pkgsrc. * BUILDLINK_*.* may be used in all files. * Lots of refactorings
Revision 1.5 / (download) - annotate - [select for diffs], Wed Nov 7 20:58:23 2018 UTC (5 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.4: +30 -2
lines
Diff to previous 1.4 (colored)
pkgtools/pkglint: update to 5.6.6 Changes since 5.6.5: - Removed plist-clash since it had crashed unconditionally whenever it was called. This means that in the last 3 years, nobody can have used it in the originally intended way. - Fixed interactions between the --source, --explain, --show-autofix, --autofix and --only options. - Fixed "defined but not used" and "used but not defined" for variables from the pkgsrc infrastructure. - Lots of small fixes and improvements found by the large pkglint code review (12% done).
Revision 1.4 / (download) - annotate - [select for diffs], Wed Sep 5 17:56:22 2018 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q3-base,
pkgsrc-2018Q3
Changes since 1.3: +1 -1
lines
Diff to previous 1.3 (colored)
pkgtools/pkglint: update to 5.6.2 Changes since 5.6.1: * Improved checks that depend on whether bsd.prefs.mk is included or not. * Improved checks for tools, whether they may be used at load time or at run time. * Improved tokenizer for shell commands. $| is not a variable but a dollar followed by a pipe. * Warnings about SUBST context are now shown by default. * A warning is shown when a SUBST block is declared for *-configure but the package has defined USE_CONFIGURE=no. * Don't warn about USE_TOOLS:= ${USE_TOOLS:Ntool}. * Don't warn about using the ?= operator in buildlink3.mk files before including bsd.prefs.mk (for some more variables, but not all). * Report an error for packages from main pkgsrc that have a TODO or README file. Packages should be simple enough that they don't need a README file and ready for production so that they don't need a TODO. * Lots of small bug fixes and new tests.
Revision 1.3 / (download) - annotate - [select for diffs], Sun Jul 10 21:24:47 2016 UTC (7 years, 8 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q2-base,
pkgsrc-2018Q2,
pkgsrc-2018Q1-base,
pkgsrc-2018Q1,
pkgsrc-2017Q4-base,
pkgsrc-2017Q4,
pkgsrc-2017Q3-base,
pkgsrc-2017Q3,
pkgsrc-2017Q2-base,
pkgsrc-2017Q2,
pkgsrc-2017Q1-base,
pkgsrc-2017Q1,
pkgsrc-2016Q4-base,
pkgsrc-2016Q4,
pkgsrc-2016Q3-base,
pkgsrc-2016Q3
Changes since 1.2: +4 -0
lines
Diff to previous 1.2 (colored)
Updated pkglint to 5.4.7. Changes since 5.4.6: * Allow conditionals of the form "${var1}" == "${var2}" * Check for indentation of .include directives * Check arbitrarily complex license conditions * General code cleanup
Revision 1.2 / (download) - annotate - [select for diffs], Thu Jul 7 12:09:27 2016 UTC (7 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.1: +6 -0
lines
Diff to previous 1.1 (colored)
Updated pkglint to 5.4.3. Changes since 5.4.2: * Variables like ${VAR_${OTHER_VAR}} are no longer checked for use/define mismatch * The check for plural variable names has been removed * The type of variables called *DESTDIR is no longer guessed to be a directory name * The check for unknown shell commands is disabled in Makefile sections that depend on OPSYS * The experimental hand-written shell parser has been replaced with a Yacc-generated one * Meta packages don't need a LICENSE * When PKGNAME is defined in terms of ${DISTNAME:S/from/to/:tl}, more modifiers (like :tl) are handled properly * When the MAINTAINER or OWNER of a package is not the current user, a warning is printed for modified files * The check for share/applications/*.desktop has been disabled, since pkglint would need to inspect the file's actual contents to see whether desktopdb.mk must be included or not * SUBST_CLASSES may also be SUBST_CLASSES.NetBSD * Loosened the usage restrictions for several variables, e.g. many variables that may be appended in a Makefile may also be set unconditionally * PKG_OPTIONS_VAR must be of the form PKG_OPTIONS.*
Revision 1.1 / (download) - annotate - [select for diffs], Sun Jun 5 11:24:32 2016 UTC (7 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q2-base,
pkgsrc-2016Q2
Updated pkglint to 5.4.0. Changes since 5.3.7: * Replaced the -D... debug options with a single -d * Omitted duplicate diagnostics * Marked the :Q operator unnecessary for some variables * Improved detection of whether bsd.prefs.mk has been included, which fixed unwarranted warnings about load time evaluation of some variables like ${ECHO} and ${SED} * Improved detection for $(VAR) with round parentheses * Fixed allowed locations for several variables * Improved detection for used variables (still not perfect) * Added warning that MASTER_SITES should not be used in HOMEPAGE * Fixed warning about manual patches not being in distinfo * Added a check for missing MASTER_SITE_* variables * Added a check for unfinished url2pkg work * Fixed several wrong warnings