Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. =================================================================== RCS file: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/mkparser.go,v rcsdiff: /ftp/cvs/cvsroot/pkgsrc/pkgtools/pkglint/files/Attic/mkparser.go,v: warning: Unknown phrases like `commitid ...;' are present. retrieving revision 1.16 retrieving revision 1.17 diff -u -p -r1.16 -r1.17 --- pkgsrc/pkgtools/pkglint/files/Attic/mkparser.go 2018/09/05 17:56:22 1.16 +++ pkgsrc/pkgtools/pkglint/files/Attic/mkparser.go 2018/10/03 22:27:53 1.17 @@ -6,6 +6,8 @@ import ( "strings" ) +// MkParser wraps a Parser and provides methods for parsing +// things related to Makefiles. type MkParser struct { *Parser } @@ -193,6 +195,7 @@ loop: } repl.Reset(modifierMark) + // FIXME: Why AdvanceRegexp? This accepts :S,a,b,c,d,e,f but shouldn't. for p.VarUse() != nil || repl.AdvanceRegexp(regex.Pattern(`^([^:$`+closing+`]|\$\$)+`)) { } if suffixSubst := repl.Since(modifierMark); contains(suffixSubst, "=") {