![[BACK]](/icons/back.gif){kind=icon}
Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint / files
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.18, Sat Apr 22 14:32:48 2023 UTC (11 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.17: +0 -0
lines
FILE REMOVED
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revision 1.17 / (download) - annotate - [select for diffs], Wed Mar 29 07:12:36 2023 UTC (12 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.16: +6 -2
lines
Diff to previous 1.16 (colored) to selected 1.9 (colored)
Update pkgtools/pkglint to 23.1.0 Changes since 22.4.1: In makefiles outside pkgsrc, don't require the first line to contain the CVS Id. When simplifying conditions, correctly handle the edge case that a single-word value may evaluate numerically to zero. In dependency lines, parse '#' signs correctly. In error messages about malformed patch files, use the correct plural form.
Revision 1.16 / (download) - annotate - [select for diffs], Thu Mar 2 08:58:29 2023 UTC (13 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2023Q1-base,
pkgsrc-2023Q1
Changes since 1.15: +11 -7
lines
Diff to previous 1.15 (colored) to selected 1.9 (colored)
pkgtools/pkglint: Update to 22.4.1 Changes since 22.4.0: Allow pkglint to be run outside the pkgsrc top directory, in order to allow individual makefiles to be formatted and checked as well. The many pkgsrc-specific checks don't apply in this case. This mode is experimental, there are still crashes to be expected. Fix a crash for syntactically invalid conditions in '.if'. Fix parsing of dependency lines that contain an escaped '#', which is used for switching to another shell using a '.SHELL: ...' line.
Revision 1.15 / (download) - annotate - [select for diffs], Mon Nov 28 23:33:28 2022 UTC (16 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q4-base,
pkgsrc-2022Q4
Changes since 1.14: +26 -2
lines
Diff to previous 1.14 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 22.3.2 Changes since 22.3.1: Complain about conditions of the form '_PYTHON_VERSION < 38', as they lead to 'Malformed conditional' when _PYTHON_VERSION is 'none' instead of a number.
Revision 1.14 / (download) - annotate - [select for diffs], Sun Jul 24 20:07:20 2022 UTC (20 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q3-base,
pkgsrc-2022Q3
Changes since 1.13: +3 -140
lines
Diff to previous 1.13 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 22.2.3
Changes since 22.2.2:
CHECK_WRKREF is known to pkglint, which prevents conditions using this
variable from being simplified in a wrong way.
For variables that are guaranteed to be defined, suggest to simplify the
condition '!empty(VAR:M[Yy][Ee][Ss])' to '${VAR:M[Yy][Ee][Ss]}', as that
reduces the number of negations in the condition.
Detect redundant WRKSRC definitions and suggest to remove them.
Fix wrong "c99 is not valid for USE_LANGUAGES" warnings.
Revision 1.13 / (download) - annotate - [select for diffs], Sat Jul 9 06:40:55 2022 UTC (21 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.12: +3 -1
lines
Diff to previous 1.12 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 22.2.2 Changes since 22.2.1: Require the current checksum algorithms for pkgsrc-wip packages as well. SHA1 and RMD160 are no longer allowed for distfiles. Do not warn about 'Package should not' when checking .mk files in the pkgsrc infrastructure.
Revision 1.12 / (download) - annotate - [select for diffs], Wed Jul 6 06:14:24 2022 UTC (21 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.11: +29 -3
lines
Diff to previous 1.11 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 22.2.1 Changes since 22.2.0: Suggest simpler condition when matching a variable against a pattern (occurs 220 times in pkgsrc). Improve explanation for documenting patches.
Revision 1.11 / (download) - annotate - [select for diffs], Sun Jun 6 11:46:43 2021 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q2-base,
pkgsrc-2022Q2,
pkgsrc-2022Q1-base,
pkgsrc-2022Q1,
pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3,
pkgsrc-2021Q2-base,
pkgsrc-2021Q2
Changes since 1.10: +4 -2
lines
Diff to previous 1.10 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 21.1.4 Changes since 21.1.3: Allow slash in Git tags like 'refs/tags/v1.0.0', as well as in make targets like 'subdir/build'.
Revision 1.10 / (download) - annotate - [select for diffs], Wed Jul 1 13:17:41 2020 UTC (3 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3
Changes since 1.9: +2 -2
lines
Diff to previous 1.9 (colored)
pkgtools/pkglint: update to 20.2.1
Changes since 20.2.0:
Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if
PKGNAME is defined somewhere else in the package Makefile.
Warn if NO_CONFIGURE=yes and REPLACE_* are combined.
Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,},
as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}.
Allow lua in CATEGORIES.
Revision 1.9 / (download) - annotate - [selected], Sun Jun 14 11:35:54 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Changes since 1.8: +95 -1
lines
Diff to previous 1.8 (colored)
pkgtools/pkglint: update to 20.1.17 Changes since 20.1.16: Conditions that contradict each other in the same file are reported as errors. Inspired by lang/rust/Makefile r1.174.
Revision 1.8 / (download) - annotate - [select for diffs], Sun Jun 7 15:49:23 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.7: +1 -1
lines
Diff to previous 1.7 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 20.1.15 Changes since 20.1.14: Fix confusing wording of diagnostic "should contain text". It's more precise to say "this line should consist of this text". Otherwise it's too easy to interpret it as "the text should occur somewhere in the line". Allow BUILDLINK_PREFIX.* to be used in helper files. Especially for programming language packages, files like plugin.mk often include buildlink3.mk and therefore may refer to the BUILDLINK_PREFIX of this package. Warn about redundant BUILDLINK_API_VERSION restrictions. Previously, the check had only been enabled if the operators from the default dependency pattern (buildlink3.mk) and the additional dependency pattern (package) used the same operators, which already covered most practical cases. Determine SuSE versions from the pkgsrc tree.
Revision 1.7 / (download) - annotate - [select for diffs], Tue Jun 2 17:52:26 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.6: +24 -0
lines
Diff to previous 1.6 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 20.1.13 Changes since 20.1.12: Numeric comparison in conditions should not be used. It is currently only used for comparing version numbers. https://mail-index.netbsd.org/pkgsrc-changes/2020/06/02/msg215278.html
Revision 1.6 / (download) - annotate - [select for diffs], Sun Mar 15 11:31:24 2020 UTC (4 years, 1 month ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1
Changes since 1.5: +12 -3
lines
Diff to previous 1.5 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 19.4.11 Changes since 19.4.10: The use of PKG_OPTIONS and PKG_BUILD_OPTIONS in buildlink3.mk and other files is checked for common mistakes. Checking the indentation of a continuation line no longer crashes in edge cases.
Revision 1.5 / (download) - annotate - [select for diffs], Sat Mar 7 23:35:35 2020 UTC (4 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.4: +1 -0
lines
Diff to previous 1.4 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 19.4.10 Changes since 19.4.9: In continuation lines with long values, pkglint no longer suggests to move the continuation backslash in the middle of the variable value, as that would be impossible. Warn when a shell command is assigned to a variable that only takes pathnames. Shell commands can contain command line options, and these are not pathnames. The TOOLS_PLATFORM.tool variables are not defined on every platform. When these variables are used outside an OPSYS check, a warning lists the platforms where the tool is undefined or only defined conditionally.
Revision 1.4 / (download) - annotate - [select for diffs], Sat Jan 18 21:56:09 2020 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.3: +30 -3
lines
Diff to previous 1.3 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 19.4.4 Changes since 19.4.3: Packages that still use http in their HOMEPAGE URL generate warnings that the URL should use https instead.
Revision 1.3 / (download) - annotate - [select for diffs], Sat Jan 4 19:53:14 2020 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.2: +3 -2
lines
Diff to previous 1.2 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update to 19.4.1 Changes since 19.4.0: The notes for inserting an empty line have been changed from "insert after this line" to "insert before this line" to make the line numbers in the diagnostics contiguous. There had been several places where the diagnostics went from line 1 to line 2 and then back to line 1, which was confusing. The lines in ALTERNATIVES files are checked for trailing whitespace. This is only for consistency with the other checks. In the whole pkgsrc tree all ALTERNATIVES files are already fine. The diagnostics for comments in .endif/.endfor lines that don't correspond to their .if/.elif/.for counterparts now includes the exact line number of the corresponding condition, to make the warning easier to fix. The diagnostics for wrong variable value alignment now mention the current column in addition to the desired column, to make it easier to see by how much and in which direction the indentation should be fixed. Variables that are used in conditions before they are actually defined need the :U modifier.
Revision 1.2 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q4-base,
pkgsrc-2019Q4
Changes since 1.1: +28 -30
lines
Diff to previous 1.1 (colored) to selected 1.9 (colored)
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
Revision 1.1 / (download) - annotate - [select for diffs], Sun Dec 8 00:06:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Diff to selected 1.9 (colored)
pkgtools/pkglint: update to 19.3.14
Changes since 19.3.13:
When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME}
== fixed, the exact suggested expression is now part of the diagnostic.
The check and the autofix have been improved. They now apply only to the
last modifier in the whole chain, everything else was a bug in pkglint.
Pkglint now knows the scope of variables better than before. It knows
the difference between variables from <sys.mk> like MACHINE_ARCH, which
are always in scope, and those from mk/defaults/mk.conf, which only come
into scope later, after bsd.prefs.mk has been included. It warns when
variables are used too early, for example in .if conditions.
The pathnames in ALTERNATIVES files are now checked for absolute
pathnames. This mistake doesn't happen in practice, but the code for
converting the different path types internally made it necessary to add
these checks. At least this prevents typos.
The special check for obsolete licenses has been removed since their
license files have been removed and that is checked as well.
Variables named *_AWK may be appended to.
The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they
are obsolete now. They are not used in main pkgsrc and pkgsrc-wip
anymore.
When a package sets a default value for a user-settable variable (which
is something that should not happen anyway), it should .include
bsd.prefs.mk before, in order to not accidentally overwrite the
user-specified value.
Variable modifiers of the form :from=to are now parsed like in bmake.
They are greedy and eat up any following colons as well. This means that
${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it.
Pkglint now warns about such cases.
The handling of relative paths in diagnostics is now consistent. All
paths that are part of a diagnostic are relative to the line that issues
the diagnostic.
Fatal errors are no longer suppressed in --autofix mode.
Plus lots of refactoring, to prevent accidental mixing of incompatible
relative paths.