![[BACK]](/icons/back.gif){kind=icon}
Up to [cvs.NetBSD.org] / pkgsrc / pkgtools / pkglint / files
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.14, Sat Apr 22 14:32:48 2023 UTC (11 months, 4 weeks ago) by rillig
Branch: MAIN
CVS Tags: HEAD
Changes since 1.13: +0 -0
lines
FILE REMOVED
pkgtools/pkglint: update to 23.1.7 Changes since 23.1.0: No functional changes. Instead of having two copies of the code, install the package by downloading the releases from GitHub. Reduce the build-time dependencies by delivering pre-generated parser code.
Revision 1.13 / (download) - annotate - [select for diffs], Fri Aug 19 17:35:43 2022 UTC (20 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2023Q1-base,
pkgsrc-2023Q1,
pkgsrc-2022Q4-base,
pkgsrc-2022Q4,
pkgsrc-2022Q3-base,
pkgsrc-2022Q3
Changes since 1.12: +22 -0
lines
Diff to previous 1.12 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 22.2.6 Changes since 22.2.5: A makefile that adds a _VARGROUPS section is partly considered part of the infrastructure. It may define and use variables from its own namespace. For example, devel/cmake/build.mk adds _VARGROUPS+=cmake, thereby reserving the namespace '_CMAKE_*' for itself. Dependencies in BUILDLINK_API_DEPENDS and BUILDLINK_ABI_DEPENDS that contain unresolved variable expressions are no longer marked as redundant. They were marked as redundant before because '$', when interpreted as a package version, was smaller than 0.0.
Revision 1.12 / (download) - annotate - [select for diffs], Wed Aug 17 20:41:51 2022 UTC (20 months ago) by rillig
Branch: MAIN
Changes since 1.11: +6 -1
lines
Diff to previous 1.11 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 22.2.5 Changes since 22.2.4: Makefiles in wip/mk may use internal variables (starting with '_'), just like their counterparts in main mk/. Package versions containing letters are now parsed like in pkg_install.
Revision 1.11 / (download) - annotate - [select for diffs], Fri Jun 24 07:16:23 2022 UTC (21 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q2-base,
pkgsrc-2022Q2
Changes since 1.10: +2 -2
lines
Diff to previous 1.10 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 22.2.0 Changes since 22.1.0: In ALTERNATIVES files, the wrapper path must be either in bin, @PKGMANDIR@ or sbin. This catches typos like "in" instead of "bin", as well as hard-coded "man".
Revision 1.10 / (download) - annotate - [select for diffs], Mon Mar 21 22:30:06 2022 UTC (2 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2022Q1-base,
pkgsrc-2022Q1
Changes since 1.9: +13 -1
lines
Diff to previous 1.9 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 22.1.0 Changes since 21.4.4: Python packages that declare 2.7 as an incompatible Python version no longer need to provide a rationale for this since it is common knowledge that Python 2.7 is old and therefore unsupported by many modern packages.
Revision 1.9 / (download) - annotate - [select for diffs], Sun Jan 16 19:14:52 2022 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.8: +1 -1
lines
Diff to previous 1.8 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 21.4.2 Changes since 21.4.1: When checking a package, check for naming collision with other packages from the same category, on case-insensitive file systems. For packages from pkgsrc-wip, additionally perform the same check for the main category of the package, to prepare for importing the package.
Revision 1.8 / (download) - annotate - [select for diffs], Sun Aug 8 22:04:15 2021 UTC (2 years, 8 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2021Q4-base,
pkgsrc-2021Q4,
pkgsrc-2021Q3-base,
pkgsrc-2021Q3
Changes since 1.7: +47 -0
lines
Diff to previous 1.7 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 21.2.2 Changes since 21.2.1: Check the variable names of OPSYS-specific variables for typos, such as 'Dragonfly' with a lowercase 'f'. Suggested by David A. Holland in PR pkg/56352. Warn if variables like CFLAGS are assigned using the operator '='. Suggested by David A. Holland in PR pkg/56352.
Revision 1.7 / (download) - annotate - [select for diffs], Fri Jun 12 19:14:45 2020 UTC (3 years, 10 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2021Q2-base,
pkgsrc-2021Q2,
pkgsrc-2021Q1-base,
pkgsrc-2021Q1,
pkgsrc-2020Q4-base,
pkgsrc-2020Q4,
pkgsrc-2020Q3-base,
pkgsrc-2020Q3,
pkgsrc-2020Q2-base,
pkgsrc-2020Q2
Changes since 1.6: +68 -49
lines
Diff to previous 1.6 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 20.1.16 Changes since 20.1.15: When a package adds an additional version requirement for another package, it must do so using BUILDLINK_API_DEPENDS instead of BUILDLINK_ABI_DEPENDS. Most packages already do this. When a values is appended to an undefined variable using the += operator, bmake does not add a space before, and pkglint caught up to do the same. This change has no practical consequences though. As always, a bit of refactoring. The method names of MkAssignChecker contained the redundant word "varassign".
Revision 1.6 / (download) - annotate - [select for diffs], Thu Apr 30 21:15:03 2020 UTC (3 years, 11 months ago) by rillig
Branch: MAIN
Changes since 1.5: +11 -9
lines
Diff to previous 1.5 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 20.1.3
Changes since 20.1.2:
Stricter check for Python version numbers. Before, 25 and 26 had not
been marked as wrong.
In assignments like PKGNAME=${DISTNAME:S,from,to,}, modifiers that don't
have any effect generate a note. Most of these modifiers are redundant
or outdated.
Patches must not add well-known absolute paths like /usr/pkg, /var and
/etc since these must be overridable by the pkgsrc user. Other absolute
paths continue to be allowed.
Revision 1.5 / (download) - annotate - [select for diffs], Wed Mar 18 08:24:49 2020 UTC (4 years, 1 month ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base,
pkgsrc-2020Q1
Changes since 1.4: +2 -2
lines
Diff to previous 1.4 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 19.4.12 Changes since 19.4.11: Redundant additions to BUILDLINK_API_DEPENDS and BUILDLINK_ABI_DEPENDS get warnings since they may have been needed in the past but the dependent package has increased its required version numbers over time.
Revision 1.4 / (download) - annotate - [select for diffs], Sat Feb 15 13:48:40 2020 UTC (4 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.3: +19 -0
lines
Diff to previous 1.3 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 19.4.8 Changes since 19.4.7: The diagnostic for homepages using FTP is simpler now. When running pkglint recursively on the top-level directory, the inter-package checks (distfile hashes, unused licenses) are enabled implicitly. This way, the only effect of the -Cglobal option is now whether the pkgsrc infrastructure files are checked as well. The check for removed packages that have not been recorded in doc/CHANGES prints the correct lines when pkglint is run with the --source option. Fatal technical errors are no longer treated as diagnostics since they are none. That was an early conceptual mistake, but since these fatal error didn't happen often, it didn't matter. In diagnostics, when referring to other lines, the previously used words before/after have been replaced with above/below to avoid any confusion whether space or time is meant. In CONF_FILES, spaces and quotes are allowed. See https://gnats.netbsd.org/42191. Fixed unintended side-effects when running pkglint --autofix --only. Before, all fixes were applied to the file, whether or not they matched the --only option. Fixed resolution of relative paths of the form ../../category/package when they appeared in an infrastructure file. Lots of refactorings and housekeeping, as usual.
Revision 1.3 / (download) - annotate - [select for diffs], Sat Jan 4 19:53:14 2020 UTC (4 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.2: +47 -19
lines
Diff to previous 1.2 (colored) to selected 1.1 (colored)
pkgtools/pkglint: update to 19.4.1 Changes since 19.4.0: The notes for inserting an empty line have been changed from "insert after this line" to "insert before this line" to make the line numbers in the diagnostics contiguous. There had been several places where the diagnostics went from line 1 to line 2 and then back to line 1, which was confusing. The lines in ALTERNATIVES files are checked for trailing whitespace. This is only for consistency with the other checks. In the whole pkgsrc tree all ALTERNATIVES files are already fine. The diagnostics for comments in .endif/.endfor lines that don't correspond to their .if/.elif/.for counterparts now includes the exact line number of the corresponding condition, to make the warning easier to fix. The diagnostics for wrong variable value alignment now mention the current column in addition to the desired column, to make it easier to see by how much and in which direction the indentation should be fixed. Variables that are used in conditions before they are actually defined need the :U modifier.
Revision 1.2 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q4-base,
pkgsrc-2019Q4
Changes since 1.1: +3 -3
lines
Diff to previous 1.1 (colored)
pkgtools/pkglint: update pkglint to 19.3.15 Changes since 19.3.14: Invalid lines in PLIST files are now reported as errors instead of warnings. If pkglint doesn't know about it, it must be an error. In PLIST files, all paths are validated to be canonical. That is, no dotdot components, no absolute paths, no extra slashes, no intermediate dot components. Fewer notes for unexpanded variable expressions in DESCR files. Before, the text $@ was reported as possible Makefile variable even though it was just a Perl expression. README files are allowed again in pkgsrc package directories. There was no convincing argument why these should be forbidden. A few diagnostics have been changed from NOTE to WARNING or from WARNING to ERROR, to match their wording. When pkglint suggests to replace :M with ==, the wording is now "can be made" instead of "should".
Revision 1.1 / (download) - annotate - [selected], Sun Dec 8 00:06:38 2019 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
pkgtools/pkglint: update to 19.3.14
Changes since 19.3.13:
When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME}
== fixed, the exact suggested expression is now part of the diagnostic.
The check and the autofix have been improved. They now apply only to the
last modifier in the whole chain, everything else was a bug in pkglint.
Pkglint now knows the scope of variables better than before. It knows
the difference between variables from <sys.mk> like MACHINE_ARCH, which
are always in scope, and those from mk/defaults/mk.conf, which only come
into scope later, after bsd.prefs.mk has been included. It warns when
variables are used too early, for example in .if conditions.
The pathnames in ALTERNATIVES files are now checked for absolute
pathnames. This mistake doesn't happen in practice, but the code for
converting the different path types internally made it necessary to add
these checks. At least this prevents typos.
The special check for obsolete licenses has been removed since their
license files have been removed and that is checked as well.
Variables named *_AWK may be appended to.
The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they
are obsolete now. They are not used in main pkgsrc and pkgsrc-wip
anymore.
When a package sets a default value for a user-settable variable (which
is something that should not happen anyway), it should .include
bsd.prefs.mk before, in order to not accidentally overwrite the
user-specified value.
Variable modifiers of the form :from=to are now parsed like in bmake.
They are greedy and eat up any following colons as well. This means that
${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it.
Pkglint now warns about such cases.
The handling of relative paths in diagnostics is now consistent. All
paths that are part of a diagnostic are relative to the line that issues
the diagnostic.
Fatal errors are no longer suppressed in --autofix mode.
Plus lots of refactoring, to prevent accidental mixing of incompatible
relative paths.