The NetBSD Project

CVS log for pkgsrc/pkgtools/pkglint/files/check_test.go

[BACK] Up to [] / pkgsrc / pkgtools / pkglint / files

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.75 / (download) - annotate - [select for diffs], Wed Jul 1 13:17:41 2020 UTC (11 months, 2 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2021Q1-base, pkgsrc-2021Q1, pkgsrc-2020Q4-base, pkgsrc-2020Q4, pkgsrc-2020Q3-base, pkgsrc-2020Q3, HEAD
Changes since 1.74: +0 -2 lines
Diff to previous 1.74 (colored)

pkgtools/pkglint: update to 20.2.1

Changes since 20.2.0:

Don't warn about a possibly redundant PKGNAME=${DISTNAME} assignment if
PKGNAME is defined somewhere else in the package Makefile.

Warn if NO_CONFIGURE=yes and REPLACE_* are combined.

Suggest to replace ${VAR:@l@-l${l}@} with the simpler ${VAR:S,^,-l,},
as well as ${VAR:@l@${l}suffix@} with the simpler ${VAR:=suffix}.

Allow lua in CATEGORIES.

Revision 1.74 / (download) - annotate - [select for diffs], Sat Jun 20 07:00:44 2020 UTC (11 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q2-base, pkgsrc-2020Q2
Changes since 1.73: +0 -1 lines
Diff to previous 1.73 (colored)

pkgtools/pkglint: update to 20.1.18

Changes since 20.1.17:

Fixed the algorithm for checking whether two patterns overlap, such as

Fixed wrong warning about foreign variable in SUBST block, as seen in

Revision 1.73 / (download) - annotate - [select for diffs], Sun Jun 14 11:35:54 2020 UTC (12 months ago) by rillig
Branch: MAIN
Changes since 1.72: +1 -0 lines
Diff to previous 1.72 (colored)

pkgtools/pkglint: update to 20.1.17

Changes since 20.1.16:

Conditions that contradict each other in the same file are reported as
errors.  Inspired by lang/rust/Makefile r1.174.

Revision 1.72 / (download) - annotate - [select for diffs], Sun Jun 7 15:49:23 2020 UTC (12 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.71: +3 -4 lines
Diff to previous 1.71 (colored)

pkgtools/pkglint: update to 20.1.15

Changes since 20.1.14:

Fix confusing wording of diagnostic "should contain text".  It's more
precise to say "this line should consist of this text".  Otherwise it's
too easy to interpret it as "the text should occur somewhere in the

Allow BUILDLINK_PREFIX.* to be used in helper files.  Especially for
programming language packages, files like often include and therefore may refer to the BUILDLINK_PREFIX of this

Warn about redundant BUILDLINK_API_VERSION restrictions.  Previously, the
check had only been enabled if the operators from the default dependency
pattern ( and the additional dependency pattern (package)
used the same operators, which already covered most practical cases.

Determine SuSE versions from the pkgsrc tree.

Revision 1.71 / (download) - annotate - [select for diffs], Mon Jun 1 20:49:54 2020 UTC (12 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.70: +6 -6 lines
Diff to previous 1.70 (colored)

pkgtools/pkglint: update to 20.1.12

Changes since 20.1.11:

The file must only ever be included by package Makefiles
directly, not by other Makefile fragments.  Seen in www/w3m.

The variable BUILDLINK_PREFIX.* should only be used for packages that
have actually been included by the package.  This catches the use of
BUILDLINK_PREFIX.libiconv, which should have been iconv instead.

Allow comments before line 3 in files. This is necessary
for mariadb55-client since its buildlink identifier is mysql-client,
which is so non-obvious that it needs to be documented.

Revision 1.70 / (download) - annotate - [select for diffs], Sat May 23 08:51:07 2020 UTC (12 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.69: +5 -0 lines
Diff to previous 1.69 (colored)

pkgtools/pkglint: update to 20.1.8

Changes since 20.1.7:

There are about 300 cases where a package defines a PLIST conditional in
PLIST_VARS but none of its PLIST files actually uses that condition.
These cases get a warning.

Revision 1.69 / (download) - annotate - [select for diffs], Fri May 8 19:50:04 2020 UTC (13 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.68: +3 -1 lines
Diff to previous 1.68 (colored)

pkgtools/pkglint: update to 20.1.4

Changes since 20.1.3:

For patches that patch a single file, the filename of the patch should
correspond to the patched file. There are a few different naming schemes
in action, therefore the check is relatively loose. Patches that are
called patch-[a-z][a-z] continue to be allowed for historic reasons.
Patches that are called patch-CVE-* are also allowed.

The entries in doc/CHANGES-* are checked for consistency. For example,
it doesn't make sense to add a package twice or "update" a package from
version 1.0 to version 1.0. All version numbers in these entries must
be valid pkgsrc versions, i.e. start with a digit and only use
characters from -.0-9A-Z_a-z.

Revision 1.68 / (download) - annotate - [select for diffs], Wed Mar 18 08:24:49 2020 UTC (14 months, 4 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2020Q1-base, pkgsrc-2020Q1
Changes since 1.67: +2 -1 lines
Diff to previous 1.67 (colored)

pkgtools/pkglint: update to 19.4.12

Changes since 19.4.11:

get warnings since they may have been needed in the past but the
dependent package has increased its required version numbers over time.

Revision 1.67 / (download) - annotate - [select for diffs], Sun Mar 15 11:31:24 2020 UTC (15 months ago) by rillig
Branch: MAIN
Changes since 1.66: +15 -11 lines
Diff to previous 1.66 (colored)

pkgtools/pkglint: update to 19.4.11

Changes since 19.4.10:

The use of PKG_OPTIONS and PKG_BUILD_OPTIONS in and other
files is checked for common mistakes.

Checking the indentation of a continuation line no longer crashes in edge

Revision 1.66 / (download) - annotate - [select for diffs], Sat Feb 15 13:48:40 2020 UTC (16 months ago) by rillig
Branch: MAIN
Changes since 1.65: +7 -34 lines
Diff to previous 1.65 (colored)

pkgtools/pkglint: update to 19.4.8

Changes since 19.4.7:

The diagnostic for homepages using FTP is simpler now.

When running pkglint recursively on the top-level directory, the
inter-package checks (distfile hashes, unused licenses) are enabled
implicitly. This way, the only effect of the -Cglobal option is now
whether the pkgsrc infrastructure files are checked as well.

The check for removed packages that have not been recorded in
doc/CHANGES prints the correct lines when pkglint is run with the
--source option.

Fatal technical errors are no longer treated as diagnostics since they
are none. That was an early conceptual mistake, but since these fatal
error didn't happen often, it didn't matter.

In diagnostics, when referring to other lines, the previously used words
before/after have been replaced with above/below to avoid any confusion
whether space or time is meant.

In CONF_FILES, spaces and quotes are allowed.

Fixed unintended side-effects when running pkglint --autofix --only.
Before, all fixes were applied to the file, whether or not they matched
the --only option.

Fixed resolution of relative paths of the form ../../category/package
when they appeared in an infrastructure file.

Lots of refactorings and housekeeping, as usual.

Revision 1.65 / (download) - annotate - [select for diffs], Sat Jan 18 21:56:09 2020 UTC (16 months, 4 weeks ago) by rillig
Branch: MAIN
Changes since 1.64: +3 -0 lines
Diff to previous 1.64 (colored)

pkgtools/pkglint: update to 19.4.4

Changes since 19.4.3:

Packages that still use http in their HOMEPAGE URL generate warnings that
the URL should use https instead.

Revision 1.64 / (download) - annotate - [select for diffs], Mon Jan 6 20:38:42 2020 UTC (17 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.63: +8 -5 lines
Diff to previous 1.63 (colored)

pkgtools/pkglint: update to 19.4.2

Changes since 19.4.1:

Fixed variable resolution. Before, variables that had not been defined
in an included file could still end up in the scope of the package,
which made many of the pkglint checks unreliable.

Each condition that is used in the PLIST should be defined somewhere in
the package Makefile or its included files.

When loading a package Makefile, is loaded implicitly at the
end, just as the pkgsrc infrastructure does in mk/

Revision 1.63 / (download) - annotate - [select for diffs], Sat Jan 4 19:53:14 2020 UTC (17 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.62: +14 -7 lines
Diff to previous 1.62 (colored)

pkgtools/pkglint: update to 19.4.1

Changes since 19.4.0:

The notes for inserting an empty line have been changed from "insert
after this line" to "insert before this line" to make the line numbers
in the diagnostics contiguous. There had been several places where the
diagnostics went from line 1 to line 2 and then back to line 1, which
was confusing.

The lines in ALTERNATIVES files are checked for trailing whitespace.
This is only for consistency with the other checks. In the whole pkgsrc
tree all ALTERNATIVES files are already fine.

The diagnostics for comments in .endif/.endfor lines that don't
correspond to their .if/.elif/.for counterparts now includes the exact
line number of the corresponding condition, to make the warning easier
to fix.

The diagnostics for wrong variable value alignment now mention the
current column in addition to the desired column, to make it easier to
see by how much and in which direction the indentation should be fixed.

Variables that are used in conditions before they are actually defined
need the :U modifier.

Revision 1.62 / (download) - annotate - [select for diffs], Mon Dec 30 16:27:13 2019 UTC (17 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.61: +4 -0 lines
Diff to previous 1.61 (colored)

pkgtools/pkglint: update to 19.4.0

Changes since 19.3.19:

Empty PLIST files now generate an error instead of a warning since there
is no reason for having these empty files.

If a follow-up line in a Makefile is completely empty, there is no note
about trailing whitespace anymore since the warning about the misleading
empty line already covers this case.

The remaining code changes are only refactorings.

Revision 1.61 / (download) - annotate - [select for diffs], Mon Dec 16 17:06:05 2019 UTC (18 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q4-base, pkgsrc-2019Q4
Changes since 1.60: +2 -3 lines
Diff to previous 1.60 (colored)

pkgtools/pkglint: update to 19.3.19

Changes since 19.3.18:

Small improvements to edge cases in SUBST blocks.

Small improvements to edge cases in variable assignment and alignment
of the continuation backslashes.

The --source option shows the changes from autofix, even when the
--show-autofix option is not given. This is a welcome side-effect of
making the autofix logging simpler and more predictable.

Revision 1.60 / (download) - annotate - [select for diffs], Fri Dec 13 01:39:23 2019 UTC (18 months ago) by rillig
Branch: MAIN
Changes since 1.59: +44 -5 lines
Diff to previous 1.59 (colored)

pkgtools/pkglint: update to 19.3.17

Changes since 19.3.16:

Pkglint now handles SUBST blocks correctly, even those in which some of
the variables are defined conditionally. It correctly reports those that
are missing in at least one of the possible branches.

PKG_JVM is no longer marked as deprecated. It was once package-settable.
Since 2002 it is system-provided, and the package-settable counterpart
is PKG_JVM_DEFAULT. This does not fit into pkglint's simple model of
deprecating variables since the variable name is still valid, it should
just not be defined by packages anymore.

The alignment of variable assignments has been fixed in some edge cases.
In continuation lines where the backslash is beyond column 72, the
whitespace before the continuation backslash is fixed to a single space.

Revision 1.59 / (download) - annotate - [select for diffs], Sun Dec 8 22:03:38 2019 UTC (18 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.58: +29 -10 lines
Diff to previous 1.58 (colored)

pkgtools/pkglint: update pkglint to 19.3.15

Changes since 19.3.14:

Invalid lines in PLIST files are now reported as errors instead of
warnings. If pkglint doesn't know about it, it must be an error.

In PLIST files, all paths are validated to be canonical. That is, no
dotdot components, no absolute paths, no extra slashes, no intermediate
dot components.

Fewer notes for unexpanded variable expressions in DESCR files. Before,
the text $@ was reported as possible Makefile variable even though it
was just a Perl expression.

README files are allowed again in pkgsrc package directories. There was
no convincing argument why these should be forbidden.

A few diagnostics have been changed from NOTE to WARNING or from WARNING
to ERROR, to match their wording.

When pkglint suggests to replace :M with ==, the wording is now "can be
made" instead of "should".

Revision 1.58 / (download) - annotate - [select for diffs], Sun Dec 8 00:06:38 2019 UTC (18 months, 1 week ago) by rillig
Branch: MAIN
Changes since 1.57: +101 -19 lines
Diff to previous 1.57 (colored)

pkgtools/pkglint: update to 19.3.14

Changes since 19.3.13:

When pkglint suggests to replace !empty(VARNAME:Mfixed) with ${VARNAME}
== fixed, the exact suggested expression is now part of the diagnostic.
The check and the autofix have been improved. They now apply only to the
last modifier in the whole chain, everything else was a bug in pkglint.

Pkglint now knows the scope of variables better than before. It knows
the difference between variables from <> like MACHINE_ARCH, which
are always in scope, and those from mk/defaults/mk.conf, which only come
into scope later, after has been included. It warns when
variables are used too early, for example in .if conditions.

The pathnames in ALTERNATIVES files are now checked for absolute
pathnames. This mistake doesn't happen in practice, but the code for
converting the different path types internally made it necessary to add
these checks. At least this prevents typos.

The special check for obsolete licenses has been removed since their
license files have been removed and that is checked as well.

Variables named *_AWK may be appended to.

The variables _PKG_SILENT and _PKG_DEBUG are no longer deprecated, they
are obsolete now. They are not used in main pkgsrc and pkgsrc-wip

When a package sets a default value for a user-settable variable (which
is something that should not happen anyway), it should .include before, in order to not accidentally overwrite the
user-specified value.

Variable modifiers of the form :from=to are now parsed like in bmake.
They are greedy and eat up any following colons as well. This means that
${VAR:.c=.o:Q} replaces source.c with source.o:Q, instead of quoting it.
Pkglint now warns about such cases.

The handling of relative paths in diagnostics is now consistent. All
paths that are part of a diagnostic are relative to the line that issues
the diagnostic.

Fatal errors are no longer suppressed in --autofix mode.

Plus lots of refactoring, to prevent accidental mixing of incompatible
relative paths.

Revision 1.57 / (download) - annotate - [select for diffs], Mon Dec 2 23:32:09 2019 UTC (18 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.56: +122 -82 lines
Diff to previous 1.56 (colored)

pkgtools/pkglint: update to 19.3.13

Changes since 19.3.12:

The command line option -Wspace has been removed. Warnings and notes
about whitespace are now generated by default and cannot be switched
off. This is to ensure a consistent visual appearance of the package

Shell programs that are indented unnecessarily deep generate a note by
default now. Before, the option -Wall was necessary to get these notes.

The check for unintended comments in multi-line shell programs is now
enabled again. It had been disabled some time ago as byproduct of a bug
fix in the shell parser.

The check for unique buildlink3 package identifiers now also works if
pkglint is run from a package directory instead of the pkgsrc root

Revision 1.56 / (download) - annotate - [select for diffs], Wed Nov 27 22:10:07 2019 UTC (18 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.55: +48 -22 lines
Diff to previous 1.55 (colored)

pkgtools/pkglint: update to 19.3.11

Changes since 19.3.10:

The check for files that are included conditionally in one
place and unconditionally in another place have been refined. Now they
also work in cases that do not involve any variables, such as when the
condition is a mere exists(filename).

References to variables that use parentheses instead of the usual braces
produce a warning now, even if pkglint cannot fix them automatically.
This affects only a few instances where more than one such variable
reference appeared in a single line.

The --log-verbose command line option has been removed since it does not
have any practical use other than improving the performance during
pkglint development itself. Because of that it hadn't even been
mentioned in the manual page.

Warnings for missing license files now report the path to the license
file relative to the line where the warning occurs, like everywhere

Revision 1.55 / (download) - annotate - [select for diffs], Sat Nov 23 23:35:56 2019 UTC (18 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.54: +71 -72 lines
Diff to previous 1.54 (colored)

pkgtools/pkglint: update to 19.3.10

Changes since 19.3.9:

In diagnostics for suggested package updates, the exact line of doc/TODO
is mentioned. If a suggested update has an additional comment, the
brackets around that comment are not output anymore.

The check for defined but not used variables has been improved for the
edge case of defining a variable in the package Makefile and using it
in the file of the same package, which just doesn't work.

Makefile fragments in patches/ directories are now completely ignored.
It was a hypothetical case anyway.

Comparing PKGSRC_COMPILER using the == or != operators is now considered
an error instead of a warning. The common cases can be autofixed.

Revision 1.54 / (download) - annotate - [select for diffs], Sun Nov 17 01:26:25 2019 UTC (19 months ago) by rillig
Branch: MAIN
Changes since 1.53: +9 -12 lines
Diff to previous 1.53 (colored)

pkgtools/pkglint: update to 19.3.7

Changes since 19.3.6:

Improved variable value alignment.

Fixed wrong warning about comment lines that were interpreted as shell
commands before.

Warn when the first category of a package doesn't correspond to the
path in the filesystem. This affects 603 packages.

No longer warn about deprecated BUILDLINK_TRANSFORM.${OPSYS}. The
deprecation warning was meant for BUILDLINK_TRANSFORM.${pkgbase}, but
since pkglint cannot distinguish between these, the warnings were wrong.

Revision 1.53 / (download) - annotate - [select for diffs], Sat Nov 2 16:37:48 2019 UTC (19 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.52: +2 -0 lines
Diff to previous 1.52 (colored)

pkgtools/pkglint: update to 19.3.5

Changes since 19.3.4:

Variable uses in parentheses (such as $(VAR) instead of ${VAR}) are
treated the same. The ones in parentheses had less support before.

Improved the checks for files, adding support for options
that are defined using .for loops and those referring to other

Packages that set DISTFILES to an empty list no longer require a
distinfo file.

Patches whose filename contains the word CVE may patch more than one
target file.

Revision 1.52 / (download) - annotate - [select for diffs], Fri Nov 1 19:56:53 2019 UTC (19 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.51: +3 -0 lines
Diff to previous 1.51 (colored)

pkgtools/pkglint: update to 19.3.4

Changes since 19.3.3:

In cases where the conditions for including files differ
between the package itself and its own file, explain how
to determine PKG_OPTIONS for dependencies.

Don't issue wrong warnings in files when the options are
handled in a .for loop.

Revision 1.51 / (download) - annotate - [select for diffs], Sat Oct 26 11:43:36 2019 UTC (19 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.50: +8 -2 lines
Diff to previous 1.50 (colored)

pkgtools/pkglint: update to 19.3.3

Changes since 19.3.2:

The rationale for variables like BROKEN, GCC_REQD and for direct
inclusion of files may span multiple lines, and it may end
with an empty comment line.

Revision 1.50 / (download) - annotate - [select for diffs], Sat Oct 26 09:51:48 2019 UTC (19 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.49: +1 -1 lines
Diff to previous 1.49 (colored)

pkgtools/pkglint: update to 19.3.2

Changes since 19.3.1:

* Pkglint no longer warns about a missing :Q modifier if there is also
  a :D modifier, since the latter hides the original variable value
  from the expression value.

* Variable names like .CURDIR are now allowed in the _VARGROUPS section.

* In dependency lines like "${_COOKIE.extract}:", pkglint no longer
  warns about the unknown target. No matter whether this is a file name
  or even a list of other targets, there's no chance for a typo here.

* If some dependencies are included conditionally, and the package
  Makefile and disagree, and the conditions depend on
  PKG_OPTIONS, pkglint outputs a helpful explanation.

* The check for including directly can be disabled by giving
  a reason in a comment at the end of the line.

Revision 1.49 / (download) - annotate - [select for diffs], Tue Oct 1 21:37:59 2019 UTC (20 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.48: +14 -2 lines
Diff to previous 1.48 (colored)

pkgtools/pkglint: update to 19.3.0

Changes since 5.7.24:

* There is no need to ask the dummy MAINTAINER from url2pkg whether
  committing changes is ok.

* When autofixing a condition like !empty(PKGPATH:Mliteral), don't
  generate unnecessary parentheses around ${PKGPATH} == literal.

* In a _VARGROUPS section, the public variables should be listed
  before the private variables, to put important things first.

* When pkglint suggests to be run again with the -e, -fs or -F options,
  repeat the whole command line, to allow for copy-and-paste.

* The checks for PKGPATH are fixed and enhanced. It is not a relative
  path like in ../../category/package, but relative to the pkgsrc root.

* Unintended file globbing in sed commands such as s,.*,any, gets a

* MASTER_SITES should normally end with a slash, in rare cases an
  equals sign or a colon are correct, too.

* Detect redundant directories in INSTALLATION_DIRS.

Revision 1.48 / (download) - annotate - [select for diffs], Sun Aug 25 21:44:37 2019 UTC (21 months, 3 weeks ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q3-base, pkgsrc-2019Q3
Changes since 1.47: +2 -2 lines
Diff to previous 1.47 (colored)

pkgtools/pkglint: update to 5.7.22

Changes since 5.7.21:

* The files from wip/mk do not belong to the main pkgsrc infrastructure.
  Therefore, when loading the package Makefile to look for defined but
  unused variables, parsing doesn't stop in these files.

Revision 1.47 / (download) - annotate - [select for diffs], Wed Aug 21 16:45:17 2019 UTC (21 months, 3 weeks ago) by rillig
Branch: MAIN
Changes since 1.46: +12 -0 lines
Diff to previous 1.46 (colored)

pkgtools/pkglint: update to 5.7.21

Changes since 5.7.20:

* PKG_OPTIONS that are handled using patterns are correctly identified.

* Simple R packages should follow the canonical variable order.

* Fixed some edge cases for aligning variable assignments.

* Improved detection of allowed values for USE_LANGUAGES.

Revision 1.46 / (download) - annotate - [select for diffs], Tue Jul 30 18:16:13 2019 UTC (22 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.45: +12 -4 lines
Diff to previous 1.45 (colored)

pkgtools/pkglint: update to 5.7.17

Changes since 5.7.16:

* The warnings for doc/CHANGES are only enabled when the -Cglobal option
  is given. This is to avoid warnings that are unrelated to the package
  that is being checked.

Revision 1.45 / (download) - annotate - [select for diffs], Sun Jul 14 21:25:47 2019 UTC (23 months ago) by rillig
Branch: MAIN
Changes since 1.44: +24 -13 lines
Diff to previous 1.44 (colored)

pkgtools/pkglint: update to 5.7.16

Changes since 5.7.15:

* Completely rewrote the code for aligning multiple variable assignment
  lines. It works on the actual lines of the file now instead of the
  parsed lines. This provides more exact diagnostics and also makes the
  handling of these lines easier so that future requirements can be
  implemented more easily.

* Added support for exotic conditions in .if clauses. These conditions
  are not seen in the wild though.

* Fixed wrong diagnostics for ALTERNATIVES files that appear
  conditionally in the PLIST.

* As always: lots of refactorings and newly added tests.

Revision 1.44 / (download) - annotate - [select for diffs], Sun Jun 30 20:56:19 2019 UTC (23 months, 2 weeks ago) by rillig
Branch: MAIN
Changes since 1.43: +94 -65 lines
Diff to previous 1.43 (colored)

pkgtools/pkglint: update to 5.7.14

Changes since 5.7.13:

- Removed the -Cextra command line option since it didn't produce useful

- Removed unwarranted warnings about _WRAP_EXTRA_ARGS.CC being used in

- Cleaned up the canonical order of variables in package Makefiles.

- Added a few commands to those that cannot fail, to reduce the number of
  "at the left of the | operator" in shell programs.

- Fixed warnings about "-ggdb" being an unknown shell command.

- Reduced number of warnings about lists being used where a single value
  is expected.

- Replaced unreliable check for invalid CFLAGS and LDFLAGS with a more
  practical check.

- Renamed "RCS tag" to "CVS tag" to make the diagnostics more modern.

- Added warning when PKGNAME or PKGVERSION is used in MASTER_SITES.

- Reworded warning for missing or superfluous PLIST files.

- Lots of other detail changes, refactorings and automatic tests.

Revision 1.43 / (download) - annotate - [select for diffs], Mon Jun 10 19:51:57 2019 UTC (2 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q2-base, pkgsrc-2019Q2
Changes since 1.42: +17 -16 lines
Diff to previous 1.42 (colored)

pkgtools/pkglint: updated to 5.7.13

Changes since 5.7.12:

* Fixed a warning in the variable permissions that previously said "this
  variable should not be used at load time in this file, it would be ok
  in .", with an empty list of alternative files.

* Lots of refactoring and new tests.

Revision 1.42 / (download) - annotate - [select for diffs], Tue May 21 17:59:48 2019 UTC (2 years ago) by rillig
Branch: MAIN
Changes since 1.41: +95 -22 lines
Diff to previous 1.41 (colored)

pkgtools/pkglint: update to 5.7.10

Changes since 5.7.9:

* Fixed URL checking for MASTER_SITES, especially remove the wrong error
  message about URLs of the form ${MASTER_SITE:S,^,-,:=subdir/}.

* Made warnings about invalid filenames, filename patterns, pathnames and
  pathname patterns more detailed.

Revision 1.41 / (download) - annotate - [select for diffs], Mon May 6 20:27:17 2019 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.40: +18 -1 lines
Diff to previous 1.40 (colored)

pkgtools/pkglint: update to 5.7.9

Changes since 5.7.8:

* files are checked for typos in the identifier that is
  used for BUILDLINK_TREE, to detect copy-and-paste mistakes.

* Having a rationale is recommended for some variables, especially those
  that make a package fail to build or crash at runtime. This check is
  only active when -Wextra is given, since it is still actively debated
  whether such a check is actually useful.

* Files called Makefile.php can easily be mistaken to be PHP files.
  Therefore the recommended naming convention is to have auxiliary files
  called *.mk. There are already many more files called *.mk than those
  being called Makefile.*.

* The check for unquoted sed substitution commands has been made more
  detailed, but since it is completely disabled, there's nothing to see
  for now.

* The definitions for MASTER_SITE_* are loaded directly from the pkgsrc
  infrastructure instead of hard-coding them in pkglint.

Revision 1.40 / (download) - annotate - [select for diffs], Sat Apr 27 19:33:57 2019 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.39: +48 -3 lines
Diff to previous 1.39 (colored)

pkgtools/pkglint: update to 5.7.7

Changes since 5.7.6:

Warn about packages that override user-settable variables. Packages that
define variables with the same value as the default value only get a
note instead of the warning since these definitions do not cause any

Do not suppress technical error messages in autofix mode.

Do not warn about the package version being greater than the latest from
doc/CHANGES if the file defining the package version has been modified
locally and is about to be committed.

Revision 1.39 / (download) - annotate - [select for diffs], Tue Apr 23 21:20:49 2019 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.38: +15 -2 lines
Diff to previous 1.38 (colored)

pkgtools/pkglint: update to 5.7.6

Changes since 5.7.5:

* The explanation for distfile hashes is only given when the distfiles
  actually need to be downloaded. If they are already there, no
  explanation is necessary.

* Makefile lines that are commented and have line continuations are
  properly parsed. This affects the autofix for variable value

* Variable permissions are not checked in since pkgsrc
  developers who know about probably know what they are doing.
  From files, files may be included directly, for
  the same reason.

* Expressions of the form !empty(PKGPATH:Mpattern), when PKGPATH is not
  a list variable and pattern has no wildcards, can be written in a
  simpler form, and pkglint autofixes this. For example the above
  expression is transformed into ${PKGPATH} == pattern. This
  transformation reduces the amount of double negations (!empty) in the

* Duplicate warnings about invalid relative ../package have been merged.

* TOOLS_ALIASES are properly resolved. The line USE_TOOLS=ggrep makes
  the tools grep, egrep and fgrep known to pkglint, in the same way as
  in the pkgsrc infrastructure.

* The diagnostics for missing or unnecessary distinfo files have been
  improved to provide some guidance.

* Packages that use MESSAGE_SRC to build the message from multiple files
  no longer produce a warning for malformed message files. These files
  are simply skipped.

Revision 1.38 / (download) - annotate - [select for diffs], Sat Apr 20 17:43:24 2019 UTC (2 years, 1 month ago) by rillig
Branch: MAIN
Changes since 1.37: +64 -8 lines
Diff to previous 1.37 (colored)

pkgtools/pkglint: update to 5.7.5

Changes since 5.7.4:

* Warn about invalid variable uses in directives like
  .if and .for

* Do not warn when a package-settable variable is assigned using the ?=
  operator before including This warning only makes sense
  for user-settable and system-provided variables.

* The parser for variable uses like ${VAR:@v@${v:Q}} is more robust now,
  which reduces the number of parse errors and leads to more appropriate
  diagnostics, in cases like ${URL:Mftp://*}, which should really be

* The valid values for OPSYS are now determined by the files in
  mk/platform instead of allowing arbitrary identifiers. This catches a
  few instances where "Solaris" is used instead of the correct "SunOS".

* Setting USE_LANGUAGES only has an effect if mk/ has not yet
  been included. In all other cases, pkglint warns now.

* Missing entries in doc/CHANGES produce a note now. This will lead to
  more accurate statistics for the release notes.

Revision 1.37 / (download) - annotate - [select for diffs], Wed Apr 3 21:49:51 2019 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
Changes since 1.36: +45 -11 lines
Diff to previous 1.36 (colored)

pkgtools/pkglint: update to 5.7.4

Changes since 5.7.3:

* Warn about dependency patterns that are missing a version number,
  such as ${PYPKGPREFIX}-sqlite3:../../databases/py-sqlite3.

* Suggest to replace the := assignment operator with the :sh modifier,
  in some cases where the variable is not obviously used at load time.

Revision 1.36 / (download) - annotate - [select for diffs], Sun Mar 24 13:58:38 2019 UTC (2 years, 2 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2019Q1-base, pkgsrc-2019Q1
Changes since 1.35: +20 -10 lines
Diff to previous 1.35 (colored)

pkgtools/pkglint: update to 5.7.3

Changes since 5.7.2:

PLIST files are checked for non-ASCII characters. Even though pkgsrc
sets up the environment with LC_ALL=C, there are still some cases
of encoding errors. The case discussed on the tech-pkg mailing list
was lang/go112.

The checks for variable permissions ("may not be set in this file")
have been reworked completely. Many of the variable permissions had
different rules for Makefile and Makefile.common. These different
rules tried to prevent accidental overwriting of variables. Starting
in July 2018, pkglint got a check for redundant variables that is
far more accurate than the previous variable permissions. Therefore
these fine-grained permissions are no longer necessary. This removes
a few hundred wrong warnings about insufficient permissions.

The check that adds missing SHA512 hashes to distinfo files has been
fixed to work correctly in DIST_SUBDIR cases.

Improved the checks regarding tools that are used by a package but
not added to USE_TOOLS. For example, the "make" tool is always
available, as are all tools that are added to TOOLS_CREATE.

Lots of small improvements, as always.

Revision 1.35 / (download) - annotate - [select for diffs], Sun Mar 10 19:01:50 2019 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.34: +118 -6 lines
Diff to previous 1.34 (colored)

pkgtools/pkglint: update to 5.7.2

Changes since 5.7.1:

* Fixed detection of GNU_CONFIGURE=yes combined with USE_LANGUAGES
  missing c. This combination tends to fail in the configure phase.

* When the distinfo doesn't contain all hashes for the downloaded
  distfiles (typically SHA512 is missing) and the distfiles are actually
  downloaded to ${PKGSRCDIR}/distfiles, pkglint can now add the missing
  hashes. It only does this if there is at least one existing hash
  and if all existing hashes are correct.

* The check for redundant variables has been improved considerably.
  Before there were several situations in which pkglint didn't get the
  redundant variable definitions right because its internal model only
  mimicked reality. The model has been improved and so have the

* Pkglint only warns about wrong permissions (for defining or using
  a variable) when it knows the type of the variable and the permissions
  for the current file. Before, it had also warned if the permissions
  for the current file were not explicitly defined.

* CFLAGS and LDFLAGS may be appended in files. This
  had been disallowed before, for no apparent reason. There are several
  places in pkgsrc where especially CFLAGS.${OPSYS} is appended to.

* Cleaned up internal handling of relative paths. Previously pkglint
  sometimes resolved relative paths using the wrong base directory,
  which led to all kinds of wrong warnings and strange behavior.

* Fixed lots of edge cases when parsing Makefile lines. These cases
  don't occur often but experience tells that the most fundamental code
  must be as correct as possible (see the handling of relative paths

* Lots of refactoring and housekeeping, as always.

Revision 1.34 / (download) - annotate - [select for diffs], Thu Feb 21 22:49:03 2019 UTC (2 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.33: +13 -5 lines
Diff to previous 1.33 (colored)

pkgtools/pkglint: update to 5.7.0

Changes since 5.6.12:

* Many of the -C and -W command line options have been removed since
  they are not used in practice. The -Wall and -Call options continue
  to work though; these are the only options mentioned in the pkgsrc

* When a PLIST file contains redundant libtool libraries (.la and the
  corresponding .so), there is only a single warning per file.

* Warnings about the package COMMENT are now strictly ordered from left
  to right.

* The hashes for all distfiles must now contain the SHA512 hash. This
  hash has been added to many distfiles in 2015. It's time now to
  enforce it on all other distfiles as well.

* Makefile fragments that are included inside an .elif exists(...)
  are not reported as missing.

* The check for redundant variables and accidentally overwritten
  variables has been improved. Now the warning occurs at the later
  definition. This especially applies to cases where a file is included
  and after that, some of its variables are overridden. Variables in
  unrelated files are no longer marked as redundant.

* When a package contains multiple definitions of a single variable
  (typical for Makefile.common), the later definition overrides the
  earlier definition. That way, the location of DISTINFO_FILE and
  PATCHDIR is resolved correctly.

Revision 1.33 / (download) - annotate - [select for diffs], Sat Jan 26 16:31:33 2019 UTC (2 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.32: +25 -9 lines
Diff to previous 1.32 (colored)

pkgtools/pkglint: update to 5.6.12

Changes since 5.6.11:

* In files, print the paths relative
  to the line, not to the pkgsrc root.

* When explaining that a variable cannot be set/used because of wrong
  permissions, list the permissions. This provides more transparency
  than just stating that the desired action is not allowed.

* When pkglint checks a pkgsrc-wip package, don't warn about malformed
  lines in doc/CHANGES-* since pkgsrc-wip users typically cannot do
  anything about these errors.

* In profiling mode, not only the code coverage and the performance
  statistics are dumped, the whole heap is also dumped to see which
  parts of pkglint consume the most heap memory. Pkglint now needs
  less heap memory than before, which mainly affects full scans.

* The checks for absolute pathnames have gone. They were of questionable
  value since pkglint has failed to give proper advice on how to fix
  them properly, at least for the last 12 years.

* The check that pkgsrc-wip packages should only use exact CVS Ids
  (the unexpanded variant) has been disabled again. It occurred about
  16000 times but even fixing it wouldn't improve anything since it
  was mostly a formatting issue without any practical consequences.

* Warn about trailing variable modifiers like in ${VAR:S,from,to,extra}.

* Properly parse ${VAR:!command!}.

* Suggest to replace SUBST_SED with SUBST_VARS where possible, even
  with complicated shell quoting. Pkglint can autofix most of these
  overly verbose cases.

* Load whenever the corresponding file is
  included. This fixes several warnings about undefined variables
  (especially for packages using OpenSSL).

* Parse .for lines like bmake does since 2015, splitting words like
  in brk_string.

* Optionally show a warning even if it cannot be autofixed by pkglint.
  This is useful for the SUBST_VARS replacement since even when
  pkglint cannot automatically replace the code, there are still cases
  where it can warn at least.

* As always, several refactorings.

Revision 1.32 / (download) - annotate - [select for diffs], Sun Jan 13 19:55:52 2019 UTC (2 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.31: +35 -35 lines
Diff to previous 1.31 (colored)

pkgtools/pkglint: update to 5.6.11

Changes since 5.6.10:

* Improved the wording of several warnings

* Fixed parsing of complicated dependency patterns such as
  {ssh{,6}-[0-9]*,openssh-[0-9]*}. Pkglint still doesn't understand
  them but at least it doesn't mark them as "unknown" anymore.

* Lots of refactoring, as usual. This is the last part of the big
  refactoring, therefore future changes to pkglint are expected to be
  smaller than in the previous 3 months.

Revision 1.31 / (download) - annotate - [select for diffs], Fri Dec 21 08:05:24 2018 UTC (2 years, 5 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q4-base, pkgsrc-2018Q4
Changes since 1.30: +1 -1 lines
Diff to previous 1.30 (colored)

pkgtools/pkglint: update to 5.6.10

Changes since 5.6.9:

* ALTERNATIVES files are correctly checked now. Before, pkglint had
  suggested to remove the @PREFIX/ from the alternative, which was
  wrong and simply didn't work.

* Diagnostics about variable assignments are ordered to report the
  left-hand side first and then everything to the right of the
  assignment operator.

* The pkglint output is escaped properly to avoid sending unwanted
  escape sequences to the terminal.

* The items in .for loops are parsed taking "double" and 'single'
  quotes into account since bmake does it in the same way since 2015.

* In DESCR files, overly long lines are only warned about if they
  contain a space and therefore can be made shorter.

* In DESCR files, text like ${PREFIX} only gets a note if it refers
  to a commonly known pkgsrc variable. This avoids distraction when
  a package mentions ${prefix}/bin or ${}.

* Lots of refactorings and small changes.

Revision 1.30 / (download) - annotate - [select for diffs], Mon Dec 17 00:15:39 2018 UTC (2 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.29: +10 -4 lines
Diff to previous 1.29 (colored)

pkgtools/pkglint: update to 5.6.9

Changes since 5.6.8:

* In addition to the pkglint binary, the whole pkglint code is installed as
  a library, so that other packages can use the code for doing their own
  checks on pkgsrc packages, Makefiles, shell programs, or the other file
  types from pkgsrc.

* BUILDLINK_*.* may be used in all files.

* Lots of refactorings

Revision 1.29 / (download) - annotate - [select for diffs], Sun Dec 2 01:57:48 2018 UTC (2 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.28: +69 -41 lines
Diff to previous 1.28 (colored)

pkgtools/pkglint: update to 5.6.7

Changes since 5.6.6:

User-defined variables that are not yet added to BUILD_DEFS are only
reported once per file.

Unnecessary space after variable names is only worth a note instead of
a warning. Example:

        MASTER_SITES =

All variable names that are defined in the pkgsrc infrastructure are
assumed to be available to the package Makefiles. This reduces the
number of wrong "used but not defined" warnings, at the expense of

Variable names that are used in other variable names are checked
whether they are defined somewhere. Example:

        CFLAGS+=        ${CFLAGS.${PARAM}}      # PARAM is now checked

In SUBST_SED, when the pattern is s,@VAR@,${VAR}, or a slight variant
thereof, pkglint suggests to define SUBST_VARS instead, which frees the
package author from thinking about how to escape special characters and
is generally easier to read. Example:

        SUBST_SED.class=        s,@VAR@,${VAR:Q},

        SUBST_VARS.class=       VAR

Directives like .if !defined(...) are now handled the same whether or
not there is a space after before the (...).

The check for locally modified files now works independently of the

As always, lots of refactorings have happened under the hood. Many small
bugs have been discovered and fixed accordingly.

Revision 1.28 / (download) - annotate - [select for diffs], Wed Nov 7 20:58:23 2018 UTC (2 years, 7 months ago) by rillig
Branch: MAIN
Changes since 1.27: +215 -128 lines
Diff to previous 1.27 (colored)

pkgtools/pkglint: update to 5.6.6

Changes since 5.6.5:

- Removed plist-clash since it had crashed unconditionally whenever it
  was called. This means that in the last 3 years, nobody can have
  used it in the originally intended way.

- Fixed interactions between the --source, --explain, --show-autofix,
  --autofix and --only options.

- Fixed "defined but not used" and "used but not defined" for variables
  from the pkgsrc infrastructure.

- Lots of small fixes and improvements found by the large pkglint code
  review (12% done).

Revision 1.27 / (download) - annotate - [select for diffs], Tue Oct 9 19:12:13 2018 UTC (2 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.26: +5 -13 lines
Diff to previous 1.26 (colored)

pkgtools/pkglint: update to 5.6.4

Changes since 5.6.3:

* Allow += for COMMENT

* Sync variable type definitions with reality

* Fix check for "used but not defined" variables. This check had been
  broken since pkgtools/pkglint/files/ r1.776 from 2008-10-18
  (3cd071958e63), which missed its 10-year anniversary by just 9 days.

  After fixing this check, pkglint produces about 800 new warnings
  spread all over pkgsrc, most of which are real typos.

* Detect used variables also in .if and .elif conditions. This is
  closely related to the above fix and reduces the number of "defined
  but not used" variables, while at the same time producing new warnings
  because these variables are used at load time, where some of these
  variables are not yet defined.

* Detect variables for which pkglint doesn't know the exact data type
  by scanning all files under mk/ at startup. Currently there are about
  470 of these variables. No "used but not defined" warnings are issued
  for these variables anymore.

* To speed up pkglint when checking the whole pkgsrc tree at once, the
  most often needed files are cached to reduce IO load. The checks for
  USE_TOOLS are optimized now since they were a major bottleneck.
  Together with other performance improvements this makes pkglint about
  50% faster when checking the whole pkgsrc tree including pkgsrc-wip.

Revision 1.26 / (download) - annotate - [select for diffs], Wed Oct 3 22:27:53 2018 UTC (2 years, 8 months ago) by rillig
Branch: MAIN
Changes since 1.25: +108 -7 lines
Diff to previous 1.25 (colored)

pkgtools/pkglint: Update to 5.6.3

Changes since 5.6.2:

* Add check for version patterns 1.5*, which should rather be 1.5.*

* Re-enable check for "set -e" and commands that may silently fail
  because of missing error checking

* Lots of internal clean-up and tests

Revision 1.25 / (download) - annotate - [select for diffs], Wed Sep 5 17:56:22 2018 UTC (2 years, 9 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q3-base, pkgsrc-2018Q3
Changes since 1.24: +76 -33 lines
Diff to previous 1.24 (colored)

pkgtools/pkglint: update to 5.6.2

Changes since 5.6.1:

* Improved checks that depend on whether is included or

* Improved checks for tools, whether they may be used at load time
  or at run time.

* Improved tokenizer for shell commands. $| is not a variable but a
  dollar followed by a pipe.

* Warnings about SUBST context are now shown by default.

* A warning is shown when a SUBST block is declared for *-configure
  but the package has defined USE_CONFIGURE=no.

* Don't warn about USE_TOOLS:= ${USE_TOOLS:Ntool}.

* Don't warn about using the ?= operator in files before
  including (for some more variables, but not all).

* Report an error for packages from main pkgsrc that have a TODO or
  README file. Packages should be simple enough that they don't need
  a README file and ready for production so that they don't need a TODO.

* Lots of small bug fixes and new tests.

Revision 1.24 / (download) - annotate - [select for diffs], Thu Aug 16 20:41:42 2018 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.23: +92 -20 lines
Diff to previous 1.23 (colored)

pkgtools/pkglint: update to 5.6.1

Changes since 5.6.0:

* Fix output of relative paths in the diagnostics (thanks @wiz)
* Fix parsing of ${VAR:ts---}; it is now a syntax error
* Load more type definitions from mk/* instead of hard-coding them
* Lots of refactoring to improve test coverage, fixing several
  small bugs as they were found

Revision 1.23 / (download) - annotate - [select for diffs], Sun Aug 12 16:31:56 2018 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.22: +61 -23 lines
Diff to previous 1.22 (colored)

pkgtools/pkglint: update to 5.6.0

Changes since 5.5.16:

* Check for negated shell commands (if ! test -z "foo"); they are not
  supported by Solaris.

* Don't check variable permissions for infrastructure files. A warning
  like "may not be set by any package" doesn't make sense for them.

* Check that PLIST_VARS matches PLIST.*, which is especially useful in files.

* Improve checks for files (for PKG_OPTIONS_SET).

* Prefer options handling with !empty() over checking empty() first.

* Prefer ${MACHINE_ARCH} == i386 over !empty(MACHINE_ARCH:Mi386), for
  single-valued variables.

Revision 1.22 / (download) - annotate - [select for diffs], Thu Aug 9 20:08:12 2018 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.21: +3 -2 lines
Diff to previous 1.21 (colored)

pkgtools/pkglint: Update to 5.5.16

Changes since 5.5.15:

* Add checks for files

* Treat redundant variable definitions as notes, not as warnings

* Check doc/CHANGES-* for typos in the dates (only for 2018 and later)

* Lots of cleanup in the test code

Revision 1.21 / (download) - annotate - [select for diffs], Sat Jul 28 18:31:23 2018 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.20: +5 -3 lines
Diff to previous 1.20 (colored)

pkgtools/pkglint: update to 5.5.15

Changes since 5.5.14:

* Check that the comments in .endif and .endfor lines match the
  corresponding conditions.

* Check for redundant variables (e.g. MASTER_SITES for R packages).

* Check for accidentally overwritten variables.

* Miscellaneous code cleanup and refactoring.

Revision 1.20 / (download) - annotate - [select for diffs], Thu Jul 19 06:38:15 2018 UTC (2 years, 10 months ago) by rillig
Branch: MAIN
Changes since 1.19: +10 -1 lines
Diff to previous 1.19 (colored)

pkgtools/pkglint: updated to 5.5.14

Changes since 5.5.13:

* Suppress duplicate warnings for unknown options in the same file

* Grab acceptable package versions directly from the infrastructure files

* Note about too deeply indented shell programs

Revision 1.19 / (download) - annotate - [select for diffs], Sat Mar 24 14:32:49 2018 UTC (3 years, 2 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2018Q2-base, pkgsrc-2018Q2, pkgsrc-2018Q1-base, pkgsrc-2018Q1
Changes since 1.18: +11 -4 lines
Diff to previous 1.18 (colored)

Update pkglint to 5.5.7

Changes since 5.5.6:

* When pkglint warns about files that are accidentally executable, it
  offers to fix the file permissions.

* Warn about ${HOMEPAGE:=repository/}, since the := modifier should
  only be used with MASTER_SITES.

* When the distinfo file is missing, suggest setting NO_CHECKSUM.

* Several refactorings.

Revision 1.18 / (download) - annotate - [select for diffs], Sun Mar 4 20:34:33 2018 UTC (3 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)

pkgtools/pkglint: update to 5.5.6

Changes since 5.5.5:

* Only offer explanations if an explainable diagnostic has actually
  been logged.

* Clean up code.

* Improve a few diagnostics.

* In any Makefile, treat documented variables as used. This prevents
  warning about defined but unused variables.

* Add support for some variables not previously known to pkglint.

Revision 1.17 / (download) - annotate - [select for diffs], Mon Feb 19 12:40:38 2018 UTC (3 years, 3 months ago) by rillig
Branch: MAIN
Changes since 1.16: +12 -8 lines
Diff to previous 1.16 (colored)

pkgtools/pkglint: update to 5.5.5

Changes since 5.5.3:

- Removed check for PERL5_PACKLIST, since it was not fixable by the
  package author.

- Completely rewrote the check for ordering variables in simple
  package Makefiles. Now it reports the variables in the correct order
  instead of just saying "this above that" for a few variables.

- Lots of code cleanup and documentation.

Revision 1.16 / (download) - annotate - [select for diffs], Sat Jan 27 18:50:36 2018 UTC (3 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.15: +183 -115 lines
Diff to previous 1.15 (colored)

pkgtools/pkglint: Update to 5.5.2

Changes since 5.5.1:

* Fixed command line parsing for the --only option.
* Improved alignment of variable values in Makefiles.
* Code cleanup: better abstraction in the tests.

Revision 1.15 / (download) - annotate - [select for diffs], Sat Jan 13 23:56:14 2018 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.14: +70 -37 lines
Diff to previous 1.14 (colored)

pkglint: Update to 5.5.1

Changes since 5.5:

* Allow filtering log messages by keyword (--only)
* In --autofix and --show-autofix mode, show only fixable diagnostics
* When called with --source, show the source below the diagnostics
* Don't warn about USE_LANGUAGES in ../../mk/
* Fix autofix for .gz in PLIST

Revision 1.14 / (download) - annotate - [select for diffs], Mon Jan 1 18:04:15 2018 UTC (3 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.13: +3 -4 lines
Diff to previous 1.13 (colored)

Updated pkglint to 5.4.22.

Changes since 5.4.21:
* Refactoring: moved packages line and linechecks back into main
* Fixed panic when autofixing package Makefiles
* Removed apache22
* Added a bit of inline documentation

Revision 1.13 / (download) - annotate - [select for diffs], Sun Jan 29 14:27:48 2017 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2017Q4-base, pkgsrc-2017Q4, pkgsrc-2017Q3-base, pkgsrc-2017Q3, pkgsrc-2017Q2-base, pkgsrc-2017Q2, pkgsrc-2017Q1-base, pkgsrc-2017Q1
Changes since 1.12: +15 -2 lines
Diff to previous 1.12 (colored)

Refactored the code into separate packages. No functional changes.

Revision 1.12 / (download) - annotate - [select for diffs], Tue Jan 17 22:37:27 2017 UTC (4 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.11: +11 -7 lines
Diff to previous 1.11 (colored)

Updated pkglint to 5.4.16.

Changes since 5.4.15:

* updated vardefs from mk/defaults/mk.conf from v1.118 (2006) to v1.269

* fixed license parsing to be more realistic
  (the previous version didn't handle parentheses correctly)

* lots of housekeeping
  * moved some code to separate packages, allowing re-use
  * separated Line checks into LineChecker type
  * separated MkLine checks into MkLineChecker type
  * made Line an interface, for further refactorings

Revision 1.11 / (download) - annotate - [select for diffs], Tue Dec 13 00:58:07 2016 UTC (4 years, 6 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q4-base, pkgsrc-2016Q4
Changes since 1.10: +37 -12 lines
Diff to previous 1.10 (colored)

Updated pkglint to 5.4.13.

Changes since 5.4.12:

* Added check for unintended # comments, especially in HOMEPAGE
* Added check for quotes in COMMENT
* Fixed hardcoded package versions for PHP, Python, Lua, etc.
* Code cleanup in the tests

Revision 1.10 / (download) - annotate - [select for diffs], Thu Jul 7 12:09:27 2016 UTC (4 years, 11 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q3-base, pkgsrc-2016Q3
Changes since 1.9: +7 -1 lines
Diff to previous 1.9 (colored)

Updated pkglint to 5.4.3.

Changes since 5.4.2:

* Variables like ${VAR_${OTHER_VAR}} are no longer checked for
  use/define mismatch
* The check for plural variable names has been removed
* The type of variables called *DESTDIR is no longer guessed to be a
  directory name
* The check for unknown shell commands is disabled in Makefile
  sections that depend on OPSYS
* The experimental hand-written shell parser has been replaced with
  a Yacc-generated one
* Meta packages don't need a LICENSE
* When PKGNAME is defined in terms of ${DISTNAME:S/from/to/:tl}, more
  modifiers (like :tl) are handled properly
* When the MAINTAINER or OWNER of a package is not the current user,
  a warning is printed for modified files
* The check for share/applications/*.desktop has been disabled, since
  pkglint would need to inspect the file's actual contents to see
  whether must be included or not
* Loosened the usage restrictions for several variables, e.g. many
  variables that may be appended in a Makefile may also be set
* PKG_OPTIONS_VAR must be of the form PKG_OPTIONS.*

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jun 5 11:24:32 2016 UTC (5 years ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q2-base, pkgsrc-2016Q2
Changes since 1.8: +30 -14 lines
Diff to previous 1.8 (colored)

Updated pkglint to 5.4.0.

Changes since 5.3.7:

* Replaced the -D... debug options with a single -d
* Omitted duplicate diagnostics
* Marked the :Q operator unnecessary for some variables
* Improved detection of whether has been included,
  which fixed unwarranted warnings about load time evaluation of
  some variables like ${ECHO} and ${SED}
* Improved detection for $(VAR) with round parentheses
* Fixed allowed locations for several variables
* Improved detection for used variables (still not perfect)
* Added warning that MASTER_SITES should not be used in HOMEPAGE
* Fixed warning about manual patches not being in distinfo
* Added a check for missing MASTER_SITE_* variables
* Added a check for unfinished url2pkg work
* Fixed several wrong warnings

Revision 1.8 / (download) - annotate - [select for diffs], Wed Jan 27 21:55:50 2016 UTC (5 years, 4 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2016Q1-base, pkgsrc-2016Q1
Changes since 1.7: +5 -7 lines
Diff to previous 1.7 (colored)

Updated pkglint to 5.3.4

Changes since 5.3.3:

* Added some unit tests
* Fixed the Makefile parser to recognize seldomly-used variable modifiers
  like :S///S/// without intermediate colon or :ts\n
* Cleaned up some unit tests
* Combined diagnostics that span multiple lines into single-line ones

Revision 1.7 / (download) - annotate - [select for diffs], Sun Jan 24 02:03:28 2016 UTC (5 years, 4 months ago) by rillig
Branch: MAIN
Changes since 1.6: +8 -0 lines
Diff to previous 1.6 (colored)

Updated pkglint to 5.3.2

Changes since 5.3.1:

Alignment of variable values is no longer checked by single line, but by
the complete block (e.g. SUBST_*).  Pkglint now checks that all variables
belonging to a block are indented consistently, so that their values are
aligned nicely.

Since pkglint does not report warnings, but only notes, and since it can
fix them automatically, the burden on the package developers will be very
low. Especially, since these notes are only printed when pkglint is called
with the -Wspace or -Wall options.

Also, pkglint supports running its unit tests now.

Revision 1.6 / (download) - annotate - [select for diffs], Tue Jan 12 01:02:48 2016 UTC (5 years, 5 months ago) by rillig
Branch: MAIN
Changes since 1.5: +67 -17 lines
Diff to previous 1.5 (colored)

Updated pkglint to 5.3

Changes since

* Makefile variables

The warnings about missing permissions sound more natural than before
and give a hint for alternative operators (e.g. set-default instead
of append), or an alternative file where setting this variable is
allowed instead (e.g. PKGREVISION may not be set in Makefile.common,
but in Makefile it is ok).

Warnings about "unknown" allowed permissions are not shown anymore,
since they didn't provide any benefit. To see them again, pkglint must
be run with the -Dunchecked option.

User-defined variables may be used by They may also be
used during load time, not only during run time, under the assumption
that in most cases the has already been loaded.

Some individual variables may be defined or used in places where this
was not allowed before. CHECK_BUILTIN.*, BUILDLINK_TARGETS,

A new parser for Makefile expressions detects and reports more
mistakes than bmake itself. Currently it is only used to check the
basic syntax; more applications are possible.


In PLIST files, conditionals of the form ${PLIST.*} are recognized and
are not part of the pathname. This allows pkglint to better check for
missing manual pages and correctly sorted PLIST files.

In --autofix mode, pkglint can sort PLIST files, which makes these
rather annoying warnings easy to fix.

No more warnings for man pages whose filename doesn't match exactly
the section, e.g. man/man3/exit.3c.

* Patches

The code for checking patch files has been completely rewritten, so
that it is easier understandable and well-structured. As an additional
benefit, it also became faster. Support for context diffs has been
dropped to a minimum, since they are not popular anymore.

Pkglint no longer warns about missing trailing whitespace in a line,
since all patch programs can handle these lines. It also doesn't
request empty lines between multiple diffs in a single file, since
that is simply not necessary.

Pkglint is picky when a patch file continues after the diff with some
text that still looks like a diff, since that means the patch doesn't
do what it looks like on first sight
(example: audio/faad2/patches/patch-au).

* Distinfo

When a patch file listed in distinfo cannot be found in the
filesystem, this is reported clearly instead of complaining about
missing SHA512 hashes (example: audio/libopus).

The inter-package distinfo check that verifies whether a distfile has
different hashes has been enabled. It had been disabled before, but
unintentionally so.

* Misc

- The check for COMMENT has been updated to reflect the changed
  default value from url2pkg.
- BUILDLINK_API_DEPENDS.* may be set in, even if the
  package is not the current one. (The other variables may be only set
  for the current package.)
- In shell commands, the escape sequence \. (and similar ones, which
  are often seen in sed(1) commands) no longer produces a warning,
  since the different shells handle these escape sequences
  consistently. (It is the echo(1) implementations that actually
  differ, therefore this warning was superfluous.)
- Compiler flags in backticks (typically `pkg-config --cflags`) are
  properly recognized.
- Internal pkglint errors when parsing shell commands have been fixed.
- No more warnings about PKGCONFIG_FILE.* being defined but unused.
- Dependencies of the form pkgbase>=1.0<5.0 are recognized.
- Diagnostics use quotes more often to indicate the placeholders.
- The type of GENERATE_PLIST has been changed from List of ShellWord
  to ShellCommands, since that is what the variable is really about.
- The type ShellCommand used to mean "a shell command line in a
  Makefile", which was confusing. Now it means what the name says,
  which reduces the wrong warnings for variables like CC (example:
- Improved checks to generate more helpful diagnostics.
- Fixed the parsing of dependency patterns, so that all but the most
  exotic ones are properly recognized.
- Fixed the parsing of shell variables of the form ${var%.c}.
- Updated the check for the default COMMENT from url2pkg.
- Many more small improvements.
- Performance has improved again, though only a little bit.
- Unit test coverage has increased from 64.2 % to 78.9 %.

This fixes most of the points mentioned in PR pkg/46570.

Revision 1.5 / (download) - annotate - [select for diffs], Sat Dec 5 21:00:42 2015 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
CVS Tags: pkgsrc-2015Q4-base, pkgsrc-2015Q4
Changes since 1.4: +13 -0 lines
Diff to previous 1.4 (colored)

Code reorganization, unit test for loading tool definitions

A run of "pkglint -r -Wall -Call" over the whole pkgsrc tree produces
identical output as before, therefore the version number is kept.

Revision 1.4 / (download) - annotate - [select for diffs], Sat Dec 5 15:16:29 2015 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.3: +0 -4 lines
Diff to previous 1.3 (colored)

Updated pkglint to 5.2.1.

Changes since 5.2:
* Fixed wrong warning about patches/CVS being an unrecorded patch
* pkgsrc-wip also needs NetBSD as RCS Id, instead of Id
* Code cleanup: grouped the checklineMk functions into one file

Revision 1.3 / (download) - annotate - [select for diffs], Sat Dec 5 08:54:08 2015 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.2: +17 -0 lines
Diff to previous 1.2 (colored)

Updated pkglint to 5.2.

Changes since 5.1:

* Fixed distinfo check for unrecorded patch files (thanks, wiz)
* Command line options parser accepts abbreviations (--a instead of --autofix)
* Realistic unit tests using temporary files
* General code cleanup (using gometalinter)

Revision 1.2 / (download) - annotate - [select for diffs], Wed Dec 2 21:46:46 2015 UTC (5 years, 6 months ago) by rillig
Branch: MAIN
Changes since 1.1: +4 -5 lines
Diff to previous 1.1 (colored)

Updated pkglint to 5.1.

Changes since 5.0:
* Fixed --autofix mode (it hadn't been enabled before)
* The --autofix mode now advertises itself when it can do something
* The --autofix mode now adds missing empty lines to patch files
  (only in the leading text section, not in the actual patch content)
* Made --autofix code simpler ({prepend,append}{Before,After} was not
  really needed)
* Fixed unit tests to report invalid command lines
* Added some more unit tests

Revision 1.1 / (download) - annotate - [select for diffs], Wed Nov 25 13:29:07 2015 UTC (5 years, 6 months ago) by rillig
Branch: MAIN

Updated pkglint to 5.0

Notable changes include:
* The whole code has been rewritten in Go
* It is much faster, especially in recursive mode
* The code has unit tests, providing examples of use
* Some new explanations for existing warnings
* Some adjustments to previous warnings

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

CVSweb <>