[BACK]Return to Makefile CVS log [TXT][DIR] Up to [cvs.NetBSD.org] / pkgsrc / multimedia / ffplay4

File: [cvs.NetBSD.org] / pkgsrc / multimedia / ffplay4 / Makefile (download)

Revision 1.9, Sun May 31 07:42:13 2020 UTC (3 years, 9 months ago) by rillig
Branch: MAIN
Changes since 1.8: +3 -1 lines

multimedia/ffmpeg4: fix USE_LANGUAGES

multimedia/ffmpeg4 does not need -std=gnu99, only ffplay4 does.

Since mk/compiler.mk is protected by a multiple-inclusion guard, any
later assignment to USE_LANGUAGES has no effect except being confusing.
The additional languages show up in "bmake show-var" but at the point of
evaluation, they had not been set yet.

This can be detected by several pkgsrc tools:

pkglint says:

WARN: ../../multimedia/ffmpeg4/Makefile.common:14: Modifying
  USE_LANGUAGES after including ../../mk/compiler.mk has no effect.

Adding a manual check to mk/compiler.mk results in:

bmake[1]: "mk/compiler.mk" line 273: warning:
  For multimedia/ffmpeg4, only languages "c" are used,
  the others in "c99" were defined too late.

Making the variable USE_LANGUAGES read-only after including
mk/compiler.mk results in:

bmake[1]: "multimedia/ffmpeg4/Makefile.common" line 14:
  Read-only USE_LANGUAGES cannot be set

(The latter two checks are not yet in the official pkgsrc tree.)

# $NetBSD: Makefile,v 1.9 2020/05/31 07:42:13 rillig Exp $

PKGNAME=	${DISTNAME:S/ffmpeg/ffplay4/}
MAINTAINER=	pkgsrc-users@NetBSD.org
HOMEPAGE=	https://ffmpeg.org/
COMMENT=	Simple SDL frontend for FFmpeg

DISTINFO_FILE=		${.CURDIR}/../ffmpeg4/distinfo

USE_LANGUAGES=	c99

CONFIGURE_ARGS+=	--disable-ffmpeg
CONFIGURE_ARGS+=	--disable-ffprobe
CONFIGURE_ARGS+=	--disable-encoders
CONFIGURE_ARGS+=	--disable-decoders
CONFIGURE_ARGS+=	--disable-hwaccels
CONFIGURE_ARGS+=	--disable-muxers
CONFIGURE_ARGS+=	--disable-demuxers
CONFIGURE_ARGS+=	--disable-parsers
CONFIGURE_ARGS+=	--disable-bsfs
CONFIGURE_ARGS+=	--disable-protocols
CONFIGURE_ARGS+=	--disable-devices
CONFIGURE_ARGS+=	--disable-filters
CONFIGURE_ARGS+=	--disable-htmlpages
CONFIGURE_ARGS+=	--disable-podpages
CONFIGURE_ARGS+=	--disable-txtpages
CONFIGURE_ARGS+=	--enable-ffplay
CONFIGURE_ARGS+=	--enable-dct
CONFIGURE_ARGS+=	--enable-mdct
CONFIGURE_ARGS+=	--enable-rdft

INSTALLATION_DIRS+=	bin ${PKGMANDIR}/man1

do-install:
	${INSTALL_PROGRAM} ${WRKSRC}/ffplay4 ${DESTDIR}${PREFIX}/bin
	${INSTALL_MAN} ${WRKSRC}/doc/ffplay4.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1

.include "../../devel/SDL2/buildlink3.mk"
.include "../../multimedia/ffmpeg4/buildlink3.mk"
.include "../../multimedia/ffmpeg4/Makefile.common"