CVS log for pkgsrc/games/nethack-lib/Makefile.common

Up to [cvs.NetBSD.org] / pkgsrc / games / nethack-lib

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

games/nethack-lib: really force the use of ncurses.

Use PREFER.curses=pkgsrc despite objections of pkglint. It's the only thing
that works. buildlink3/bsd.builtin.mk allows it.

games/nethack*: enable curses user interface

The "nethack" wrapper script that papers over the existence of nethack-tty
and nethack-x11 has been made more like the original way to select UIs
(since there are now 3, and each game binary supports more than one of them).

games/nethack-lib: enhance patches to make wip/nethack-curses possible.

games/nethack-lib: updated NetHack to version 3.6.7.

NetHack 3.6.7 is the official release of NetHack that follows NetHack 3.6.6.

This release primarily corrects a security issue present in NetHack versions
3.6.2, 3.6.3, 3.6.4, 3.6.5, and 3.6.6. For details about the security issues
please see https://www.nethack.org/security. You are encouraged to update to
NetHack 3.6.7 as soon as possible.

Here's a brief synopsis of the handful of bug fixes included in NetHack 3.6.7:

    invalid status highlight color could be maliciously used to corrupt memory
    formatting corpse names used internal buffers differently from formatting
other objects and could potentially clobber memory
    during engraving, spaces were counted instead of non-space (cherry-pick of
4e0a1e04 from NetHack-3.7)
    avoid potential buffer overflow in append_str()
    resolve missing dependency in NetHack.sln
    code in include/tradstdc.h was trying to suppress warn_unused result by
defining warn_unused_result to an empty string and that began causing a build
error within a system-supplied header file cdefs.h when using Ubuntu Impish
21.10; disable that for any Linux and macOS gcc unless GCC_URWARN is defined to
force it back into effect
    update_inventory() after leash goes slack
    player assigned name for monsters, specific objects, or object types could
be longer than what was intented to be allowed; for 'curses', much longer
    curses: cherry-picked selectsaved code from 3.7 for menu of save files
    NetHackW: fix delayed rendering of cursor when using farlook

nethack-lib: add CHECK_PORTABILITY_SKIP

The NetHack DevTeam is announcing the release of NetHack 3.6.6 on
March 8, 2020

NetHack 3.6.6 is the official release of NetHack that follows NetHack 3.6.5.

This release primarily corrects a security issue present in NetHack
versions 3.6.1, 3.6.2, 3.6.3, 3.6.4 and 3.6.5.
For details about the security issues please see https://www.nethack.org/security.
You are encouraged to update to NetHack 3.6.6 as soon as possible.

Here's a brief synopsis of the handful of bug fixes included in NetHack 3.6.6:

 *  invalid status highlight color could be maliciously used to corrupt memory
 *  formatting corpse names used internal buffers differently from formatting
 *      other objects and could potentially clobber memory
 *  avoid divide by 0 crash if 'bogusmon' (file of bogus monster types) is empty
 *  avoid #wizrumorcheck crash if either 'rumors.tru' or 'rumors.fal' or both
 *      were empty when makedefs built 'rumors'
 *  avoid "<mon>'s glorkum pass harmlessly through the shade" for weaponless mon

All of the fixes have been published on the public Git repository for the game.
A more complete list can be found in the game's sources in doc/fixes36.6. As usual,
a warning that some entries in that file may also be "spoilers".

Existing saved games and bones files from 3.6.0 through to 3.6.5 should work with
3.6.6, assuming that the same build configuration options were used.

The following command can be used on most platforms to help confirm the location of
various files that NetHack may use:
    nethack --showpaths

games/nethack: update to 3.6.5.

The NetHack DevTeam is announcing the release of NetHack 3.6.5 on January 27,
2020

NetHack 3.6.5 is the official release of NetHack that follows NetHack 3.6.4.

This release primarily corrects security issues present in NetHack versions
3.6.0, 3.6.1, 3.6.2, 3.6.3 and 3.6.4.

CVE-2020-5214	Error recovery after syntax error in configuration file is
                subject to a buffer overflow
CVE-2020-5213	SYMBOL configuration file option is subject to a buffer overflow
CVE-2020-5212	MENUCOLOR configuration file option is subject to a buffer
                overflow
CVE-2020-5211	AUTOCOMPLETE configuration file option is subject to a buffer
                overflow
CVE-2020-5210	NetHack command line -w option parsing is subject to a buffer
                overflow
CVE-2020-5209	Command line parsing of options starting with -de and -i is
                subject to a buffer overflow
CVE-2019-19905	Privilege escalation/remote code execution/crash in
                configuration parsing

You are encouraged to update to NetHack 3.6.5 as soon as possible.

Here's a brief synopsis of the handful of bug fixes included in NetHack 3.6.5:

    fix accessing mons[-1] when trying to gate in a non-valid demon
    fix accessing mons[-1] when monster figures out if a tin cures stoning
    have string_for_opt() return empty_optstr on failure
    ensure existing callers of string_for_opt() check return value
      before using it
    fix potential buffer overflow in add_menu_coloring()
    fix potential buffer overflow in sym_val()
    fix potential buffer overflow in pline(), raw_printf(), and
      config_error_add()
    fix potential buffer overflow in choose_windows()
    use vsnprintf instead of vsprintf in pline.c where possible
    Windows: includes a fix from a 3.6.4 post-release update where
      OPTIONS=map_mode:fit_to_screen could cause a game start failure
    Windows: users with C-locale unmappable names could get game start failure

All of the fixes have been incrementally published on the public Git
repository for the game. A more complete list can be found in the game's
sources in doc/fixes36.5. As usual, a warning that some entries in that
file may also be "spoilers".

Existing saved games and bones files from 3.6.0 through to 3.6.4 should
work with 3.6.5, assuming that the same build configuration options were
used.

all: migrate homepages from http to https

pkglint -r --network --only "migrate"

As a side-effect of migrating the homepages, pkglint also fixed a few
indentations in unrelated lines. These and the new homepages have been
checked manually.

games/nethack: security update to 3.6.4.

https://www.nethack.org/security/index.html:

NetHack: Privilege escalation/remote code execution/crash in
configuration parsing

Severity: High
Affected versions: 3.6.0, 3.6.1, 3.6.2, 3.6.3
First Patched Version: 3.6.4

Basic Information:
A buffer overflow issue exists when reading very long lines from a
NetHack configuration file (usually named .nethackrc).

This vulnerability affects systems that have NetHack installed suid/sgid
and shared systems that allow users to upload their own configuration
files.

All users are urged to upgrade to NetHack 3.6.4 as soon as possible.

Additional information related to this advisory, if any, will be made
available at https://nethack.org/security.

Update to NetHack 3.6.3.

From https://www.nethack.org/v363/release.html :

 NetHack 3.6.3 is the official release of NetHack that follows NetHack 3.6.2.
Here's a synopsis of over 190 bug fixes and over 22 game enhancements and
community contributions made since the release of 3.6.2 in May 2019:

    Fixed stale 'thrownobj' pointer for returning thrown aklys while engulfed
    Fixed uarmh null pointer dereference if a helm of opposite alignment came off due to being polymorphed
    Fixed 'object lost' panic when attempting to crawl of of the water during emergency disrobing/dropping
    Running now stops when moving over engravings so you can tell where they are
    Fixed detection of unseen/secret doors which failed to find monsters hiding under objects and failed to find monsters hiding at trap locations
    Ensured fatal status conditions made it to disclosure and/or dumplog
    Fixed "Bad fruit #N" warnings when saving bones with 'perm_invent' On
    Fixed it so yellow dragons don't have green breath
    Added several grammar corrections
    Improved recognition of deafness for several situations including the playing of musical instruments and bribing negotiations with demon lords
    Fixed ignoring of god's wrath when hero injured himself during altar kick
    Fixed several cases where persistent inventory window was not updated
    Fixed temple priests or shopkeepers moving over other monsters
    Fixed a crash-causing bug when putting on levitation boots over a sink
    Ensured that thrown or kicked objects will end up in bones
    Made water go all the way to the edges of level on the Plane of Water
    Made clouds disrupt line of sight along the edges of the Plane of Air
    Improved and expanded usage of status highlighting percentage rules
    Added more than 15 improvements and fixes to the curses window port
    Added and documented significant changes to default directory choices for the Windows platform
    Improved the layout and display of the player selection dialog used on the Windows graphical implementation
    Improved performance of some tty versions by reducing the number of function calls made from mapglyph
    Allowed the msdos implementation to build with curses and PDCurses
    Over 100 other fixes and improvements

All of the fixes have been incrementally published on the public Git repository
for the game. A more complete list can be found in the game's sources in
doc/fixes36.3. As usual, a warning that some entries in that file may also be
"spoilers".

As with all releases of the game, we appreciate your feedback. Please submit
any bugs using the problem report form. Also, please check the "known bugs"
list before you log a problem - somebody else may have already found it.

Happy NetHacking!

The project migrated from SourceForge to GitHub.
Master site was also changed to nethack.org.

Fix incorrect wording in a comment

Update to NetHack 3.6.2

See release notes for the changes from 3.4.3:
* http://nethack.org/v360/release.html
* http://nethack.org/v361/release.html
* http://nethack.org/v362/release.html

IMPORTANT NOTICE:
  Old 3.4.x save files are *incompatible* with this version (which
  isn't my fault). Files are now saved in /var/games/nethack360.

nethack*: reset MAINTAINER

pkgsrc doesn't support PREFIX with spaces or other special characters.
Therefore it is not necessary to add the :Q modifier to this variable
and several others.

pkglint -r -Wall --autofix --only :Q

nethack-lib: Honour CFLAGS, simplify and fix patching.

*: remove qt3 and the packages using it, including KDE3

Announced in https://mail-index.netbsd.org/pkgsrc-users/2017/09/10/msg025556.html

Use the infrastructure to find termcap correctly.

Use OPSYSVARS.

Update MASTER_SITES.

Noticed by Adrien Fernandes via netbsd-users@.

Drop superfluous PKG_DESTDIR_SUPPORT, "user-destdir" is default these days.

DESTDIRify nethack. Merge patches and distinfo. Some other improvements.
From Rhialto in PR 45010.

MAKE_JOBS_SAFE=no

Fix conditional for games/nethack.

Some more packages need lex and yacc. Patch by Aleksey Cheusov on
pkgsrc-users.

Whitespace cleanup, courtesy of pkglint.
Patch provided by Sergey Svishchev in private mail.

wrap most of this file around !NO_BUILD so that inclusion from
games/nethack doesn't confuse pkgsrc into trying to do configuration
even when NO_CONFIGURE is specified there.  fixes build of
games/nethack (well, "build", actually)

You feel like someone is helping you.

Fix build on Linux.  Use ncurses instead of termlib.  Defined SYSV
instead of BSD.  This addresses PR#29424

Fix build on i386 Mac OS X 10.4.7.
Use ncurses since OS X lacks termlib.
Create group games since OS X lacks it.

Note where gzip or gunzip is required by the package since it isn't
required by default any longer in bsd.pkg.mk under the new tools
framework.

Fix sourceforge URL.
"Apparently, Sourceforge has reorganized its FTP server. The source for
nethack has been moved. Consequently, a NetBSD mirror will be contacted
for fetching the source."
Closes PR pkg/26826. Thank you Alexander Becher.

Nethack 3.4.3

This is a bugfix-release.  It should be compatible with bones files
and savegames all the way back to 3.4.0 (but of course it's safer
to ascend before upgrade).

Assorted fixes (full list in doc/fixes34.3):
  * Correct several inconsistencies
  * Correct a potentially fatal bug caused by dropping loadstones
  * Handle level completely filled with monsters better
  * X11 player selection fixes, one of which could be fatal
  * Eliminated a gold-in-shop-container cheat

Move WRKSRC definition away from the first paragraph in a Makefile.

Add handling for the nethack directories plus record and logfile to make
them have the correct permission bits set when using binary packages.

Thanks go to Damian Sweeney for noticing the problem and at least
grant, salo and wiz for beating me with a cluestick so that I could
fix it.

manually bump version to 3.4.2nb1

Update to NetHack 3.4.2

This is a bugfix release which fixes over 100 bugs including but
not limited to:

*  Fixed a fatal bug that triggered a panic when your secondary weapon
   was cursed during bones file creation
*  Fixed a fatal bug that caused a crash when applying figurine, candle,
   or bell that gets used up

for a complete list, see doc/fixes34.2

Old savegames and bones levels from nethack 3.4.1 (and 3.4.0) should
still work, but as usual, caution is advised.

s/netbsd.org/NetBSD.org/

Rework to not do configure/patch rules if NO_CONFIGURE or NO_BUILD is set

Place WRKSRC where it belongs, to make pkglint happy; ok'ed by wiz.

Pullup nethack version 3.4.1 to netbsd-1-6-1 pkgsrc branch.

Requested by Antti Kantee.

> Date: Sat,  1 Mar 2003 23:12:53 +0200 (EET)
>
>
> Module Name:    pkgsrc
> Committed By:   pooka
> Date:           Sat Mar  1 21:12:53 UTC 2003
>
> Modified Files:
>         pkgsrc/games/nethack-lib: Makefile.common distinfo
>         pkgsrc/games/nethack-lib/patches: patch-aa patch-ab patch-ac patch-ae
>         pkgsrc/games/nethack-qt: Makefile distinfo
>         pkgsrc/games/nethack-qt/patches: patch-aa patch-ab patch-ac patch-ae
>             patch-af patch-ag patch-ah patch-ai
>         pkgsrc/games/nethack-tty: distinfo
>         pkgsrc/games/nethack-x11: Makefile distinfo
>         pkgsrc/games/nethack-x11/patches: patch-aa patch-ab patch-ac patch-af
>             patch-ag patch-ah
> Removed Files:
>         pkgsrc/games/nethack-lib/patches: patch-ah
>         pkgsrc/games/nethack-qt/patches: patch-aj
>         pkgsrc/games/nethack-x11/patches: patch-ai
>
> Log Message:
> Hello NetHack 3.4.1
>
> This is a bugfix release, no new features introduced.
>
> As a compensation for no new features, savegames and bones levels
> from NetHack 3.4.0 should work, and that's why I kept the datafile
> directory named nethackdir340. In theory you should be able to
> simply update the nethack pkgs and continue playing, but I'll not
> accept any death threats if it doesn't work, so please make sure
> you make the appropriate backups before trying.

Hello NetHack 3.4.1

This is a bugfix release, no new features introduced.

As a compensation for no new features, savegames and bones levels
from NetHack 3.4.0 should work, and that's why I kept the datafile
directory named nethackdir340. In theory you should be able to
simply update the nethack pkgs and continue playing, but I'll not
accept any death threats if it doesn't work, so please make sure
you make the appropriate backups before trying.

fix buffer overrun (games group vulnerability) when running nethack -s

patch from nethack.org

Make the name of nethackdir contain version information (eg. now it's
called nethackdir340). This is to ease the lives of people who wish to
have multiple versions nethack installed at the same time. It is not fully
automated, because doing pkgsrc magic will most likely screw things up
one funny way or another. And we all know that the most important thing
in this world is the nethack scorefile ...

Manually bump version to 3.4.0nb1.

Upgrade nethack packages to NetHack 3.4.0

Highlights of the new release:
* numerous bugfixes

* stamina affects ability to throw heavy things
* objects merge in containers
* several small refinements to race/role separation
* more feedback about skill advancement from #enhance command
* "autodig" option
* option for starting without a pet
+ many more, read doc/fixes34.0

Old savegames naturally don't work, so make sure you finish old ones
before upgrading the package.

Also fixes the rest of pkg/15717 by Bernd Ernesti. Solution was the same
as what Thomas Klausner used to fix angband (ie. simply duplicate the
patches)

md5 not shared anymore (different patches). Remove DIGEST_FILE line.

${MD5_FILE} -> ${DIGEST_FILE}

No need to use quotes here. Removing them makes it easier for pkglint.

Switch maintainership over to me as discussed with Tim.

Upgrade nethack to 3.3.1. Add Makefile.common to easy future upgrades.

This release contains numerous fixes to bugs in 3.3.0 and users are advised
to upgrade.

Note that old savegames and bones files won't work anymore.