[BACK]Return to patch-src_ldapcontrol.cpp CVS log [TXT][DIR] Up to [cvs.NetBSD.org] / pkgsrc / databases / kldap / patches
File: [cvs.NetBSD.org] / pkgsrc / databases / kldap / patches / patch-src_ldapcontrol.cpp (download)

Revision 1.1, Tue Feb 18 16:49:13 2020 UTC (4 years, 2 months ago) by joerg
Branch: MAIN
CVS Tags: pkgsrc-2021Q1-base, pkgsrc-2021Q1, pkgsrc-2020Q4-base, pkgsrc-2020Q4, pkgsrc-2020Q3-base, pkgsrc-2020Q3, pkgsrc-2020Q2-base, pkgsrc-2020Q2, pkgsrc-2020Q1-base, pkgsrc-2020Q1 

Passing non-POD types to variadic functions is UB. Use plain C strings.

$NetBSD: patch-src_ldapcontrol.cpp,v 1.1 2020/02/18 16:49:13 joerg Exp $

--- src/ldapcontrol.cpp.orig	2020-01-14 16:22:02.256391951 +0000
+++ src/ldapcontrol.cpp
@@ -123,7 +123,7 @@ int LdapControl::parsePageControl(QByteA
 
     Ber ber(d->mValue);
     int size;
-    if (ber.scanf(QStringLiteral("{iO}"), &size, &cookie) == -1) {
+    if (ber.scanf("{iO}", &size, &cookie) == -1) {
         return -1;
     } else {
         return size;
@@ -135,7 +135,7 @@ LdapControl LdapControl::createPageContr
     LdapControl control;
     Ber ber;
 
-    ber.printf(QStringLiteral("{iO}"), pagesize, &cookie);
+    ber.printf("{iO}", pagesize, &cookie);
     control.setOid(QStringLiteral("1.2.840.113556.1.4.319"));
     control.setValue(ber.flatten());
     return control;